generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: handles null COS instance CRN in locals to prevent parsing errors #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aatreyee257
wants to merge
13
commits into
main
Choose a base branch
from
i-16700
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−50
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0e4730a
changed validation
03e8932
fix:pre-commit
4ec5d3f
fix: pre-commit
9972aec
fix
2a997e9
fixes
b4b01df
Update solutions/fully-configurable/main.tf
aatreyee257 95d1ea9
Update solutions/fully-configurable/main.tf
aatreyee257 edd6c78
resolved comments
723b942
Merge branch 'i-16700' of https://github.com/terraform-ibm-modules/te…
77b7a90
resolved comments
4394851
fixes
8fd78a0
fixes
148008f
Merge branch 'main' into i-16700
aatreyee257 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule common-dev-assets
updated
16 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to track where this is used to ensure this doesn't cause an issue if it gets set to null. What I found is this:
local.cos_instance_guidis only used by theibm_iam_authorization_policy.policyresource in the DAibm_iam_authorization_policy.policyresource is usinglocal.create_cross_account_auth_policyto determine if the auth policy should be created or notlocal.create_cross_account_auth_policyis only getting set to true if!var.skip_cos_kms_auth_policy && var.ibmcloud_kms_api_key != null. This is NOT correct for the COS auth policy. The COS auth policy needs to useibmcloud_cos_api_keyin its logic to determine if the cross account COS policy should be created, NOTibmcloud_kms_api_key.I suggest to create two different locals:
local.create_kms_cross_account_auth_policyandlocal.create_cos_cross_account_auth_policy