From 62871df4fd9c7104cecc95a118b48150be666b51 Mon Sep 17 00:00:00 2001
From: pawan1210 <pawansaggu@google.com>
Date: Thu, 16 Oct 2025 14:45:45 +0000
Subject: [PATCH] fix: added random number suffix to service_account_prefix
 local variable

---
 modules/instance_template/main.tf     | 7 ++++++-
 modules/instance_template/versions.tf | 4 ++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/modules/instance_template/main.tf b/modules/instance_template/main.tf
index fe2b8c72..4cf6601b 100644
--- a/modules/instance_template/main.tf
+++ b/modules/instance_template/main.tf
@@ -75,7 +75,7 @@ locals {
   )
   create_service_account = var.create_service_account ? var.service_account == null : false
 
-  service_account_prefix = substr("${var.name_prefix}-${var.region}", 0, 27)
+  service_account_prefix = "${substr("${var.name_prefix}-${var.region}", 0, 23)}-${random_integer.sa_suffix.result}"
   service_account_output = local.create_service_account ? {
     id     = google_service_account.sa[0].account_id,
     email  = google_service_account.sa[0].email,
@@ -83,6 +83,11 @@ locals {
   } : {}
 }
 
+resource "random_integer" "sa_suffix" {
+  min = 1000
+  max = 9999
+}
+
 # Service account
 resource "google_service_account" "sa" {
   provider = google-beta
diff --git a/modules/instance_template/versions.tf b/modules/instance_template/versions.tf
index cbcf9ab9..d19b7b42 100644
--- a/modules/instance_template/versions.tf
+++ b/modules/instance_template/versions.tf
@@ -21,6 +21,10 @@ terraform {
       source  = "hashicorp/google-beta"
       version = ">= 5.36, < 8"
     }
+    random = {
+      source  = "hashicorp/random"
+      version = "< 4.0"
+    }
   }
   provider_meta "google" {
     module_name = "blueprints/terraform/terraform-google-vm:instance_template/v13.6.1"