fix: Fixed opposite refresh_alias behavior in modules/alias (#372)

micksatana · web-flow · commit f7b2a3a5e4f9 · 2022-11-11T17:46:15.000+01:00
diff --git a/examples/alias/main.tf b/examples/alias/main.tf
@@ -34,8 +34,6 @@ module "lambda_function" {
   create_async_event_config    = true
   maximum_event_age_in_seconds = 100
 
-  provisioned_concurrent_executions = 1
-
   attach_policies = true
   policies = [
     "arn:aws:iam::aws:policy/service-role/AWSLambdaSQSQueueExecutionRole",
diff --git a/modules/alias/main.tf b/modules/alias/main.tf
@@ -27,6 +27,10 @@ resource "aws_lambda_alias" "no_refresh" {
       additional_version_weights = var.routing_additional_version_weights
     }
   }
+
+  lifecycle {
+    ignore_changes = [function_version]
+  }
 }
 
 resource "aws_lambda_alias" "with_refresh" {
@@ -45,10 +49,6 @@ resource "aws_lambda_alias" "with_refresh" {
       additional_version_weights = var.routing_additional_version_weights
     }
   }
-
-  lifecycle {
-    ignore_changes = [function_version]
-  }
 }
 
 resource "aws_lambda_function_event_invoke_config" "this" {

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@ resource "aws_lambda_alias" "no_refresh" {`
`27`	`27`	`additional_version_weights = var.routing_additional_version_weights`
`28`	`28`	`}`
`29`	`29`	`}`
	`30`	`+`
	`31`	`+ lifecycle {`
	`32`	`+ ignore_changes = [function_version]`
	`33`	`+ }`
`30`	`34`	`}`
`31`	`35`
`32`	`36`	`resource "aws_lambda_alias" "with_refresh" {`
`@@ -45,10 +49,6 @@ resource "aws_lambda_alias" "with_refresh" {`
`45`	`49`	`additional_version_weights = var.routing_additional_version_weights`
`46`	`50`	`}`
`47`	`51`	`}`
`48`		`-`
`49`		`- lifecycle {`
`50`		`- ignore_changes = [function_version]`
`51`		`- }`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`resource "aws_lambda_function_event_invoke_config" "this" {`