Support for DECODE operator #3213
Conversation
@tensorflow/micro Add support for alternate decompression memory to DECODE operator. Additional unit tests. Update generic benchmark application and Makefile. bug=fixes tensorflow#3212
ddavis-2015
force-pushed
the
decode-tcm
branch
from
b582198 to
59589c6
Compare
veblush
left a comment
veblush
left a comment
There was a problem hiding this comment.
Thank you for the PR; I have some minor feedback.
Regarding the decompression memory: How is the required size calculated, and do we have tooling for that? Also, when is it preferable to use multiple decompression regions rather than just one?
| TF_LITE_MICRO_EXPECT_TRUE(invalid_output == nullptr); | ||
| } | ||
|
|
||
| TF_LITE_MICRO_TEST(TestSetDecompressionMemory) { |
There was a problem hiding this comment.
Could you please add comments explaining why these specific state checks are necessary?
| kAllocateSize, tflite::MicroArenaBufferAlignment())); | ||
| TF_LITE_MICRO_EXPECT(p == &g_alt_memory[16]); | ||
|
|
||
| // fail next allocation |
There was a problem hiding this comment.
Please add a comment here clarifying that this fails due to 16-byte alignment overhead (consuming 26 of the 30 bytes after just two allocations). The first time I saw this, this was puzzling because 10 x 3 = 30 ;)
| TfLiteTensor* output = nullptr; | ||
| TfLiteStatus status = kTfLiteOk; | ||
|
|
||
| micro_context->ResetDecompressionMemoryAllocations(); |
There was a problem hiding this comment.
Does this mean that there will be only one Decode node in the entire graph? It looks like that if there were two Decode nodes, the second one's Prepare call would wipe out the memory assignments planned by the first one.
There was a problem hiding this comment.
<discussion moved to alternate venue>
| size_t tensor_output_index, | ||
| TfLiteTensor* output) { | ||
| if (output->data.data != nullptr) { | ||
| // If memory has already been assigned to the tensor, leave it be |
There was a problem hiding this comment.
I'm curious how this would happen?
There was a problem hiding this comment.
<discussion moved to alternate venue>
@veblush The required size and number of regions are decided by the application. TFLM makes no assumptions about the processor memory. There is no tooling associated with alternate decompression memory. An API for the MicroInterpreter is supplied, and it is up to the application developer as to how they wish to use it. An example of how the API is used is available in the Generic Benchmark application, and its associated documentation. |
3 participants
@tensorflow/micro
Add support for alternate decompression memory to DECODE operator. Additional unit tests.
Update generic benchmark application and Makefile.
bug=fixes #3212