Remove strict_deps = False from some sass rules, that are no longer necessary (#6743)

arcra · web-flow · commit ffa86a8fa7df · 2024-02-01T17:10:47.000-08:00
`strict_deps = False` in sass rules were originally added due to requirements from internal code base in #6184, but *some of them* are now being removed. Googlers, see b/323361346. This should be a no-op for OSS.
diff --git a/tensorboard/defs/defs.bzl b/tensorboard/defs/defs.bzl
@@ -255,8 +255,6 @@ def tf_sass_binary(deps = [], include_paths = [], strict_deps = True, **kwargs):
     strict_deps is included here and intentionally ignored so it can be used
     internally.
     """
-    if (strict_deps):
-        fail("all tf_sass_binary calls need to have the strict_deps = False override for internal calls");
     sass_binary(
         deps = deps,
         include_paths = include_paths + [
diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD
@@ -8,7 +8,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "debugger_component_style",
     src = "debugger_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "execution_data_styles",
     src = "execution_data_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "graph_styles",
     src = "graph_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "graph_executions_styles",
     src = "graph_executions_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "source_files_component_style",
     src = "source_files_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD b/tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "stack_trace_styles",
     src = "stack_trace_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/BUILD b/tensorboard/webapp/BUILD
@@ -88,7 +88,6 @@ tf_ts_library(
 tf_sass_binary(
     name = "app_styles",
     src = "app_container.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
@@ -385,6 +384,5 @@ tf_external_sass_libray(
 tf_sass_binary(
     name = "styles",
     src = "styles.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
diff --git a/tensorboard/webapp/core/views/BUILD b/tensorboard/webapp/core/views/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "layout_styles",
     src = "layout_container.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/feature_flag/views/BUILD b/tensorboard/webapp/feature_flag/views/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "style",
     src = "feature_flag_dialog_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/header/BUILD b/tensorboard/webapp/header/BUILD
@@ -7,14 +7,12 @@ licenses(["notice"])
 tf_sass_binary(
     name = "plugin_selector_styles",
     src = "plugin_selector_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
 tf_sass_binary(
     name = "header_styles",
     src = "header_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/metrics/views/BUILD b/tensorboard/webapp/metrics/views/BUILD
@@ -12,7 +12,6 @@ tf_sass_library(
 tf_sass_binary(
     name = "metrics_container_styles",
     src = "metrics_container.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/metrics/views/card_renderer/BUILD b/tensorboard/webapp/metrics/views/card_renderer/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "card_view_styles",
     src = "card_view_container.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
@@ -43,7 +42,6 @@ tf_ng_module(
 tf_sass_binary(
     name = "data_download_dialog_styles",
     src = "data_download_dialog_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
@@ -131,7 +129,6 @@ tf_ng_module(
 tf_sass_binary(
     name = "image_card_styles",
     src = "image_card_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/metrics/views:metrics_common_styles",
@@ -179,7 +176,6 @@ tf_ng_module(
 tf_sass_binary(
     name = "run_name_styles",
     src = "run_name_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
@@ -209,7 +205,6 @@ tf_ng_module(
 tf_sass_binary(
     name = "vis_linked_time_selection_warning_styles",
     src = "vis_linked_time_selection_warning_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/metrics/views/main_view/BUILD b/tensorboard/webapp/metrics/views/main_view/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "main_view_styles",
     src = "main_view_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/metrics/views:metrics_common_styles",
@@ -16,7 +15,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "filter_input_component_styles",
     src = "filter_input_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
@@ -37,7 +35,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "pinned_view_component_styles",
     src = "pinned_view_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/metrics/views:metrics_common_styles",
@@ -48,7 +45,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "card_grid_component_styles",
     src = "card_grid_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp/metrics/views:metrics_common_styles",
         "//tensorboard/webapp/theme",
@@ -58,7 +54,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "card_groups_component_styles",
     src = "card_groups_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp/metrics/views:metrics_common_styles",
         "//tensorboard/webapp/theme",
@@ -68,7 +63,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "card_group_toolbar_component_styles",
     src = "card_group_toolbar_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp/metrics/views:metrics_common_styles",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/metrics/views/right_pane/BUILD b/tensorboard/webapp/metrics/views/right_pane/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "settings_view_styles",
     src = "settings_view_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD b/tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "scalar_column_editor_styles",
     src = "scalar_column_editor_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/notification_center/_views/BUILD b/tensorboard/webapp/notification_center/_views/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "notification_center_styles",
     src = "notification_center_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/plugins/BUILD b/tensorboard/webapp/plugins/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "plugins_component_styles",
     src = "plugins_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/runs/views/runs_table/BUILD b/tensorboard/webapp/runs/views/runs_table/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "runs_group_menu_button_styles",
     src = "runs_group_menu_button_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
@@ -17,21 +16,18 @@ tf_sass_binary(
 tf_sass_binary(
     name = "regex_edit_dialog_styles",
     src = "regex_edit_dialog_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
 tf_sass_binary(
     name = "filterbar_styles",
     src = "filterbar_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
 tf_sass_binary(
     name = "runs_data_table_styles",
     src = "runs_data_table.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/widgets/card_fob/BUILD b/tensorboard/webapp/widgets/card_fob/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "card_fob_styles",
     src = "card_fob_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/widgets/content_wrapping_input/BUILD b/tensorboard/webapp/widgets/content_wrapping_input/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "content_wrapping_input_component_styles",
     src = "content_wrapping_input_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/widgets/data_table/BUILD b/tensorboard/webapp/widgets/data_table/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "data_table_styles",
     src = "data_table_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
@@ -15,7 +14,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "header_cell_styles",
     src = "header_cell_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
@@ -44,7 +42,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "column_selector_component_styles",
     src = "column_selector_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
@@ -54,7 +51,6 @@ tf_sass_binary(
 tf_sass_binary(
     name = "filter_dialog_styles",
     src = "filter_dialog_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/widgets/dropdown/BUILD b/tensorboard/webapp/widgets/dropdown/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "dropdown_styles",
     src = "dropdown_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/widgets/experiment_alias/BUILD b/tensorboard/webapp/widgets/experiment_alias/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "experiment_alias_component_styles",
     src = "experiment_alias_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/widgets/filter_input/BUILD b/tensorboard/webapp/widgets/filter_input/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "filter_input_component_styles",
     src = "filter_input_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/widgets/histogram/BUILD b/tensorboard/webapp/widgets/histogram/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "histogram_styles",
     src = "histogram_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/widgets/line_chart_v2/BUILD b/tensorboard/webapp/widgets/line_chart_v2/BUILD
@@ -7,7 +7,6 @@ licenses(["notice"])
 tf_sass_binary(
     name = "line_chart_styles",
     src = "line_chart_component.scss",
-    strict_deps = False,
     deps = ["//tensorboard/webapp/theme"],
 )
 
diff --git a/tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD b/tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "line_chart_axis_view_styles",
     src = "line_chart_axis_view.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",
diff --git a/tensorboard/webapp/widgets/range_input/BUILD b/tensorboard/webapp/widgets/range_input/BUILD
@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
 tf_sass_binary(
     name = "range_input_styles",
     src = "range_input_component.scss",
-    strict_deps = False,
     deps = [
         "//tensorboard/webapp:angular_material_sass_deps",
         "//tensorboard/webapp/theme",

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ licenses(["notice"])`
`8`	`8`	`tf_sass_binary(`
`9`	`9`	`name = "debugger_component_style",`
`10`	`10`	`src = "debugger_component.scss",`
`11`		`- strict_deps = False,`
`12`	`11`	`deps = ["//tensorboard/webapp/theme"],`
`13`	`12`	`)`
`14`	`13`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ licenses(["notice"])`
`7`	`7`	`tf_sass_binary(`
`8`	`8`	`name = "source_files_component_style",`
`9`	`9`	`src = "source_files_component.scss",`
`10`		`- strict_deps = False,`
`11`	`10`	`deps = ["//tensorboard/webapp/theme"],`
`12`	`11`	`)`
`13`	`12`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,6 @@ tf_ts_library(`
`88`	`88`	`tf_sass_binary(`
`89`	`89`	`name = "app_styles",`
`90`	`90`	`src = "app_container.scss",`
`91`		`- strict_deps = False,`
`92`	`91`	`deps = ["//tensorboard/webapp/theme"],`
`93`	`92`	`)`
`94`	`93`
`@@ -385,6 +384,5 @@ tf_external_sass_libray(`
`385`	`384`	`tf_sass_binary(`
`386`	`385`	`name = "styles",`
`387`	`386`	`src = "styles.scss",`
`388`		`- strict_deps = False,`
`389`	`387`	`deps = ["//tensorboard/webapp/theme"],`
`390`	`388`	`)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])`
`5`	`5`	`tf_sass_binary(`
`6`	`6`	`name = "layout_styles",`
`7`	`7`	`src = "layout_container.scss",`
`8`		`- strict_deps = False,`
`9`	`8`	`deps = ["//tensorboard/webapp/theme"],`
`10`	`9`	`)`
`11`	`10`