Skip to content

Commit fcbae5e

Browse files
authored
Fix internal build error (#6800)
Add the missing arg for `extract_providers` and fix struct provider syntax. Googlers, see cl/617097191. #oncall
1 parent 32eb9e1 commit fcbae5e

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

tensorboard/defs/internal/html.bzl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@
1515
"""Rule for building the HTML binary."""
1616

1717
load("@io_bazel_rules_closure//closure:defs.bzl", "closure_js_aspect")
18-
load("@io_bazel_rules_closure//closure/private:defs.bzl", "WebFilesInfo", "collect_runfiles", "long_path", "unfurl") # buildifier: disable=bzl-visibility
19-
20-
# TODO(ytjing): Directly import this function once it's synced from OSS to internal rules_closure repo.
21-
def extract_providers(deps, provider):
22-
return [dep[provider] for dep in deps if provider in dep]
18+
load("@io_bazel_rules_closure//closure/private:defs.bzl", "WebFilesInfo", "collect_runfiles", "extract_providers", "long_path", "unfurl") # buildifier: disable=bzl-visibility
2319

2420
def _tb_combine_html_impl(ctx):
2521
"""Compiles HTMLs into one HTML.

tensorboard/defs/web.bzl

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,17 @@ load(
2222
"@io_bazel_rules_closure//closure/private:defs.bzl",
2323
"CLOSURE_LIBRARY_BASE_ATTR",
2424
"CLOSURE_WORKER_ATTR",
25+
"ClosureJsLibraryInfo",
2526
"WebFilesInfo",
2627
"collect_js",
2728
"collect_runfiles",
2829
"difference",
30+
"extract_providers",
2931
"long_path",
3032
"unfurl",
3133
)
3234
load("//tensorboard/defs/internal:html.bzl", _tb_combine_html = "tb_combine_html")
3335

34-
# TODO(ytjing): Directly import this function once it's synced from OSS to internal rules_closure repo.
35-
def extract_providers(deps, provider):
36-
return [dep[provider] for dep in deps if provider in dep]
37-
3836
def _tf_web_library(ctx):
3937
if not ctx.attr.srcs:
4038
if ctx.attr.deps:
@@ -55,6 +53,7 @@ def _tf_web_library(ctx):
5553

5654
# process what came before
5755
deps = extract_providers(ctx.attr.deps, provider = WebFilesInfo)
56+
deps = unfurl(deps)
5857
webpaths = depset(transitive = [dep.webpaths for dep in deps])
5958

6059
# process what comes now
@@ -96,11 +95,11 @@ def _tf_web_library(ctx):
9695
# If a rule exists purely to export other build rules, then it's
9796
# appropriate for the exported sources to be included in the
9897
# development web server.
99-
export_deps = unfurl(extract_providers(ctx.attr.exports))
98+
export_deps = unfurl(extract_providers(ctx.attr.exports, WebFilesInfo))
10099
devserver_manifests = depset(
101100
order = "postorder",
102101
transitive = (
103-
[manifests] + [dep[WebFilesInfo].manifests for dep in export_deps]
102+
[manifests] + [dep.manifests for dep in export_deps]
104103
),
105104
)
106105
params = struct(
@@ -134,10 +133,10 @@ def _tf_web_library(ctx):
134133
manifests = manifests,
135134
webpaths = webpaths,
136135
dummy = dummy,
137-
exports = export_deps,
136+
exports = unfurl(extract_providers(ctx.attr.exports, WebFilesInfo)),
138137
),
139138
collect_js(
140-
unfurl(deps),
139+
unfurl(extract_providers(ctx.attr.deps, provider = ClosureJsLibraryInfo)),
141140
ctx.files._closure_library_base,
142141
),
143142
DefaultInfo(

tensorboard/defs/zipper.bzl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@
1414

1515
"""Rule for zipping Webfiles."""
1616

17-
load("@io_bazel_rules_closure//closure/private:defs.bzl", "WebFilesInfo", "collect_runfiles", "unfurl") # buildifier: disable=bzl-visibility
18-
19-
# TODO(ytjing): Directly import this function once it's synced from OSS to internal rules_closure repo.
20-
def extract_providers(deps, provider):
21-
return [dep[provider] for dep in deps if provider in dep]
17+
load("@io_bazel_rules_closure//closure/private:defs.bzl", "WebFilesInfo", "collect_runfiles", "extract_providers", "unfurl") # buildifier: disable=bzl-visibility
2218

2319
def _tensorboard_zip_file(ctx):
2420
deps = extract_providers(ctx.attr.deps, provider = WebFilesInfo)

0 commit comments

Comments
 (0)