Pool Connection Error Handling

Author: Omar Marzouk

tensorflow_io/core/filesystems/dfs/dfs_filesystem.cc

@@ -217,7 +217,8 @@ void PathExists(const TF_Filesystem* filesystem, const char* path,
     return;
   }
   std::string pool, cont, file;
-  daos->Setup(path, pool, cont, file, status);
+  rc = daos->Setup(path, pool, cont, file, status);
+  if(rc) return;
   dfs_obj_t* obj;
   rc = daos->dfsPathExists(file, &obj);
   if (rc) {
@@ -665,4 +666,4 @@ void ProvideFilesystemSupportFor(TF_FilesystemPluginOps* ops, const char* uri) {
 
 }  // namespace dfs
 }  // namespace io
-}  // namespace tensorflow
+}  // namespace tensorflow

tensorflow_io/core/filesystems/dfs/dfs_utils.cc

@@ -96,7 +96,7 @@ int DFS::Setup(const std::string& path, std::string& pool_string,
   Connect(pool_string, cont_string, allow_cont_creation, status);
   if (TF_GetCode(status) != TF_OK) {
     TF_SetStatus(status, TF_NOT_FOUND, "");
-    return rc;
+    return -1;
   }
   return Mount();
 }
@@ -351,13 +351,13 @@ int DFS::ConnectPool(std::string pool_string, TF_Status* status) {
   }
 
   pool_info_t* po_inf = (pool_info_t*)malloc(sizeof(po_inf));
-  po_inf->containers = new std::map<std::string, daos_handle_t>();
-  pools[pool_string] = po_inf;
   rc = daos_pool_connect(pool_string.c_str(), NULL, DAOS_PC_RW, &(po_inf->poh),
                          NULL, NULL);
   if (rc == 0) {
     pool.first = pool_string;
     pool.second = po_inf->poh;
+    po_inf->containers = new std::map<std::string, daos_handle_t>();
+    pools[pool_string] = po_inf;
   }
   return rc;
 }
@@ -411,4 +411,4 @@ int DFS::DisconnectContainer(std::string pool_string, std::string cont_string) {
     pools[pool_string]->containers->erase(cont_string);
   }
   return rc;
-}
+}