Cleanup code for PR

Author: weiya711

src/index_notation/index_notation.cpp

@@ -2366,12 +2366,8 @@ bool isConcreteNotation(IndexStmt stmt, std::string* reason) {
       for (auto& var : op->indexVars) {
         // non underived variables may appear in temporaries, but we don't check these
         if (!boundVars.contains(var) && provGraph.isUnderived(var) && (provGraph.isFullyDerived(var) || !provGraph.isRecoverable(var, definedVars))) {
-          string string2 = "definedvars: ";
-          for (auto& d : definedVars)
-            string2.append(d.getName() + ", ");
-
           *reason = "all variables in concrete notation must be bound by a "
-                    "forall statement" + var.getName() + string2;
+                    "forall statement";
           isConcrete = false;
         }
       }

src/index_notation/provenance_graph.cpp

@@ -1136,21 +1136,23 @@ bool ProvenanceGraph::isRecoverable(taco::IndexVar indexVar, std::set<taco::Inde
   return isRecoverablePrecompute(indexVar, defined, producers, consumers);
 }
 
-bool ProvenanceGraph::isRecoverablePrecompute(taco::IndexVar indexVar, std::set<taco::IndexVar> defined, vector<IndexVar> producers, vector<IndexVar> consumers) const {
+bool ProvenanceGraph::isRecoverablePrecompute(taco::IndexVar indexVar, std::set<taco::IndexVar> defined,
+                                              vector<IndexVar> producers, vector<IndexVar> consumers) const {
   vector<IndexVar> childPrecompute;
   if (std::find(consumers.begin(), consumers.end(), indexVar) != consumers.end()) {
     return true;
   }
-  if (!producers.empty() && (childRelMap.count(indexVar) && childRelMap.at(indexVar).getRelType() == IndexVarRelType::PRECOMPUTE)) {
+  if (!producers.empty() && (childRelMap.count(indexVar) &&
+                             childRelMap.at(indexVar).getRelType() == IndexVarRelType::PRECOMPUTE)) {
     auto precomputeChild = getChildren(indexVar)[0];
     if (std::find(producers.begin(), producers.end(), precomputeChild) != producers.end()) {
       return true;
     }
     return isRecoverablePrecompute(precomputeChild, defined, producers, consumers);
   }
   for (const IndexVar& child : getChildren(indexVar)) {
-    if (!defined.count(child) && (isFullyDerived(child)
-                                  || !isRecoverablePrecompute(child, defined, producers, consumers))) {
+    if (!defined.count(child) && (isFullyDerived(child) ||
+                                  !isRecoverablePrecompute(child, defined, producers, consumers))) {
       return false;
     }
   }
@@ -1315,12 +1317,6 @@ bool ProvenanceGraph::hasExactBound(IndexVar indexVar) const {
   {
     return rel.getNode<BoundRelNode>()->getBoundType() == BoundType::MaxExact;
   }
-//  else if (rel.getRelType() == SPLIT)
-//  {
-//    return rel.getNode<SplitRelNode>()->getInnerVar() == indexVar;
-//  } else if (rel.getRelType() == PRECOMPUTE) {
-//    return hasExactBound(rel.getNode<PrecomputeRelNode>()->getParentVar());
-//  }
   // TODO: include non-irregular variables
   return false;
 }

src/lower/lowerer_impl_imperative.cpp

@@ -840,6 +840,7 @@ Stmt LowererImplImperative::lowerForall(Forall forall)
 
 Stmt LowererImplImperative::lowerForallCloned(Forall forall) {
   // want to emit guards outside of loop to prevent unstructured loop exits
+
   // construct guard
   // underived or pos variables that have a descendant that has not been defined yet
   vector<IndexVar> varsWithGuard;
@@ -857,6 +858,7 @@ Stmt LowererImplImperative::lowerForallCloned(Forall forall) {
       }
     }
   }
+
   // determine min and max values for vars given already defined variables.
   // we do a recovery where we fill in undefined variables with either 0's or the max of their iteration
   std::map<IndexVar, Expr> minVarValues;
@@ -901,6 +903,7 @@ Stmt LowererImplImperative::lowerForallCloned(Forall forall) {
     minVarValues[var] = provGraph.recoverVariable(var, currentDefinedVarOrder, underivedBounds, minChildValues, iterators);
     maxVarValues[var] = provGraph.recoverVariable(var, currentDefinedVarOrder, underivedBounds, maxChildValues, iterators);
   }
+
   // Build guards
   Expr guardCondition;
   for (auto var : varsWithGuard) {