fix dayu bound ip (#1558)

* fix dayu bound ip

* update

* add changelog

---------

Co-authored-by: mikatong <mikatong@tencent.com>

Author: tongyiming

.changelog/1558.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/tencentcloud_dayu_ddos_ip_attachment_v2: fix delete failed
+```

tencentcloud/resource_tc_dayu_ddos_ip_attachment_v2.go

@@ -188,11 +188,11 @@ func resourceTencentCloudDayuDDosIpAttachmentReadV2(d *schema.ResourceData, meta
 	_ = d.Set("bgp_instance_id", bgpInstanceId)
 	boundIpList := make([]map[string]interface{}, 0)
 	if boundip.EipProductInfos != nil {
-		boundIpListItem := make(map[string]interface{})
 		for _, item := range boundip.EipProductInfos {
 			if _, ok := boundIpMap[*item.Ip]; !ok {
 				continue
 			}
+			boundIpListItem := make(map[string]interface{})
 			boundIpListItem["ip"] = *item.Ip
 			boundIpListItem["biz_type"] = *item.BizType
 			boundIpListItem["instance_id"] = *item.InstanceId
@@ -226,10 +226,11 @@ func resourceTencentCloudDayuDDosIpAttachmentDeleteV2(d *schema.ResourceData, me
 	request.Id = helper.String(bgpInstanceId)
 	ubBoundDevList := make([]*antiddos.BoundIpInfo, 0)
 	for _, boundIp := range strings.Split(boundIps, COMMA_SP) {
+		boundIpValue := boundIp
 		ubBoundDevList = append(
 			ubBoundDevList,
 			&antiddos.BoundIpInfo{
-				Ip: &boundIp,
+				Ip: &boundIpValue,
 			},
 		)
 	}

tencentcloud/resource_tc_dayu_ddos_ip_attachment_v2_test.go

@@ -22,7 +22,7 @@ func TestAccTencentCloudDayuDdosIpAttachmentV2Resource_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckDayuDdosIpAttachmentExists("tencentcloud_dayu_ddos_ip_attachment_v2.boundip"),
 					resource.TestCheckResourceAttrSet("tencentcloud_dayu_ddos_ip_attachment_v2.boundip", "bgp_instance_id"),
-					resource.TestCheckResourceAttr("tencentcloud_dayu_ddos_ip_attachment_v2.boundip", "bound_ip_list.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_dayu_ddos_ip_attachment_v2.boundip", "bound_ip_list.#", "2"),
 				),
 			},
 		},
@@ -115,12 +115,18 @@ func testAccCheckDayuDdosIpAttachmentExists(n string) resource.TestCheckFunc {
 
 const testAccDayuDdosIpAttachment_basic = `
 resource "tencentcloud_dayu_ddos_ip_attachment_v2" "boundip" {
-	bgp_instance_id = "bgp-000001co"
+	bgp_instance_id = "bgp-00000fih"
 	bound_ip_list {
 		ip = "43.136.81.73"
 		biz_type = "public"
 		instance_id = "ins-eukucmzm"
 		device_type = "cvm"
 	}
+	bound_ip_list {
+		ip = "43.139.245.210"
+		biz_type = "public"
+		instance_id = "ins-c6vwi48a"
+		device_type = "cvm"
+	}
   }
 `