fix(cvm): [123456789] add computed private_key (#3353)

* add private key

* add changelog

Author: hellertang

.changelog/3353.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_key_pair: add computed attr `private_key` and `create_time`
+```

tencentcloud/services/cvm/resource_tc_key_pair.go

@@ -66,11 +66,21 @@ func ResourceTencentCloudKeyPair() *schema.Resource {
 				Optional:    true,
 				Description: "Tags of the key pair.",
 			},
+			"private_key": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Content of private key in a key pair. Tencent Cloud do not keep private keys. Please keep it properly.",
+			},
+			"created_time": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Creation time, which follows the `ISO8601` standard and uses `UTC` time in the format of `YYYY-MM-DDThh:mm:ssZ`.",
+			},
 		},
 	}
 }
 
-func cvmCreateKeyPair(ctx context.Context, d *schema.ResourceData, meta interface{}) (keyId string, err error) {
+func cvmCreateKeyPair(ctx context.Context, d *schema.ResourceData, meta interface{}) (keyId, privateKey string, err error) {
 	logId := tccommon.GetLogId(ctx)
 	request := cvm.NewCreateKeyPairRequest()
 	response := cvm.NewCreateKeyPairResponse()
@@ -98,6 +108,9 @@ func cvmCreateKeyPair(ctx context.Context, d *schema.ResourceData, meta interfac
 	}
 
 	keyId = *response.Response.KeyPair.KeyId
+	if response.Response.KeyPair.PrivateKey != nil {
+		privateKey = *response.Response.KeyPair.PrivateKey
+	}
 	return
 }
 
@@ -139,20 +152,24 @@ func resourceTencentCloudKeyPairCreate(d *schema.ResourceData, meta interface{})
 	logId := tccommon.GetLogId(tccommon.ContextNil)
 	ctx := context.WithValue(context.TODO(), tccommon.LogIdKey, logId)
 	var (
-		keyId string
-		err   error
+		keyId, privateKey string
+		err               error
 	)
 
 	if _, ok := d.GetOk("public_key"); ok {
 		keyId, err = cvmCreateKeyPairByImportPublicKey(ctx, d, meta)
 	} else {
-		keyId, err = cvmCreateKeyPair(ctx, d, meta)
+		keyId, privateKey, err = cvmCreateKeyPair(ctx, d, meta)
 	}
 	if err != nil {
 		return err
 	}
 	d.SetId(keyId)
 
+	if privateKey != "" {
+		_ = d.Set("private_key", privateKey)
+	}
+
 	if tags := helper.GetTags(d, "tags"); len(tags) > 0 {
 		tcClient := meta.(tccommon.ProviderMeta).GetAPIV3Conn()
 		tagService := svctag.NewTagService(tcClient)
@@ -204,6 +221,14 @@ func resourceTencentCloudKeyPairRead(d *schema.ResourceData, meta interface{}) e
 		_ = d.Set("public_key", publicKey)
 	}
 
+	if keyPair.PrivateKey != nil {
+		_ = d.Set("private_key", keyPair.PrivateKey)
+	}
+
+	if keyPair.CreatedTime != nil {
+		_ = d.Set("created_time", keyPair.CreatedTime)
+	}
+
 	client := meta.(tccommon.ProviderMeta).GetAPIV3Conn()
 	tagService := svctag.NewTagService(client)
 

tencentcloud/services/cvm/resource_tc_key_pair.md

@@ -4,7 +4,15 @@ Example Usage
 
 ```hcl
 resource "tencentcloud_key_pair" "foo" {
-	key_name   = "terraform_test"
+  key_name = "terraform_test"
+}
+
+output "private_key" {
+  value = tencentcloud_key_pair.foo.private_key
+}
+
+output "create_time" {
+  value = tencentcloud_key_pair.foo.created_time
 }
 
 resource "tencentcloud_key_pair" "foo1" {

website/docs/r/key_pair.html.markdown

@@ -18,6 +18,14 @@ resource "tencentcloud_key_pair" "foo" {
   key_name = "terraform_test"
 }
 
+output "private_key" {
+  value = tencentcloud_key_pair.foo.private_key
+}
+
+output "create_time" {
+  value = tencentcloud_key_pair.foo.created_time
+}
+
 resource "tencentcloud_key_pair" "foo1" {
   key_name   = "terraform_test"
   public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDjd8fTnp7Dcuj4mLaQxf9Zs/ORgUL9fQxRCNKkPgP1paTy1I513maMX126i36Lxxl3+FUB52oVbo/FgwlIfX8hyCnv8MCxqnuSDozf1CD0/wRYHcTWAtgHQHBPCC2nJtod6cVC3kB18KeV4U7zsxmwFeBIxojMOOmcOBuh7+trRw=="
@@ -38,7 +46,8 @@ The following arguments are supported:
 In addition to all arguments above, the following attributes are exported:
 
 * `id` - ID of the resource.
-
+* `created_time` - Creation time, which follows the `ISO8601` standard and uses `UTC` time in the format of `YYYY-MM-DDThh:mm:ssZ`.
+* `private_key` - Content of private key in a key pair. Tencent Cloud do not keep private keys. Please keep it properly.
 
 
 ## Import