Skip to content

Commit f827057

Browse files
authored
Feat/adjust kms e2e (#1951)
* example readjust: tencentcloud_kubernetes_serverless_node_pool * 1.update e2e case name from tke to kubernetes. 2.update cluster_version to computed. 3.update example.
1 parent fe9d6ea commit f827057

File tree

5 files changed

+17
-22
lines changed

5 files changed

+17
-22
lines changed

tencentcloud/provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2319,7 +2319,7 @@ func Provider() *schema.Provider {
23192319
"tencentcloud_kubernetes_node_pool": resourceTencentCloudKubernetesNodePool(),
23202320
"tencentcloud_kubernetes_serverless_node_pool": resourceTkeServerLessNodePool(),
23212321
"tencentcloud_kubernetes_backup_storage_location": resourceTencentCloudTkeBackupStorageLocation(),
2322-
"tencentcloud_kubernetes_encryption_protection": resourceTencentCloudTkeEncryptionProtection(),
2322+
"tencentcloud_kubernetes_encryption_protection": resourceTencentCloudKubernetesEncryptionProtection(),
23232323
"tencentcloud_mysql_backup_policy": resourceTencentCloudMysqlBackupPolicy(),
23242324
"tencentcloud_mysql_account": resourceTencentCloudMysqlAccount(),
23252325
"tencentcloud_mysql_account_privilege": resourceTencentCloudMysqlAccountPrivilege(),

tencentcloud/resource_tc_kubernetes_cluster.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -934,6 +934,7 @@ func resourceTencentCloudTkeCluster() *schema.Resource {
934934
"cluster_version": {
935935
Type: schema.TypeString,
936936
Optional: true,
937+
Computed: true,
937938
Description: "Version of the cluster. Use `tencentcloud_kubernetes_available_cluster_versions` to get the upgradable cluster version.",
938939
},
939940
"upgrade_instances_follow_cluster": {

tencentcloud/resource_tc_kubernetes_encryption_protection.go

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ variable "example_region" {
1111
}
1212
1313
variable "example_cluster_cidr" {
14-
default = "10.31.0.0/16"
14+
default = "10.32.0.0/16"
1515
}
1616
1717
variable "availability_zone" {
@@ -30,13 +30,11 @@ resource "tencentcloud_kubernetes_cluster" "example" {
3030
cluster_name = "tf_example_cluster"
3131
cluster_desc = "a tf example cluster for the kms test"
3232
cluster_max_service_num = 32
33-
cluster_internet = true
34-
cluster_version = "1.24.4"
3533
cluster_deploy_type = "MANAGED_CLUSTER"
3634
}
3735
3836
resource "tencentcloud_kms_key" "example" {
39-
alias = "tf-example-kms-key-ed-%s"
37+
alias = "tf-example-kms-key"
4038
description = "example of kms key instance"
4139
key_usage = "ENCRYPT_DECRYPT"
4240
is_enabled = true
@@ -64,11 +62,11 @@ import (
6462
"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper"
6563
)
6664

67-
func resourceTencentCloudTkeEncryptionProtection() *schema.Resource {
65+
func resourceTencentCloudKubernetesEncryptionProtection() *schema.Resource {
6866
return &schema.Resource{
69-
Create: resourceTencentCloudTkeEncryptionProtectionCreate,
70-
Read: resourceTencentCloudTkeEncryptionProtectionRead,
71-
Delete: resourceTencentCloudTkeEncryptionProtectionDelete,
67+
Create: resourceTencentCloudKubernetesEncryptionProtectionCreate,
68+
Read: resourceTencentCloudKubernetesEncryptionProtectionRead,
69+
Delete: resourceTencentCloudKubernetesEncryptionProtectionDelete,
7270
Schema: map[string]*schema.Schema{
7371
"cluster_id": {
7472
Required: true,
@@ -107,7 +105,7 @@ func resourceTencentCloudTkeEncryptionProtection() *schema.Resource {
107105
}
108106
}
109107

110-
func resourceTencentCloudTkeEncryptionProtectionCreate(d *schema.ResourceData, meta interface{}) error {
108+
func resourceTencentCloudKubernetesEncryptionProtectionCreate(d *schema.ResourceData, meta interface{}) error {
111109
defer logElapsed("resource.tencentcloud_tke_encryption_protection.create")()
112110
defer inconsistentCheck(d, meta)()
113111

@@ -157,10 +155,10 @@ func resourceTencentCloudTkeEncryptionProtectionCreate(d *schema.ResourceData, m
157155
return e
158156
}
159157

160-
return resourceTencentCloudTkeEncryptionProtectionRead(d, meta)
158+
return resourceTencentCloudKubernetesEncryptionProtectionRead(d, meta)
161159
}
162160

163-
func resourceTencentCloudTkeEncryptionProtectionRead(d *schema.ResourceData, meta interface{}) error {
161+
func resourceTencentCloudKubernetesEncryptionProtectionRead(d *schema.ResourceData, meta interface{}) error {
164162
defer logElapsed("resource.tencentcloud_tke_encryption_protection.read")()
165163
defer inconsistentCheck(d, meta)()
166164

@@ -190,7 +188,7 @@ func resourceTencentCloudTkeEncryptionProtectionRead(d *schema.ResourceData, met
190188
return nil
191189
}
192190

193-
func resourceTencentCloudTkeEncryptionProtectionDelete(d *schema.ResourceData, meta interface{}) error {
191+
func resourceTencentCloudKubernetesEncryptionProtectionDelete(d *schema.ResourceData, meta interface{}) error {
194192
defer logElapsed("resource.tencentcloud_tke_encryption_protection.delete")()
195193
defer inconsistentCheck(d, meta)()
196194

tencentcloud/resource_tc_kubernetes_encryption_protection_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
99
)
1010

11-
func TestAccTencentCloudTkeEncryptionProtectionResource_basic(t *testing.T) {
11+
func TestAccTencentCloudKubernetesEncryptionProtectionResource_basic(t *testing.T) {
1212
t.Parallel()
1313
rName := acctest.RandString(10)
1414
resource.Test(t, resource.TestCase{
@@ -21,7 +21,7 @@ func TestAccTencentCloudTkeEncryptionProtectionResource_basic(t *testing.T) {
2121
Config: fmt.Sprintf(testAccTkeEncryptionProtection, rName),
2222
Check: resource.ComposeTestCheckFunc(
2323
resource.TestCheckResourceAttrSet("tencentcloud_kubernetes_encryption_protection.example", "id"),
24-
resource.TestCheckResourceAttr("tencentcloud_kubernetes_encryption_protection.example", "cluster_id", defaultTkeClusterId),
24+
resource.TestCheckResourceAttrSet("tencentcloud_kubernetes_encryption_protection.example", "cluster_id"),
2525
resource.TestCheckResourceAttrSet("tencentcloud_kubernetes_encryption_protection.example", "kms_configuration.#"),
2626
resource.TestCheckResourceAttrSet("tencentcloud_kubernetes_encryption_protection.example", "kms_configuration.0.key_id"),
2727
resource.TestCheckResourceAttr("tencentcloud_kubernetes_encryption_protection.example", "kms_configuration.0.kms_region", "ap-guangzhou"),
@@ -39,7 +39,7 @@ variable "example_region" {
3939
}
4040
4141
variable "example_cluster_cidr" {
42-
default = "10.31.0.0/16"
42+
default = "10.32.0.0/16"
4343
}
4444
4545
variable "availability_zone" {
@@ -58,8 +58,6 @@ resource "tencentcloud_kubernetes_cluster" "example" {
5858
cluster_name = "tf_example_cluster"
5959
cluster_desc = "a tf example cluster for the kms test"
6060
cluster_max_service_num = 32
61-
cluster_internet = true
62-
cluster_version = "1.24.4"
6361
cluster_deploy_type = "MANAGED_CLUSTER"
6462
}
6563

website/docs/r/kubernetes_encryption_protection.html.markdown

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ variable "example_region" {
2121
}
2222
2323
variable "example_cluster_cidr" {
24-
default = "10.31.0.0/16"
24+
default = "10.32.0.0/16"
2525
}
2626
2727
variable "availability_zone" {
@@ -40,13 +40,11 @@ resource "tencentcloud_kubernetes_cluster" "example" {
4040
cluster_name = "tf_example_cluster"
4141
cluster_desc = "a tf example cluster for the kms test"
4242
cluster_max_service_num = 32
43-
cluster_internet = true
44-
cluster_version = "1.24.4"
4543
cluster_deploy_type = "MANAGED_CLUSTER"
4644
}
4745
4846
resource "tencentcloud_kms_key" "example" {
49-
alias = "tf-example-kms-key-ed-%s"
47+
alias = "tf-example-kms-key"
5048
description = "example of kms key instance"
5149
key_usage = "ENCRYPT_DECRYPT"
5250
is_enabled = true

0 commit comments

Comments
 (0)