Merge pull request #1686 from tencentcloudstack/feat/ckafka_topic_support_modify_topic

topic suppport replica_num

Author: lyu571

.changelog/1686.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_ckafka_topic: support update `replica_num`
+```

tencentcloud/resource_tc_ckafka_topic.go

@@ -253,8 +253,7 @@ func resourceTencentCloudCkafkaTopicRead(d *schema.ResourceData, meta interface{
 	}
 	items := strings.Split(d.Id(), FILED_SP)
 	if len(items) < 2 {
-		d.SetId("")
-		return nil
+		return fmt.Errorf("id is broken,%s", d.Id())
 	}
 	instanceId := items[0]
 	topicName := items[1]
@@ -314,9 +313,16 @@ func resourceTencentCloudCkafkaTopicUpdate(d *schema.ResourceData, meta interfac
 	ckafkcService := CkafkaService{
 		client: meta.(*TencentCloudClient).apiV3Conn,
 	}
+
+	items := strings.Split(d.Id(), FILED_SP)
+	if len(items) < 2 {
+		return fmt.Errorf("id is broken,%s", d.Id())
+	}
+	instanceId := items[0]
+	topicName := items[1]
+
 	request := ckafka.NewModifyTopicAttributesRequest()
-	instanceId := d.Get("instance_id").(string)
-	topicName := d.Get("topic_name").(string)
+	replicaNum := d.Get("replica_num").(int)
 	whiteListSwitch := d.Get("enable_white_list").(bool)
 	cleanUpPolicy := d.Get("clean_up_policy").(string)
 	retention := d.Get("retention").(int)
@@ -332,6 +338,7 @@ func resourceTencentCloudCkafkaTopicUpdate(d *schema.ResourceData, meta interfac
 	}
 	request.InstanceId = &instanceId
 	request.TopicName = &topicName
+	request.ReplicaNum = helper.IntInt64(replicaNum)
 	request.EnableWhiteList = helper.BoolToInt64Ptr(whiteListSwitch)
 	request.MinInsyncReplicas = helper.IntInt64(d.Get("sync_replica_min_num").(int))
 	request.UncleanLeaderElectionEnable = helper.BoolToInt64Ptr(d.Get("unclean_leader_election_enable").(bool))
@@ -393,8 +400,12 @@ func resourceTencentCLoudCkafkaTopicDelete(d *schema.ResourceData, meta interfac
 	ckafkcService := CkafkaService{
 		client: meta.(*TencentCloudClient).apiV3Conn,
 	}
-	instanceId := d.Get("instance_id").(string)
-	topicName := d.Get("topic_name").(string)
+	items := strings.Split(d.Id(), FILED_SP)
+	if len(items) < 2 {
+		return fmt.Errorf("id is broken,%s", d.Id())
+	}
+	instanceId := items[0]
+	topicName := items[1]
 
 	err := ckafkcService.DeleteCkafkaTopic(ctx, instanceId, topicName)
 	if err != nil {

tencentcloud/resource_tc_ckafka_topic_test.go

@@ -57,7 +57,7 @@ func init() {
 	})
 }
 
-func TestAccTencentCloudCkafkaTopicResource(t *testing.T) {
+func TestAccTencentCloudCkafkaTopicResource_Basic(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheckCommon(t, ACCOUNT_TYPE_PREPAY) },
@@ -89,7 +89,8 @@ func TestAccTencentCloudCkafkaTopicResource(t *testing.T) {
 					testAccCheckKafkaTopicInstanceExists("tencentcloud_ckafka_topic.kafka_topic"),
 					resource.TestCheckResourceAttrSet("tencentcloud_ckafka_topic.kafka_topic", "instance_id"),
 					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "note", "this is test topic_update"),
-					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "partition_num", "2"),
+					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "replica_num", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "partition_num", "3"),
 					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "enable_white_list", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "clean_up_policy", "compact"),
 					resource.TestCheckResourceAttr("tencentcloud_ckafka_topic.kafka_topic", "sync_replica_min_num", "2"),
@@ -195,8 +196,8 @@ resource "tencentcloud_ckafka_topic" "kafka_topic" {
 	instance_id                         = var.instance_id
 	topic_name                          = "ckafka-topic-tf-test"
 	note                                = "this is test topic_update"
-	replica_num                         = 2
-	partition_num                       = 2
+	replica_num                         = 1
+	partition_num                       = 3
 	enable_white_list                   = true
 	ip_white_list                       = ["192.168.1.2"]
 	clean_up_policy                     = "compact"