Feat/cdwch datasource support (#2382)

* add cdwch datasource

* update antiddos datasource back param

* add changelog 2382.txt

Author: bruceybian

.changelog/2382.txt

@@ -0,0 +1,7 @@
+```release-note:new-data-source
+tencentcloud_clickhouse_spec
+```
+
+```release-note:new-data-source
+tencentcloud_clickhouse_instance_shards
+```

tencentcloud/cdwch/data_source_tc_clickhouse_instance_shards.md

@@ -0,0 +1,9 @@
+Use this data source to query detailed information of clickhouse instance_shards
+
+Example Usage
+
+```hcl
+data "tencentcloud_clickhouse_instance_shards" "instance_shards" {
+  instance_id = "cdwch-datuhk3z"
+}
+```

tencentcloud/cdwch/data_source_tc_clickhouse_spec.md

@@ -0,0 +1,11 @@
+Use this data source to query detailed information of clickhouse spec
+
+Example Usage
+
+```hcl
+data "tencentcloud_clickhouse_spec" "spec" {
+  zone       = "ap-guangzhou-7"
+  pay_mode   = "PREPAID"
+  is_elastic = false
+}
+```

tencentcloud/data_source_tc_antiddos_basic_device_status.go

@@ -127,31 +127,39 @@ func dataSourceTencentCloudAntiddosBasicDeviceStatusRead(d *schema.ResourceData,
 	tmpList := make([]map[string]interface{}, 0)
 
 	if basicDeviceStatus.Data != nil {
-		for _, keyValue := range basicDeviceStatus.Data {
+		data := basicDeviceStatus.Data
+		dataTmpList := make([]map[string]interface{}, 0, len(data))
+
+		for _, keyValue := range data {
 			keyValueMap := map[string]interface{}{}
 			if keyValue.Key != nil {
 				keyValueMap["key"] = keyValue.Key
 			}
 			if keyValue.Value != nil {
 				keyValueMap["value"] = keyValue.Value
 			}
-			tmpList = append(tmpList, keyValueMap)
+			dataTmpList = append(dataTmpList, keyValueMap)
 		}
-		_ = d.Set("data", tmpList)
+		tmpList = append(tmpList, dataTmpList...)
+		_ = d.Set("data", dataTmpList)
 	}
 
 	if basicDeviceStatus.CLBData != nil {
-		for _, keyValue := range basicDeviceStatus.CLBData {
+		clbData := basicDeviceStatus.CLBData
+		clbDataTmpList := make([]map[string]interface{}, 0, len(clbData))
+
+		for _, keyValue := range clbData {
 			keyValueMap := map[string]interface{}{}
 			if keyValue.Key != nil {
 				keyValueMap["key"] = keyValue.Key
 			}
 			if keyValue.Value != nil {
 				keyValueMap["value"] = keyValue.Value
 			}
-			tmpList = append(tmpList, keyValueMap)
+			clbDataTmpList = append(clbDataTmpList, keyValueMap)
 		}
-		_ = d.Set("clb_data", tmpList)
+		tmpList = append(tmpList, clbDataTmpList...)
+		_ = d.Set("clb_data", clbDataTmpList)
 	}
 
 	d.SetId(helper.BuildToken())

tencentcloud/data_source_tc_antiddos_list_listener.go

@@ -276,7 +276,10 @@ func dataSourceTencentCloudAntiddosListListenerRead(d *schema.ResourceData, meta
 	tmpList := make([]map[string]interface{}, 0)
 
 	if listListener.Layer4Listeners != nil {
-		for _, layer4Rule := range listListener.Layer4Listeners {
+		layer4Listeners := listListener.Layer4Listeners
+		layer4ListenersTmpList := make([]map[string]interface{}, 0, len(layer4Listeners))
+
+		for _, layer4Rule := range layer4Listeners {
 			layer4RuleMap := map[string]interface{}{}
 
 			if layer4Rule.BackendPort != nil {
@@ -360,14 +363,17 @@ func dataSourceTencentCloudAntiddosListListenerRead(d *schema.ResourceData, meta
 				layer4RuleMap["instance_detail_rule"] = instanceDetailRuleList
 			}
 
-			tmpList = append(tmpList, layer4RuleMap)
+			layer4ListenersTmpList = append(layer4ListenersTmpList, layer4RuleMap)
 		}
-
-		_ = d.Set("layer4_listeners", tmpList)
+		tmpList = append(tmpList, layer4ListenersTmpList...)
+		_ = d.Set("layer4_listeners", layer4ListenersTmpList)
 	}
 
 	if listListener.Layer7Listeners != nil {
-		for _, layer7Rule := range listListener.Layer7Listeners {
+		layer7Listeners := listListener.Layer7Listeners
+		layer7ListenersTmpList := make([]map[string]interface{}, 0, len(layer7Listeners))
+
+		for _, layer7Rule := range layer7Listeners {
 			layer7RuleMap := map[string]interface{}{}
 
 			if layer7Rule.Domain != nil {
@@ -470,10 +476,10 @@ func dataSourceTencentCloudAntiddosListListenerRead(d *schema.ResourceData, meta
 				layer7RuleMap["vport"] = layer7Rule.Vport
 			}
 
-			tmpList = append(tmpList, layer7RuleMap)
+			layer7ListenersTmpList = append(layer7ListenersTmpList, layer7RuleMap)
 		}
-
-		_ = d.Set("layer7_listeners", tmpList)
+		tmpList = append(tmpList, layer7ListenersTmpList...)
+		_ = d.Set("layer7_listeners", layer7ListenersTmpList)
 	}
 
 	d.SetId(helper.BuildToken())

tencentcloud/data_source_tc_clickhouse_instance_shards.go

@@ -0,0 +1,78 @@
+package tencentcloud
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	cdwch "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/cdwch/v20200915"
+	"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper"
+)
+
+func dataSourceTencentCloudClickhouseInstanceShards() *schema.Resource {
+	return &schema.Resource{
+		Read: dataSourceTencentCloudClickhouseInstanceShardsRead,
+		Schema: map[string]*schema.Schema{
+			"instance_id": {
+				Required:    true,
+				Type:        schema.TypeString,
+				Description: "Cluster instance ID.",
+			},
+
+			"instance_shards_list": {
+				Computed:    true,
+				Type:        schema.TypeString,
+				Description: "Instance shard information.",
+			},
+
+			"result_output_file": {
+				Type:        schema.TypeString,
+				Optional:    true,
+				Description: "Used to save results.",
+			},
+		},
+	}
+}
+
+func dataSourceTencentCloudClickhouseInstanceShardsRead(d *schema.ResourceData, meta interface{}) error {
+	defer logElapsed("data_source.tencentcloud_clickhouse_instance_shards.read")()
+	defer inconsistentCheck(d, meta)()
+
+	logId := getLogId(contextNil)
+
+	ctx := context.WithValue(context.TODO(), logIdKey, logId)
+
+	paramMap := make(map[string]interface{})
+	if v, ok := d.GetOk("instance_id"); ok {
+		paramMap["InstanceId"] = helper.String(v.(string))
+	}
+
+	service := CdwchService{client: meta.(*TencentCloudClient).apiV3Conn}
+
+	var instanceShards *cdwch.DescribeInstanceShardsResponseParams
+	err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
+		result, e := service.DescribeClickhouseInstanceShardsByFilter(ctx, paramMap)
+		if e != nil {
+			return retryError(e)
+		}
+		instanceShards = result
+		return nil
+	})
+	if err != nil {
+		return err
+	}
+
+	if instanceShards.InstanceShardsList != nil {
+		_ = d.Set("instance_shards_list", instanceShards.InstanceShardsList)
+	}
+
+	d.SetId(helper.BuildToken())
+
+	output, ok := d.GetOk("result_output_file")
+	if ok && output.(string) != "" {
+		if e := writeToFile(output.(string), d); e != nil {
+			return e
+		}
+	}
+	return nil
+}

tencentcloud/data_source_tc_clickhouse_instance_shards_test.go

@@ -0,0 +1,29 @@
+package tencentcloud
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccTencentCloudClickhouseInstanceShardsDataSource_basic(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			testAccPreCheckCommon(t, ACCOUNT_TYPE_PREPAY)
+		},
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccClickhouseInstanceShardsDataSource,
+				Check:  resource.ComposeTestCheckFunc(testAccCheckTencentCloudDataSourceID("data.tencentcloud_clickhouse_instance_shards.instance_shards")),
+			},
+		},
+	})
+}
+
+const testAccClickhouseInstanceShardsDataSource = `
+data "tencentcloud_clickhouse_instance_shards" "instance_shards" {
+  instance_id = "cdwch-datuhk3z"
+}
+`