fix: as support host_name (#2052)

* fix: as support host_name

* feat: add changelog

* fix: modify changelog

* fix: fmt

Author: gitmkn

.changelog/2052.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_as_scaling_config: Support field `host_name`
+```

tencentcloud/resource_tc_as_scaling_config.go

@@ -32,6 +32,11 @@ resource "tencentcloud_as_scaling_config" "example" {
   enhanced_monitor_service   = false
   user_data                  = "dGVzdA=="
 
+  host_name_settings {
+	host_name       = "host-name-test"
+	host_name_style = "UNIQUE"
+  }
+
   instance_tags = {
     tag = "example"
   }
@@ -61,7 +66,7 @@ Import
 AutoScaling Configuration can be imported using the id, e.g.
 
 ```
-$ terraform import tencentcloud_as_scaling_config.scaling_config asc-n32ymck2
+$ terraform import tencentcloud_as_scaling_config.example asc-n32ymck2
 ```
 */
 package tencentcloud
@@ -270,6 +275,26 @@ func resourceTencentCloudAsScalingConfig() *schema.Resource {
 				Optional:    true,
 				Description: "CAM role name authorized to access.",
 			},
+			"host_name_settings": {
+				Type:        schema.TypeList,
+				Optional:    true,
+				MaxItems:    1,
+				Description: "Related settings of the cloud server hostname (HostName).",
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"host_name": {
+							Type:        schema.TypeString,
+							Required:    true,
+							Description: "The host name of the cloud server; dots (.) and dashes (-) cannot be used as the first and last characters of HostName, and cannot be used consecutively; Windows instances are not supported; other types (Linux, etc.) instances: the character length is [2, 40], it is allowed to support multiple dots, and there is a paragraph between the dots, and each paragraph is allowed to consist of letters (no uppercase and lowercase restrictions), numbers and dashes (-). Pure numbers are not allowed.",
+						},
+						"host_name_style": {
+							Type:        schema.TypeString,
+							Optional:    true,
+							Description: "The style of the host name of the cloud server, the value range includes `ORIGINAL` and `UNIQUE`, the default is `ORIGINAL`; `ORIGINAL`, the AS directly passes the HostName filled in the input parameter to the CVM, and the CVM may append a sequence to the HostName number, the HostName of the instance in the scaling group will conflict; `UNIQUE`, the HostName filled in as a parameter is equivalent to the host name prefix, AS and CVM will expand it, and the HostName of the instance in the scaling group can be guaranteed to be unique.",
+						},
+					},
+				},
+			},
 			"instance_name_settings": {
 				Type:        schema.TypeList,
 				Optional:    true,
@@ -472,6 +497,22 @@ func resourceTencentCloudAsScalingConfigCreate(d *schema.ResourceData, meta inte
 		request.CamRoleName = helper.String(v.(string))
 	}
 
+	if v, ok := d.GetOk("host_name_settings"); ok {
+		settings := make([]*as.HostNameSettings, 0, 10)
+		for _, item := range v.([]interface{}) {
+			dMap := item.(map[string]interface{})
+			settingsInfo := as.HostNameSettings{}
+			if hostName, ok := dMap["host_name"]; ok {
+				settingsInfo.HostName = helper.String(hostName.(string))
+			}
+			if hostNameStyle, ok := dMap["host_name_style"]; ok {
+				settingsInfo.HostNameStyle = helper.String(hostNameStyle.(string))
+			}
+			settings = append(settings, &settingsInfo)
+		}
+		request.HostNameSettings = settings[0]
+	}
+
 	if v, ok := d.GetOk("instance_name_settings"); ok {
 		settings := make([]*as.InstanceNameSettings, 0, 10)
 		for _, item := range v.([]interface{}) {
@@ -544,6 +585,18 @@ func resourceTencentCloudAsScalingConfigRead(d *schema.ResourceData, meta interf
 		_ = d.Set("disk_type_policy", *config.DiskTypePolicy)
 
 		_ = d.Set("cam_role_name", *config.CamRoleName)
+
+		if config.HostNameSettings != nil {
+			settings := map[string]interface{}{}
+			if config.HostNameSettings.HostName != nil {
+				settings["host_name"] = config.HostNameSettings.HostName
+			}
+			if config.HostNameSettings.HostNameStyle != nil {
+				settings["host_name_style"] = config.HostNameSettings.HostNameStyle
+			}
+			_ = d.Set("host_name_settings", []interface{}{settings})
+		}
+
 		if config.InstanceNameSettings != nil {
 			settings := make([]map[string]interface{}, 0)
 			setting := map[string]interface{}{
@@ -751,6 +804,22 @@ func resourceTencentCloudAsScalingConfigUpdate(d *schema.ResourceData, meta inte
 		request.CamRoleName = helper.String(v.(string))
 	}
 
+	if v, ok := d.GetOk("host_name_settings"); ok {
+		settings := make([]*as.HostNameSettings, 0, 10)
+		for _, item := range v.([]interface{}) {
+			dMap := item.(map[string]interface{})
+			settingsInfo := as.HostNameSettings{}
+			if hostName, ok := dMap["host_name"]; ok {
+				settingsInfo.HostName = helper.String(hostName.(string))
+			}
+			if hostNameStyle, ok := dMap["host_name_style"]; ok {
+				settingsInfo.HostNameStyle = helper.String(hostNameStyle.(string))
+			}
+			settings = append(settings, &settingsInfo)
+		}
+		request.HostNameSettings = settings[0]
+	}
+
 	if v, ok := d.GetOk("instance_name_settings"); ok {
 		settings := make([]*as.InstanceNameSettings, 0, 10)
 		for _, item := range v.([]interface{}) {

tencentcloud/resource_tc_as_scaling_config_test.go

@@ -107,6 +107,9 @@ func TestAccTencentCloudAsScalingConfig_full(t *testing.T) {
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "public_ip_assigned", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "enhanced_security_service", "false"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "enhanced_monitor_service", "false"),
+					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "host_name_settings.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "host_name_settings.0.host_name", "host-name"),
+					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "host_name_settings.0.host_name_style", "ORIGINAL"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "user_data", "test"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "instance_tags.tag", "as"),
 				),
@@ -129,6 +132,9 @@ func TestAccTencentCloudAsScalingConfig_full(t *testing.T) {
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "enhanced_security_service", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "enhanced_monitor_service", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "user_data", "dGVzdA=="),
+					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "host_name_settings.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "host_name_settings.0.host_name", "host-name-test"),
+					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "host_name_settings.0.host_name_style", "UNIQUE"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "instance_tags.tag", "as"),
 					resource.TestCheckResourceAttr("tencentcloud_as_scaling_config.launch_configuration", "instance_tags.test", "update"),
 				),
@@ -252,6 +258,11 @@ resource "tencentcloud_as_scaling_config" "launch_configuration" {
   enhanced_security_service  = false
   enhanced_monitor_service   = false
   user_data                  = "test"
+
+  host_name_settings {
+	host_name       = "host-name"
+	host_name_style = "ORIGINAL"
+  }
   
   instance_tags = {
     tag = "as"
@@ -283,6 +294,11 @@ resource "tencentcloud_as_scaling_config" "launch_configuration" {
   enhanced_security_service  = true
   enhanced_monitor_service   = true
   user_data                  = "dGVzdA=="
+
+  host_name_settings {
+	host_name       = "host-name-test"
+	host_name_style = "UNIQUE"
+  }
   
   instance_tags = {
     tag  = "as"

website/docs/r/as_scaling_config.html.markdown

@@ -42,6 +42,11 @@ resource "tencentcloud_as_scaling_config" "example" {
   enhanced_monitor_service   = false
   user_data                  = "dGVzdA=="
 
+  host_name_settings {
+    host_name       = "host-name-test"
+    host_name_style = "UNIQUE"
+  }
+
   instance_tags = {
     tag = "example"
   }
@@ -78,6 +83,7 @@ The following arguments are supported:
 * `disk_type_policy` - (Optional, String) Policy of cloud disk type. Valid values: `ORIGINAL` and `AUTOMATIC`. Default is `ORIGINAL`.
 * `enhanced_monitor_service` - (Optional, Bool) To specify whether to enable cloud monitor service. Default is `TRUE`.
 * `enhanced_security_service` - (Optional, Bool) To specify whether to enable cloud security service. Default is `TRUE`.
+* `host_name_settings` - (Optional, List) Related settings of the cloud server hostname (HostName).
 * `instance_charge_type_prepaid_period` - (Optional, Int) The tenancy (in month) of the prepaid instance, NOTE: it only works when instance_charge_type is set to `PREPAID`. Valid values are `1`, `2`, `3`, `4`, `5`, `6`, `7`, `8`, `9`, `10`, `11`, `12`, `24`, `36`.
 * `instance_charge_type_prepaid_renew_flag` - (Optional, String) Auto renewal flag. Valid values: `NOTIFY_AND_AUTO_RENEW`: notify upon expiration and renew automatically, `NOTIFY_AND_MANUAL_RENEW`: notify upon expiration but do not renew automatically, `DISABLE_NOTIFY_AND_MANUAL_RENEW`: neither notify upon expiration nor renew automatically. Default value: `NOTIFY_AND_MANUAL_RENEW`. If this parameter is specified as `NOTIFY_AND_AUTO_RENEW`, the instance will be automatically renewed on a monthly basis if the account balance is sufficient. NOTE: it only works when instance_charge_type is set to `PREPAID`.
 * `instance_charge_type` - (Optional, String) Charge type of instance. Valid values are `PREPAID`, `POSTPAID_BY_HOUR`, `SPOTPAID`. The default is `POSTPAID_BY_HOUR`. NOTE: `SPOTPAID` instance must set `spot_instance_type` and `spot_max_price` at the same time.
@@ -104,6 +110,11 @@ The `data_disk` object supports the following:
 * `disk_type` - (Optional, String) Types of disk. Valid values: `CLOUD_PREMIUM` and `CLOUD_SSD`. valid when disk_type_policy is ORIGINAL.
 * `snapshot_id` - (Optional, String) Data disk snapshot ID.
 
+The `host_name_settings` object supports the following:
+
+* `host_name` - (Required, String) The host name of the cloud server; dots (.) and dashes (-) cannot be used as the first and last characters of HostName, and cannot be used consecutively; Windows instances are not supported; other types (Linux, etc.) instances: the character length is [2, 40], it is allowed to support multiple dots, and there is a paragraph between the dots, and each paragraph is allowed to consist of letters (no uppercase and lowercase restrictions), numbers and dashes (-). Pure numbers are not allowed.
+* `host_name_style` - (Optional, String) The style of the host name of the cloud server, the value range includes `ORIGINAL` and `UNIQUE`, the default is `ORIGINAL`; `ORIGINAL`, the AS directly passes the HostName filled in the input parameter to the CVM, and the CVM may append a sequence to the HostName number, the HostName of the instance in the scaling group will conflict; `UNIQUE`, the HostName filled in as a parameter is equivalent to the host name prefix, AS and CVM will expand it, and the HostName of the instance in the scaling group can be guaranteed to be unique.
+
 The `instance_name_settings` object supports the following:
 
 * `instance_name` - (Required, String) CVM instance name.
@@ -123,6 +134,6 @@ In addition to all arguments above, the following attributes are exported:
 AutoScaling Configuration can be imported using the id, e.g.
 
 ```
-$ terraform import tencentcloud_as_scaling_config.scaling_config asc-n32ymck2
+$ terraform import tencentcloud_as_scaling_config.example asc-n32ymck2
 ```