Merge pull request #1682 from tencentcloudstack/feat/cvm_support_diable_api

cvm support set disable_api_termination

Author: lyu571

.changelog/1682.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_instance: support set `disable_api_termination`
+```

tencentcloud/resource_tc_instance.go

@@ -494,6 +494,12 @@ func resourceTencentCloudInstance() *schema.Resource {
 				Default:     false,
 				Description: "Indicate whether to force delete the instance. Default is `false`. If set true, the instance will be permanently deleted instead of being moved into the recycle bin. Note: only works for `PREPAID` instance.",
 			},
+			"disable_api_termination": {
+				Type:        schema.TypeBool,
+				Optional:    true,
+				Default:     false,
+				Description: "Whether the termination protection is enabled. Default is `false`. If set true, which means that this instance can not be deleted by an API action.",
+			},
 			// role
 			"cam_role_name": {
 				Type:        schema.TypeString,
@@ -739,6 +745,10 @@ func resourceTencentCloudInstanceCreate(d *schema.ResourceData, meta interface{}
 		request.UserData = &userData
 	}
 
+	if v, ok := d.GetOkExists("disable_api_termination"); ok {
+		request.DisableApiTermination = helper.Bool(v.(bool))
+	}
+
 	if v := helper.GetTags(d, "tags"); len(v) > 0 {
 		tags := make([]*cvm.Tag, 0)
 		for tagKey, tagValue := range v {
@@ -958,6 +968,7 @@ func resourceTencentCloudInstanceRead(d *schema.ResourceData, meta interface{})
 	_ = d.Set("create_time", instance.CreatedTime)
 	_ = d.Set("expired_time", instance.ExpiredTime)
 	_ = d.Set("cam_role_name", instance.CamRoleName)
+	_ = d.Set("disable_api_termination", instance.DisableApiTermination)
 
 	if *instance.InstanceChargeType == CVM_CHARGE_TYPE_CDHPAID {
 		_ = d.Set("cdh_instance_type", instance.InstanceType)
@@ -1162,6 +1173,13 @@ func resourceTencentCloudInstanceUpdate(d *schema.ResourceData, meta interface{}
 		d.SetPartial("instance_name")
 	}
 
+	if d.HasChange("disable_api_termination") {
+		err := cvmService.ModifyDisableApiTermination(ctx, instanceId, d.Get("disable_api_termination").(bool))
+		if err != nil {
+			return err
+		}
+	}
+
 	if d.HasChange("security_groups") {
 		securityGroups := d.Get("security_groups").(*schema.Set).List()
 		securityGroupIds := make([]*string, 0, len(securityGroups))

tencentcloud/resource_tc_instance_test.go

@@ -297,6 +297,7 @@ func TestAccTencentCloudInstanceResource_WithImageLogin(t *testing.T) {
 					testAccCheckTencentCloudInstanceExists(id),
 					resource.TestCheckResourceAttr(id, "instance_status", "RUNNING"),
 					resource.TestCheckResourceAttr(id, "keep_image_login", "true"),
+					resource.TestCheckResourceAttr(id, "disable_api_termination", "false"),
 				),
 			},
 		},
@@ -996,6 +997,7 @@ resource "tencentcloud_instance" "foo" {
   instance_type              = data.tencentcloud_instance_types.default.instance_types.0.instance_type
   keep_image_login 			 = true
   system_disk_type           = "CLOUD_PREMIUM"
+  disable_api_termination    = false
 }
 `
 

tencentcloud/service_tencentcloud_cvm.go

@@ -246,6 +246,25 @@ func (me *CvmService) ModifySecurityGroups(ctx context.Context, instanceId strin
 	return nil
 }
 
+func (me *CvmService) ModifyDisableApiTermination(ctx context.Context, instanceId string, disableApiTermination bool) error {
+	logId := getLogId(ctx)
+	request := cvm.NewModifyInstancesAttributeRequest()
+	request.InstanceIds = []*string{&instanceId}
+	request.DisableApiTermination = &disableApiTermination
+
+	ratelimit.Check(request.GetAction())
+	response, err := me.client.UseCvmClient().ModifyInstancesAttribute(request)
+	if err != nil {
+		log.Printf("[CRITAL]%s api[%s] fail, request body [%s], reason[%s]\n",
+			logId, request.GetAction(), request.ToJsonString(), err.Error())
+		return err
+	}
+	log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n",
+		logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
+
+	return nil
+}
+
 func (me *CvmService) ModifyProjectId(ctx context.Context, instanceId string, projectId int64) error {
 	logId := getLogId(ctx)
 	request := cvm.NewModifyInstancesProjectRequest()

website/docs/r/instance.html.markdown

@@ -147,6 +147,7 @@ The following arguments are supported:
 * `cdh_host_id` - (Optional, String, ForceNew) Id of cdh instance. Note: it only works when instance_charge_type is set to `CDHPAID`.
 * `cdh_instance_type` - (Optional, String) Type of instance created on cdh, the value of this parameter is in the format of CDH_XCXG based on the number of CPU cores and memory capacity. Note: it only works when instance_charge_type is set to `CDHPAID`.
 * `data_disks` - (Optional, List, ForceNew) Settings for data disks.
+* `disable_api_termination` - (Optional, Bool) Whether the termination protection is enabled. Default is `false`. If set true, which means that this instance can not be deleted by an API action.
 * `disable_monitor_service` - (Optional, Bool) Disable enhance service for monitor, it is enabled by default. When this options is set, monitor agent won't be installed. Modifying will cause the instance reset.
 * `disable_security_service` - (Optional, Bool) Disable enhance service for security, it is enabled by default. When this options is set, security agent won't be installed. Modifying will cause the instance reset.
 * `force_delete` - (Optional, Bool) Indicate whether to force delete the instance. Default is `false`. If set true, the instance will be permanently deleted instead of being moved into the recycle bin. Note: only works for `PREPAID` instance.