feat(tke): [116471075]optimize cluster instance queries (#2560)

* optimize cluster instance queries

* add changelog 2560.txt

Author: bruceybian

.changelog/2560.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+datasource/tencentcloud_kubernetes_cluster_instances: optimize cluster instance queries
+```

tencentcloud/services/tke/data_source_tc_kubernetes_cluster_instances_test.go

@@ -21,7 +21,7 @@ func TestAccTencentCloudKubernetesClusterInstancesDataSource_basic(t *testing.T)
 				Check: resource.ComposeTestCheckFunc(
 					tcacctest.AccCheckTencentCloudDataSourceID("data.tencentcloud_kubernetes_cluster_instances.cluster_instances"),
 					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.#", "1"),
-					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.0.instance_id", "ins-kqmx8dm2"),
+					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.0.instance_id", "ins-1fb82v28"),
 					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.0.instance_role", "WORKER"),
 					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.0.instance_state", "running"),
 				),
@@ -30,7 +30,7 @@ func TestAccTencentCloudKubernetesClusterInstancesDataSource_basic(t *testing.T)
 				Config: testAccKubernetesClusterInstancesDataSourceFilter,
 				Check: resource.ComposeTestCheckFunc(
 					tcacctest.AccCheckTencentCloudDataSourceID("data.tencentcloud_kubernetes_cluster_instances.cluster_instances"),
-					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.#", "0"),
+					resource.TestCheckResourceAttr("data.tencentcloud_kubernetes_cluster_instances.cluster_instances", "instance_set.#", "1"),
 				),
 			},
 		},
@@ -39,20 +39,20 @@ func TestAccTencentCloudKubernetesClusterInstancesDataSource_basic(t *testing.T)
 
 const testAccKubernetesClusterInstancesDataSource = `
 data "tencentcloud_kubernetes_cluster_instances" "cluster_instances" {
-  cluster_id    = "cls-ely08ic4"
-  instance_ids  = ["ins-kqmx8dm2"]
+  cluster_id    = "cls-6l3thsra"
+  instance_ids  = ["ins-1fb82v28"]
   instance_role = "WORKER"
 }
 `
 
 const testAccKubernetesClusterInstancesDataSourceFilter = `
 data "tencentcloud_kubernetes_cluster_instances" "cluster_instances" {
-  cluster_id    = "cls-ely08ic4"
-  instance_ids  = ["ins-kqmx8dm2"]
+  cluster_id    = "cls-6l3thsra"
+  instance_ids  = ["ins-qzkwjklk"]
   instance_role = "WORKER"
   filters {
     name   = "nodepool-id"
-    values = ["np-p4e6whqu"]
+    values = ["np-qrez0ayk"]
   }
 }
 `

tencentcloud/services/tke/service_tencentcloud_tke.go

@@ -2716,20 +2716,38 @@ func (me *TkeService) DescribeKubernetesClusterInstancesByFilter(ctx context.Con
 		}
 	}
 
-	ratelimit.Check(request.GetAction())
+	var offset int64 = 0
+	var limit int64 = 20
+	var total int64 = -1
 
-	response, err := me.client.UseTkeClient().DescribeClusterInstances(request)
-	if err != nil {
-		errRet = err
-		return
-	}
-	log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
+	for {
+		if total >= 0 && offset >= total {
+			break
+		}
+		request.Offset = &offset
+		request.Limit = &limit
+		ratelimit.Check(request.GetAction())
 
-	if len(response.Response.InstanceSet) < 1 {
-		return
-	}
+		response, err := me.client.UseTkeClient().DescribeClusterInstances(request)
+		if err != nil {
+			errRet = err
+			return
+		}
+		log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
+
+		if total < 0 {
+			total = int64(*response.Response.TotalCount)
+		}
 
-	clusterInstances = response.Response.InstanceSet
+		if len(response.Response.InstanceSet) == 0 {
+			// get empty set, we're done
+			break
+		}
+
+		offset += limit
+
+		clusterInstances = append(clusterInstances, response.Response.InstanceSet...)
+	}
 	return
 }