Merge pull request #1649 from tencentcloudstack/feat/vpngw_support_change_prepaid_period

vpnngw support update prepaid period

Author: tongyiming

.changelog/1649.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_vpn_gateway: support update `prepaid_period`
+```

tencentcloud/resource_tc_vpn_gateway.go

@@ -120,7 +120,7 @@ func resourceTencentCloudVpnGateway() *schema.Resource {
 				Optional:     true,
 				Default:      1,
 				ValidateFunc: validateAllowedIntValue([]int{1, 2, 3, 4, 6, 7, 8, 9, 12, 24, 36}),
-				Description:  "Period of instance to be prepaid. Valid value: `1`, `2`, `3`, `4`, `6`, `7`, `8`, `9`, `12`, `24`, `36`. The unit is month. Caution: when this para and renew_flag para are valid, the request means to renew several months more pre-paid period. This para can only be set to take effect in create operation.",
+				Description:  "Period of instance to be prepaid. Valid value: `1`, `2`, `3`, `4`, `6`, `7`, `8`, `9`, `12`, `24`, `36`. The unit is month. Caution: when this para and renew_flag para are valid, the request means to renew several months more pre-paid period. This para can only be changed on `IPSEC` vpn gateway.",
 			},
 			"charge_type": {
 				Type:        schema.TypeString,
@@ -351,7 +351,6 @@ func resourceTencentCloudVpnGatewayUpdate(d *schema.ResourceData, meta interface
 	gatewayId := d.Id()
 
 	unsupportedUpdateFields := []string{
-		"prepaid_period",
 		"type",
 	}
 	for _, field := range unsupportedUpdateFields {
@@ -360,6 +359,33 @@ func resourceTencentCloudVpnGatewayUpdate(d *schema.ResourceData, meta interface
 		}
 	}
 
+	if d.HasChange("prepaid_period") {
+		chargeType := d.Get("charge_type").(string)
+		period := d.Get("prepaid_period").(int)
+		if chargeType != VPN_CHARGE_TYPE_PREPAID {
+			return fmt.Errorf("Invalid renew flag change. Only support pre-paid vpn.")
+		}
+		request := vpc.NewRenewVpnGatewayRequest()
+		request.VpnGatewayId = &gatewayId
+		var preChargePara vpc.InstanceChargePrepaid
+		preChargePara.Period = helper.IntUint64(period)
+		request.InstanceChargePrepaid = &preChargePara
+
+		err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
+			_, e := meta.(*TencentCloudClient).apiV3Conn.UseVpcClient().RenewVpnGateway(request)
+			if e != nil {
+				log.Printf("[CRITAL]%s api[%s] fail, request body [%s], reason[%s]\n",
+					logId, request.GetAction(), request.ToJsonString(), e.Error())
+				return retryError(e)
+			}
+			return nil
+		})
+		if err != nil {
+			log.Printf("[CRITAL]%s modify VPN gateway prepaid period failed, reason:%s\n", logId, err.Error())
+			return err
+		}
+	}
+
 	if d.HasChange("prepaid_renew_flag") {
 		chargeType := d.Get("charge_type").(string)
 		renewFlag := d.Get("prepaid_renew_flag").(string)

website/docs/r/vpn_gateway.html.markdown

@@ -57,7 +57,7 @@ The following arguments are supported:
 * `cdc_id` - (Optional, String) CDC instance ID.
 * `charge_type` - (Optional, String) Charge Type of the VPN gateway. Valid value: `PREPAID`, `POSTPAID_BY_HOUR`. The default is `POSTPAID_BY_HOUR`.
 * `max_connection` - (Optional, Int) Maximum number of connected clients allowed for the SSL VPN gateway. Valid values: [5, 10, 20, 50, 100]. This parameter is only required for SSL VPN gateways.
-* `prepaid_period` - (Optional, Int) Period of instance to be prepaid. Valid value: `1`, `2`, `3`, `4`, `6`, `7`, `8`, `9`, `12`, `24`, `36`. The unit is month. Caution: when this para and renew_flag para are valid, the request means to renew several months more pre-paid period. This para can only be set to take effect in create operation.
+* `prepaid_period` - (Optional, Int) Period of instance to be prepaid. Valid value: `1`, `2`, `3`, `4`, `6`, `7`, `8`, `9`, `12`, `24`, `36`. The unit is month. Caution: when this para and renew_flag para are valid, the request means to renew several months more pre-paid period. This para can only be changed on `IPSEC` vpn gateway.
 * `prepaid_renew_flag` - (Optional, String) Flag indicates whether to renew or not. Valid value: `NOTIFY_AND_AUTO_RENEW`, `NOTIFY_AND_MANUAL_RENEW`.
 * `tags` - (Optional, Map) A list of tags used to associate different resources.
 * `type` - (Optional, String) Type of gateway instance. Valid value: `IPSEC`, `SSL` and `CCN`. Note: CCN type is only for whitelist customer now.