fix(teo): [117910882] Change action to Optional (#2672)

* fix: Change action to Optional

* feat: add changelog

* fix: T+3

Author: gitmkn

.changelog/2672.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_teo_rule_engine: Change action to Optional
+```

tencentcloud/services/teo/resource_tc_teo_rule_engine.go

@@ -80,6 +80,26 @@ func TestAccTencentCloudTeoRuleEngine_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "tags.#", "2"),
 				),
 			},
+			{
+				Config: testAccTeoRuleEngineActionUp,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckRuleEngineExists("tencentcloud_teo_rule_engine.basic"),
+					resource.TestCheckResourceAttrSet("tencentcloud_teo_rule_engine.basic", "zone_id"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rule_name", "rule-up"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "status", "enable"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.or.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.tags.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.rules.0.or.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.rules.0.or.0.and.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.rules.0.or.0.and.0.operator", "equal"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.rules.0.or.0.and.0.target", "filename"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.rules.0.or.0.and.0.ignore_case", "false"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "rules.0.sub_rules.0.rules.0.or.0.and.0.values.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_teo_rule_engine.basic", "tags.#", "2"),
+				),
+			},
 		},
 	})
 }
@@ -139,12 +159,18 @@ func testAccCheckRuleEngineExists(r string) resource.TestCheckFunc {
 	}
 }
 
-const testAccTeoRuleEngine = testAccTeoZone + `
+const testAccZoneVar = `
+variable "zone_id" {
+  default = "zone-2qtuhspy7cr6"
+}
+`
+
+const testAccTeoRuleEngine = testAccZoneVar + `
 
 resource "tencentcloud_teo_rule_engine" "basic" {
 	rule_name = "rule-1"
 	status    = "enable"
-	zone_id   = tencentcloud_teo_zone.basic.id
+	zone_id   = var.zone_id
   
 	rules {
 	  actions {
@@ -197,12 +223,12 @@ resource "tencentcloud_teo_rule_engine" "basic" {
   }
 `
 
-const testAccTeoRuleEngineUp = testAccTeoZone + `
+const testAccTeoRuleEngineUp = testAccZoneVar + `
 
 resource "tencentcloud_teo_rule_engine" "basic" {
 	rule_name = "rule-up"
 	status    = "enable"
-	zone_id   = tencentcloud_teo_zone.basic.id
+	zone_id   = var.zone_id
 
 	tags = ["keep-test-np1", "keep-test-np2"]
   
@@ -256,3 +282,48 @@ resource "tencentcloud_teo_rule_engine" "basic" {
 	}
   }
 `
+
+const testAccTeoRuleEngineActionUp = testAccZoneVar + `
+
+resource "tencentcloud_teo_rule_engine" "basic" {
+	rule_name = "rule-up"
+	status    = "enable"
+	zone_id   = var.zone_id
+
+	tags = ["keep-test-np1", "keep-test-np2"]
+  
+	rules {
+	  or {
+		and {
+		  operator = "equal"
+		  target   = "extension"
+		  values   = [
+			"11",
+		  ]
+		}
+	  }
+	  sub_rules {
+		  tags = ["test-tag",]
+		  rules {
+			or {
+			  and {
+				operator = "equal"
+				target = "filename"
+				ignore_case = false
+				values = ["test.txt"]
+			  }
+			}
+			actions {
+				normal_action {
+					action = "HostHeader"
+					parameters {
+						name = "ServerName"
+						values = ["terraform-test.com"]
+					}
+				}
+			}
+		  }
+	  }
+	}
+  }
+`

tencentcloud/services/teo/resource_tc_teo_rule_engine_test.go

@@ -954,10 +954,10 @@ func (me *TeoService) DescribeTeoRuleEngineById(ctx context.Context, zoneId stri
 	logId := tccommon.GetLogId(ctx)
 
 	request := teo.NewDescribeRulesRequest()
-	request.ZoneId = &zoneId
+	request.ZoneId = helper.String(zoneId)
 	filter := &teo.Filter{
 		Name:   helper.String("rule-id"),
-		Values: []*string{&ruleId},
+		Values: []*string{helper.String(ruleId)},
 	}
 	request.Filters = append(request.Filters, filter)
 

tencentcloud/services/teo/service_tencentcloud_teo.go

@@ -289,14 +289,14 @@ The `rewrite_action` object of `actions` supports the following:
 
 The `rules` object of `sub_rules` supports the following:
 
-* `actions` - (Required, List) The feature to be executed.
 * `or` - (Required, List) The condition that determines if a feature should run.
 Note: If any condition in the array is met, the feature will run.
+* `actions` - (Optional, List) The feature to be executed.
 
 The `rules` object supports the following:
 
-* `actions` - (Required, List) Feature to be executed.
 * `or` - (Required, List) OR Conditions list of the rule. Rule would be triggered if any of the condition is true.
+* `actions` - (Optional, List) Feature to be executed.
 * `sub_rules` - (Optional, List) The nested rule.
 
 The `sub_rules` object of `rules` supports the following: