fix: clb - attach data conflict and add target group sweeper (#1162)

Author: Kagashino

tencentcloud/common.go

@@ -32,7 +32,8 @@ const (
 	PROVIDER_READ_RETRY_TIMEOUT  = "TENCENTCLOUD_READ_RETRY_TIMEOUT"
 	PROVIDER_WRITE_RETRY_TIMEOUT = "TENCENTCLOUD_WRITE_RETRY_TIMEOUT"
 
-	SWEEPER_NEED_PROTECT = "SWEEPER_NEED_PROTECT"
+	SWEEPER_NEED_PROTECT            = "SWEEPER_NEED_PROTECT"
+	TENCENTCLOUD_COMMON_TIME_LAYOUT = "2006-01-02 15:04:05"
 )
 
 var logFirstTime = ""
@@ -88,11 +89,22 @@ func getEnvDefault(key string, defVal int) int {
 
 // string to time.Time
 func stringTotime(t string) time.Time {
-	template := "2006-01-02 15:04:05"
+	template := TENCENTCLOUD_COMMON_TIME_LAYOUT
 	stamp, _ := time.ParseInLocation(template, t, time.Local)
 	return stamp
 }
 
+func parseTimeFromCommonLayout(t *string) time.Time {
+	if t == nil {
+		return time.Time{}
+	}
+	result, err := time.Parse(TENCENTCLOUD_COMMON_TIME_LAYOUT, *t)
+	if err != nil {
+		return time.Time{}
+	}
+	return result
+}
+
 // getLogId get logId for trace, return a new logId if ctx is nil
 func getLogId(ctx context.Context) string {
 	if ctx != nil {

tencentcloud/data_source_tc_clb_attachments_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDataSourceClbServerAttachments(t *testing.T) {
+func TestAccTencentCloudClbServerAttachmentsDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/data_source_tc_clb_target_groups_test.go

@@ -56,8 +56,8 @@ func TestAccTencentCloudClbTargetGroupDataSource(t *testing.T) {
 const tareGetGroupBase = defaultVpcSubnets + `
 resource "tencentcloud_clb_instance" "clb_basic" {
   network_type = "OPEN"
-  clb_name     = "tf-clb-rule-basic"
-    vpc_id = local.vpc_id
+  clb_name     = "tf-clb-rule-data"
+  vpc_id = local.vpc_id
 }
 
 resource "tencentcloud_clb_listener" "listener_basic" {

tencentcloud/resource_tc_clb_target_group_test.go

@@ -3,13 +3,48 @@ package tencentcloud
 import (
 	"context"
 	"fmt"
+	"log"
 	"testing"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
+func init() {
+	// go test -v ./tencentcloud -sweep=ap-guangzhou -sweep-run=tencentcloud_clb_target_group
+	resource.AddTestSweepers("tencentcloud_clb_target_group", &resource.Sweeper{
+		Name: "tencentcloud_clb_target_group",
+		F: func(r string) error {
+			logId := getLogId(contextNil)
+			ctx := context.WithValue(context.TODO(), logIdKey, logId)
+			cli, _ := sharedClientForRegion(r)
+			client := cli.(*TencentCloudClient).apiV3Conn
+			service := ClbService{client}
+
+			tgs, err := service.DescribeTargetGroups(ctx, "", nil)
+			if err != nil {
+				return err
+			}
+
+			for i := range tgs {
+				tg := tgs[i]
+				created := parseTimeFromCommonLayout(tg.CreatedTime)
+				if isResourcePersist(*tg.TargetGroupName, &created) {
+					continue
+				}
+				log.Printf("%s will be remvoed", *tg.TargetGroupName)
+				err = service.DeleteTarget(ctx, *tg.TargetGroupId)
+				if err != nil {
+					continue
+				}
+			}
+
+			return nil
+		},
+	})
+}
+
 func TestAccTencentCloudClbTargetGroup_basic(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{