Merge pull request #1482 from tencentcloudstack/feat/support-as-instance-datasource

Feat/support as instance datasource

Author: lyu571

.changelog/1482.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+tencentcloud_as_instances
+```

tencentcloud/data_source_tc_as_instances.go

@@ -0,0 +1,283 @@
+/*
+Use this data source to query detailed information of as instances
+
+Example Usage
+
+```hcl
+resource "tencentcloud_as_scaling_group" "scaling_group" {
+  scaling_group_name = "tf-as-group-ds-ins-basic"
+  configuration_id   = "your_launch_configuration_id"
+  max_size           = 1
+  min_size           = 1
+  vpc_id             = "your_vpc_id"
+  subnet_ids         = ["your_subnet_id"]
+
+  tags = {
+    "test" = "test"
+  }
+}
+
+data "tencentcloud_as_instances" "instances" {
+  filters {
+	name = "auto-scaling-group-id"
+	values = [tencentcloud_as_scaling_group.scaling_group.id]
+  }
+}
+```
+*/
+package tencentcloud
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+	as "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/as/v20180419"
+	"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper"
+)
+
+func dataSourceTencentCloudAsInstances() *schema.Resource {
+	return &schema.Resource{
+		Read: dataSourceTencentCloudAsInstancesRead,
+		Schema: map[string]*schema.Schema{
+			"instance_ids": {
+				Optional: true,
+				Type:     schema.TypeSet,
+				Elem: &schema.Schema{
+					Type: schema.TypeString,
+				},
+				Description: "Instance ID of the cloud server (CVM) to be queried. The limit is 100 per request.",
+			},
+
+			"filters": {
+				Optional:    true,
+				Type:        schema.TypeList,
+				Description: "Filter conditions. If there are multiple Filters, the relationship between Filters is a logical AND (AND) relationship. If there are multiple Values in the same Filter, the relationship between Values under the same Filter is a logical OR (OR) relationship.",
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"name": {
+							Type:        schema.TypeString,
+							Required:    true,
+							Description: "Fields to be filtered. Valid names: `instance-id`: Filters by instance ID, `auto-scaling-group-id`: Filter by scaling group ID.",
+						},
+						"values": {
+							Type: schema.TypeSet,
+							Elem: &schema.Schema{
+								Type: schema.TypeString,
+							},
+							Required:    true,
+							Description: "Value of the field.",
+						},
+					},
+				},
+			},
+
+			"instance_list": {
+				Computed:    true,
+				Type:        schema.TypeList,
+				Description: "List of instance details.",
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"instance_id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Instance ID.",
+						},
+						"auto_scaling_group_id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Auto scaling group ID.",
+						},
+						"auto_scaling_group_name": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Auto scaling group name.",
+						},
+						"launch_configuration_id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Launch configuration ID.",
+						},
+						"launch_configuration_name": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Launch configuration name.",
+						},
+						"life_cycle_state": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Life cycle state. Please refer to the link for field value details: https://cloud.tencent.com/document/api/377/20453#Instance.",
+						},
+						"health_status": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Health status, the valid values are HEALTHY and UNHEALTHY.",
+						},
+						"protected_from_scale_in": {
+							Type:        schema.TypeBool,
+							Computed:    true,
+							Description: "Enable scale in protection.",
+						},
+						"zone": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Available zone.",
+						},
+						"creation_type": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Valid values: `AUTO_CREATION`, `MANUAL_ATTACHING`.",
+						},
+						"add_time": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The time when the instance joined the group.",
+						},
+						"instance_type": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Instance type.",
+						},
+						"version_number": {
+							Type:        schema.TypeInt,
+							Computed:    true,
+							Description: "Version ID.",
+						},
+					},
+				},
+			},
+
+			"result_output_file": {
+				Type:        schema.TypeString,
+				Optional:    true,
+				Description: "Used to save results.",
+			},
+		},
+	}
+}
+
+func dataSourceTencentCloudAsInstancesRead(d *schema.ResourceData, meta interface{}) error {
+	defer logElapsed("data_source.tencentcloud_as_instances.read")()
+	defer inconsistentCheck(d, meta)()
+
+	logId := getLogId(contextNil)
+
+	ctx := context.WithValue(context.TODO(), logIdKey, logId)
+
+	paramMap := make(map[string]interface{})
+	if v, ok := d.GetOk("instance_ids"); ok {
+		instanceIdsSet := v.(*schema.Set).List()
+		paramMap["InstanceIds"] = helper.InterfacesStringsPoint(instanceIdsSet)
+	}
+
+	if v, ok := d.GetOk("filters"); ok {
+		filtersSet := v.([]interface{})
+		tmpSet := make([]*as.Filter, 0, len(filtersSet))
+
+		for _, item := range filtersSet {
+			filter := as.Filter{}
+			filterMap := item.(map[string]interface{})
+
+			if v, ok := filterMap["name"]; ok {
+				filter.Name = helper.String(v.(string))
+			}
+			if v, ok := filterMap["values"]; ok {
+				valuesSet := v.(*schema.Set).List()
+				filter.Values = helper.InterfacesStringsPoint(valuesSet)
+			}
+			tmpSet = append(tmpSet, &filter)
+		}
+		paramMap["filters"] = tmpSet
+	}
+
+	service := AsService{client: meta.(*TencentCloudClient).apiV3Conn}
+
+	var instanceList []*as.Instance
+
+	err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
+		result, e := service.DescribeAsInstancesByFilter(ctx, paramMap)
+		if e != nil {
+			return retryError(e)
+		}
+		instanceList = result
+		return nil
+	})
+	if err != nil {
+		return err
+	}
+
+	ids := make([]string, 0, len(instanceList))
+	tmpList := make([]map[string]interface{}, 0, len(instanceList))
+
+	if instanceList != nil {
+		for _, instance := range instanceList {
+			instanceMap := map[string]interface{}{}
+
+			if instance.InstanceId != nil {
+				instanceMap["instance_id"] = instance.InstanceId
+			}
+
+			if instance.AutoScalingGroupId != nil {
+				instanceMap["auto_scaling_group_id"] = instance.AutoScalingGroupId
+			}
+
+			if instance.AutoScalingGroupName != nil {
+				instanceMap["auto_scaling_group_name"] = instance.AutoScalingGroupName
+			}
+
+			if instance.LaunchConfigurationId != nil {
+				instanceMap["launch_configuration_id"] = instance.LaunchConfigurationId
+			}
+
+			if instance.LaunchConfigurationName != nil {
+				instanceMap["launch_configuration_name"] = instance.LaunchConfigurationName
+			}
+
+			if instance.LifeCycleState != nil {
+				instanceMap["life_cycle_state"] = instance.LifeCycleState
+			}
+
+			if instance.HealthStatus != nil {
+				instanceMap["health_status"] = instance.HealthStatus
+			}
+
+			if instance.ProtectedFromScaleIn != nil {
+				instanceMap["protected_from_scale_in"] = instance.ProtectedFromScaleIn
+			}
+
+			if instance.Zone != nil {
+				instanceMap["zone"] = instance.Zone
+			}
+
+			if instance.CreationType != nil {
+				instanceMap["creation_type"] = instance.CreationType
+			}
+
+			if instance.AddTime != nil {
+				instanceMap["add_time"] = instance.AddTime
+			}
+
+			if instance.InstanceType != nil {
+				instanceMap["instance_type"] = instance.InstanceType
+			}
+
+			if instance.VersionNumber != nil {
+				instanceMap["version_number"] = instance.VersionNumber
+			}
+
+			ids = append(ids, *instance.InstanceId)
+			tmpList = append(tmpList, instanceMap)
+		}
+
+		_ = d.Set("instance_list", tmpList)
+	}
+
+	d.SetId(helper.DataResourceIdsHash(ids))
+	output, ok := d.GetOk("result_output_file")
+	if ok && output.(string) != "" {
+		if e := writeToFile(output.(string), tmpList); e != nil {
+			return e
+		}
+	}
+	return nil
+}

tencentcloud/data_source_tc_as_instances_test.go

@@ -0,0 +1,69 @@
+package tencentcloud
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+)
+
+func TestAccTencentCloudAsInstancesDataSource_basic(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			testAccPreCheck(t)
+		},
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccAsInstancesDataSource_basic(),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckTencentCloudDataSourceID("data.tencentcloud_as_instances.instances"),
+					resource.TestCheckResourceAttrSet("data.tencentcloud_as_instances.instances", "instance_list.#"),
+				),
+			},
+		},
+	})
+}
+
+func testAccAsInstancesDataSource_basic() string {
+	return defaultAsVariable + `
+resource "tencentcloud_vpc" "vpc" {
+  name       = "tf-as-vpc"
+  cidr_block = "10.2.0.0/16"
+}
+
+resource "tencentcloud_subnet" "subnet" {
+  vpc_id            = tencentcloud_vpc.vpc.id
+  name              = "tf-as-subnet"
+  cidr_block        = "10.2.11.0/24"
+  availability_zone = var.availability_zone
+}
+
+resource "tencentcloud_as_scaling_config" "launch_configuration" {
+  configuration_name = "tf-as-configuration-ds-ins-basic"
+  image_id           = "img-2lr9q49h"
+  instance_types     = [data.tencentcloud_instance_types.default.instance_types.0.instance_type]
+}
+
+resource "tencentcloud_as_scaling_group" "scaling_group" {
+  scaling_group_name = "tf-as-group-ds-ins-basic"
+  configuration_id   = tencentcloud_as_scaling_config.launch_configuration.id
+  max_size           = 1
+  min_size           = 1
+  vpc_id             = tencentcloud_vpc.vpc.id
+  subnet_ids         = [tencentcloud_subnet.subnet.id]
+
+  tags = {
+    "test" = "test"
+  }
+}
+
+data "tencentcloud_as_instances" "instances" {
+	filters {
+		name = "auto-scaling-group-id"
+		values = [tencentcloud_as_scaling_group.scaling_group.id]
+  }
+}
+
+`
+}

tencentcloud/provider.go

@@ -116,6 +116,7 @@ Auto Scaling(AS)
     tencentcloud_as_scaling_configs
     tencentcloud_as_scaling_groups
     tencentcloud_as_scaling_policies
+	tencentcloud_as_instances
 
   Resource
     tencentcloud_as_scaling_config
@@ -1211,6 +1212,7 @@ func Provider() terraform.ResourceProvider {
 			"tencentcloud_tcmq_queue":                               dataSourceTencentCloudTcmqQueue(),
 			"tencentcloud_tcmq_topic":                               dataSourceTencentCloudTcmqTopic(),
 			"tencentcloud_tcmq_subscribe":                           dataSourceTencentCloudTcmqSubscribe(),
+			"tencentcloud_as_instances":                             dataSourceTencentCloudAsInstances(),
 		},
 
 		ResourcesMap: map[string]*schema.Resource{