feat: dlc store location (#2262)

* feat: doc

* feat: doc

* feat: changelog

---------

Co-authored-by: WeiMengXS <nickcchen@tencent.com>

Author: WeiMengXS

.changelog/2262.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+tencentcloud_dlc_store_location_config: Support api `ModifyAdvancedStoreLocation` and `DescribeAdvancedStoreLocation`, replace `CreateStoreLocation` and `DescribeStoreLocation`
+```

go.mod

@@ -54,7 +54,7 @@ require (
 	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dbbrain v1.0.652
 	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dc v1.0.633
 	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dcdb v1.0.673
-	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dlc v1.0.768
+	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dlc v1.0.777
 	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod v1.0.765
 	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/domain v1.0.414
 	github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dts v1.0.628

go.sum

@@ -890,6 +890,8 @@ github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dcdb v1.0.673 h1:YyjGLj
 github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dcdb v1.0.673/go.mod h1:hXPMop1kJFqAvHj+7TyxxxXS/HGUP4SuKx5gGoAl0Zc=
 github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dlc v1.0.768 h1:iLKkurl27Znu0MjMpWK6miP+4L6E/tPflRzGv2dVDCU=
 github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dlc v1.0.768/go.mod h1:RAxl/gvd0vEXPlwESmyv7XgfKFKPKQkGksumwX4aLvU=
+github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dlc v1.0.777 h1:3fuNSFtYzAa7pR9/xhGiirOfZIwVTPRw0DKWi/Ar5bw=
+github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dlc v1.0.777/go.mod h1:Zr9BUBp00uOgu0zS43wT8wKZul08iQmZ3WjJ1St1ENc=
 github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod v1.0.765 h1:46VxMLFcM3mWr+GdOHmMCXsQM8Mle7pOip1z2RWmubU=
 github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod v1.0.765/go.mod h1:EYfCXcZvLWidtpSNYsR2pvrBCUmOza39kox80Ud6PZg=
 github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/domain v1.0.414 h1:egwjvOEUKBaxsoRVn/YSEhp2E8qdh77Ous9A/wftDo0=

tencentcloud/resource_tc_dlc_store_location_config.go

@@ -5,7 +5,8 @@ Example Usage
 
 ```hcl
 resource "tencentcloud_dlc_store_location_config" "store_location_config" {
-  store_location = "cosn://cos-xxxxx-xxx/test/"
+  store_location = "cosn://bucketname/"
+  enable = 1
 }
 ```
 
@@ -42,7 +43,13 @@ func resourceTencentCloudDlcStoreLocationConfig() *schema.Resource {
 			"store_location": {
 				Required:    true,
 				Type:        schema.TypeString,
-				Description: "Calculate the results of the COS path, such as: cosn: // bucketName/.",
+				Description: "The calculation results are stored in the cos path, such as: cosn://bucketname/.",
+			},
+
+			"enable": {
+				Required:    true,
+				Type:        schema.TypeInt,
+				Description: "Whether to enable advanced settings: 0-no, 1-yes.",
 			},
 		},
 	}
@@ -65,9 +72,7 @@ func resourceTencentCloudDlcStoreLocationConfigRead(d *schema.ResourceData, meta
 
 	service := DlcService{client: meta.(*TencentCloudClient).apiV3Conn}
 
-	storeLocationConfigId := d.Id()
-
-	storeLocationConfig, err := service.DescribeDlcStoreLocationConfigById(ctx, storeLocationConfigId)
+	storeLocationConfig, err := service.DescribeDlcStoreLocationConfigById(ctx)
 	if err != nil {
 		return err
 	}
@@ -82,6 +87,9 @@ func resourceTencentCloudDlcStoreLocationConfigRead(d *schema.ResourceData, meta
 		_ = d.Set("store_location", storeLocationConfig.StoreLocation)
 	}
 
+	if storeLocationConfig.Enable != nil {
+		_ = d.Set("enable", storeLocationConfig.Enable)
+	}
 	return nil
 }
 
@@ -91,18 +99,20 @@ func resourceTencentCloudDlcStoreLocationConfigUpdate(d *schema.ResourceData, me
 
 	logId := getLogId(contextNil)
 
-	request := dlc.NewCreateStoreLocationRequest()
+	request := dlc.NewModifyAdvancedStoreLocationRequest()
 
-	var (
-		storeLocationId string
-	)
+	var storeLocation string
 	if v, ok := d.GetOk("store_location"); ok {
-		storeLocationId = v.(string)
+		storeLocation = v.(string)
 		request.StoreLocation = helper.String(v.(string))
 	}
 
+	if v, ok := d.GetOkExists("enable"); ok {
+		request.Enable = helper.IntUint64(v.(int))
+	}
+
 	err := resource.Retry(writeRetryTimeout, func() *resource.RetryError {
-		result, e := meta.(*TencentCloudClient).apiV3Conn.UseDlcClient().CreateStoreLocation(request)
+		result, e := meta.(*TencentCloudClient).apiV3Conn.UseDlcClient().ModifyAdvancedStoreLocation(request)
 		if e != nil {
 			return retryError(e)
 		} else {
@@ -115,8 +125,7 @@ func resourceTencentCloudDlcStoreLocationConfigUpdate(d *schema.ResourceData, me
 		return err
 	}
 
-	d.SetId(storeLocationId)
-
+	d.SetId(storeLocation)
 	return resourceTencentCloudDlcStoreLocationConfigRead(d, meta)
 }
 

tencentcloud/resource_tc_dlc_store_location_config_test.go

@@ -17,12 +17,15 @@ func TestAccTencentCloudDlcStoreLocationConfigResource_basic(t *testing.T) {
 			{
 				Config: testAccDlcStoreLocationConfig,
 				Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_dlc_store_location_config.store_location_config", "id"),
-					resource.TestCheckResourceAttr("tencentcloud_dlc_store_location_config.store_location_config", "store_location", "cosn://cos-lock-1308919341/test/")),
+					resource.TestCheckResourceAttr("tencentcloud_dlc_store_location_config.store_location_config", "store_location", "cosn://cos-lock-1308919341/test/"),
+					resource.TestCheckResourceAttr("tencentcloud_dlc_store_location_config.store_location_config", "enable", "1"),
+				),
 			},
 			{
 				Config: testAccDlcStoreLocationConfigUpdate,
 				Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_dlc_store_location_config.store_location_config", "id"),
-					resource.TestCheckResourceAttr("tencentcloud_dlc_store_location_config.store_location_config", "store_location", "cosn://cos-lock-1308919341/")),
+					resource.TestCheckResourceAttr("tencentcloud_dlc_store_location_config.store_location_config", "store_location", "cosn://cos-lock-1308919341/"),
+					resource.TestCheckResourceAttr("tencentcloud_dlc_store_location_config.store_location_config", "enable", "1")),
 			},
 			{
 				ResourceName:      "tencentcloud_dlc_store_location_config.store_location_config",
@@ -37,13 +40,15 @@ const testAccDlcStoreLocationConfig = `
 
 resource "tencentcloud_dlc_store_location_config" "store_location_config" {
   store_location = "cosn://cos-lock-1308919341/test/"
+  enable = 1
 }
 
 `
 const testAccDlcStoreLocationConfigUpdate = `
 
 resource "tencentcloud_dlc_store_location_config" "store_location_config" {
   store_location = "cosn://cos-lock-1308919341/"
+  enable = 1
 }
 
 `

tencentcloud/service_tencentcloud_dlc.go

@@ -183,10 +183,10 @@ func (me *DlcService) DescribeDlcCheckDataEngineImageCanBeRollbackByFilter(ctx c
 	return
 }
 
-func (me *DlcService) DescribeDlcStoreLocationConfigById(ctx context.Context, storeLocationId string) (storeLocationConfig *dlc.DescribeStoreLocationResponseParams, errRet error) {
+func (me *DlcService) DescribeDlcStoreLocationConfigById(ctx context.Context) (storeLocationConfig *dlc.DescribeAdvancedStoreLocationResponseParams, errRet error) {
 	logId := getLogId(ctx)
 
-	request := dlc.NewDescribeStoreLocationRequest()
+	request := dlc.NewDescribeAdvancedStoreLocationRequest()
 
 	defer func() {
 		if errRet != nil {
@@ -196,13 +196,16 @@ func (me *DlcService) DescribeDlcStoreLocationConfigById(ctx context.Context, st
 
 	ratelimit.Check(request.GetAction())
 
-	response, err := me.client.UseDlcClient().DescribeStoreLocation(request)
+	response, err := me.client.UseDlcClient().DescribeAdvancedStoreLocation(request)
 	if err != nil {
 		errRet = err
 		return
 	}
 	log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
 
+	if response == nil || response.Response == nil {
+		return
+	}
 	storeLocationConfig = response.Response
 	return
 }