Skip to content

Commit 91237f3

Browse files
committed
2 parents 3891e9e + 2b54ce2 commit 91237f3

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

.changelog/1326.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
resource/tencentcloud_teo_zone: change tag description from zoneName to zoneId
3+
```

tencentcloud/resource_tc_teo_zone.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ func resourceTencentCloudTeoZoneCreate(d *schema.ResourceData, meta interface{})
343343
ctx := context.WithValue(context.TODO(), logIdKey, logId)
344344
if tags := helper.GetTags(d, "tags"); len(tags) > 0 {
345345
tagService := TagService{client: meta.(*TencentCloudClient).apiV3Conn}
346-
resourceName := fmt.Sprintf("qcs::teo::uin/:zone/%s", zoneName)
346+
resourceName := fmt.Sprintf("qcs::teo::uin/:zone/%s", zoneId)
347347
if err := tagService.ModifyTags(ctx, resourceName, tags, nil); err != nil {
348348
return err
349349
}
@@ -507,7 +507,7 @@ func resourceTencentCloudTeoZoneRead(d *schema.ResourceData, meta interface{}) e
507507

508508
tcClient := meta.(*TencentCloudClient).apiV3Conn
509509
tagService := &TagService{client: tcClient}
510-
tags, err := tagService.DescribeResourceTags(ctx, "teo", "zone", "", *zone.ZoneName)
510+
tags, err := tagService.DescribeResourceTags(ctx, "teo", "zone", "", zoneId)
511511
if err != nil {
512512
return err
513513
}
@@ -605,7 +605,7 @@ func resourceTencentCloudTeoZoneUpdate(d *schema.ResourceData, meta interface{})
605605
tagService := &TagService{client: tcClient}
606606
oldTags, newTags := d.GetChange("tags")
607607
replaceTags, deleteTags := diffTags(oldTags.(map[string]interface{}), newTags.(map[string]interface{}))
608-
resourceName := BuildTagResourceName("teo", "zone", "", d.Get("zone_name").(string))
608+
resourceName := BuildTagResourceName("teo", "zone", "", zoneId)
609609
if err := tagService.ModifyTags(ctx, resourceName, replaceTags, deleteTags); err != nil {
610610
return err
611611
}

tencentcloud/resource_tc_teo_zone_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func TestAccTencentCloudTeoZone_basic(t *testing.T) {
6161
resource.TestCheckResourceAttr("tencentcloud_teo_zone.basic", "type", "full"),
6262
resource.TestCheckResourceAttr("tencentcloud_teo_zone.basic", "paused", "false"),
6363
resource.TestCheckResourceAttr("tencentcloud_teo_zone.basic", "cname_speed_up", "enabled"),
64-
//resource.TestCheckResourceAttr("tencentcloud_teo_zone.basic", "vanity_name_servers.0.servers", ""),
64+
resource.TestCheckResourceAttr("tencentcloud_teo_zone.basic", "tags.createdBy", "terraform"),
6565
),
6666
},
6767
//{
@@ -122,13 +122,12 @@ resource "tencentcloud_teo_zone" "basic" {
122122
cname_speed_up = "enabled"
123123
plan_type = "ent_with_bot"
124124
paused = false
125-
tags = {}
126125
type = "full"
127126
zone_name = "tf-teo.xyz"
128127
129-
#tags = {
130-
# "TestKey" = "terraform"
131-
#}
128+
tags = {
129+
"createdBy" = "terraform"
130+
}
132131
}
133132
134133
`

0 commit comments

Comments
 (0)