fix clb attachment update targets limit (#1644)

* fix clb attachment update targets limit

* add changelog

* fmt test name

---------

Co-authored-by: mikatong <mikatong@tencent.com>

Author: tongyiming

.changelog/1644.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_clb_attachment: remove update targets limit
+```

tencentcloud/resource_tc_clb_attachment.go

@@ -362,16 +362,38 @@ func resourceTencentCloudClbServerAttachmentUpdate(d *schema.ResourceData, meta
 		ns := n.(*schema.Set)
 		add := ns.Difference(os).List()
 		remove := os.Difference(ns).List()
-		if len(remove) > 0 {
-			err := resourceTencentCloudClbServerAttachmentRemove(d, meta, remove)
-			if err != nil {
-				return err
+		addLen := len(add)
+		removeLen := len(remove)
+		if removeLen > 0 {
+			for count := 0; count < removeLen; count += 20 {
+				removeList := make([]interface{}, 0, 20)
+				for i := 0; i < 20; i++ {
+					index := count + i
+					if index >= removeLen {
+						break
+					}
+					removeList = append(removeList, remove[index])
+				}
+				err := resourceTencentCloudClbServerAttachmentRemove(d, meta, removeList)
+				if err != nil {
+					return err
+				}
 			}
 		}
-		if len(add) > 0 {
-			err := resourceTencentCloudClbServerAttachmentAdd(d, meta, add)
-			if err != nil {
-				return err
+		if addLen > 0 {
+			for count := 0; count < addLen; count += 20 {
+				addList := make([]interface{}, 0, 20)
+				for i := 0; i < 20; i++ {
+					index := count + i
+					if index >= addLen {
+						break
+					}
+					addList = append(addList, add[index])
+				}
+				err := resourceTencentCloudClbServerAttachmentAdd(d, meta, addList)
+				if err != nil {
+					return err
+				}
 			}
 		}
 		return resourceTencentCloudClbServerAttachmentRead(d, meta)

tencentcloud/resource_tc_clb_attachment_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccTencentCloudClbServerAttachment_tcp(t *testing.T) {
+func TestAccTencentCloudClbAttachmentResource_tcp(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -50,7 +50,7 @@ func TestAccTencentCloudClbServerAttachment_tcp(t *testing.T) {
 	})
 }
 
-func TestAccTencentCloudClbServerAttachment_http(t *testing.T) {
+func TestAccTencentCloudClbAttachmentResource_http(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -103,7 +103,7 @@ func testAccCheckClbServerAttachmentDestroy(s *terraform.State) error {
 	return nil
 }
 
-func TestAccCheckClbServerAttachmentTargetGroups(t *testing.T) {
+func TestAccTencentCloudClbAttachmentResource_argetGroups(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() {
 			testAccPreCheck(t)