misc: golint

Author: xawei

tencentcloud/extension_tke.go

@@ -135,5 +135,4 @@ const (
 
 const (
 	backupStorageLocationStateAvailable   = "Available"
-	backupStorageLocationStateUnavailable = "Unavailable"
 )

tencentcloud/resource_tc_kubernetes_backup_storage_location.go

@@ -5,11 +5,13 @@ Provide a resource to create tke backup storage location.
 
 Example Usage
 ```
-resource "tencentcloud_kubernetes_backup_storage_location" "example_backup" {
-  name            = "example-backup-1"
-  storage_region  = "ap-guangzhou" # region of you pre-created COS bucket
-  bucket          = "tke-backup-example-1" # bucket name of your pre-created COS bucket
-}
+
+	resource "tencentcloud_kubernetes_backup_storage_location" "example_backup" {
+	  name            = "example-backup-1"
+	  storage_region  = "ap-guangzhou" # region of you pre-created COS bucket
+	  bucket          = "tke-backup-example-1" # bucket name of your pre-created COS bucket
+	}
+
 ```
 
 Import
@@ -130,10 +132,8 @@ func resourceTencentCloudTkeBackupStorageLocationRead(d *schema.ResourceData, me
 	if err != nil {
 		return err
 	}
-	has := false
 	for _, location := range locations {
 		if *location.Name == d.Id() {
-			has = true
 			_ = d.Set("name", location.Name)
 			_ = d.Set("storage_region", location.StorageRegion)
 			_ = d.Set("bucket", location.Bucket)
@@ -143,11 +143,8 @@ func resourceTencentCloudTkeBackupStorageLocationRead(d *schema.ResourceData, me
 			return nil
 		}
 	}
-	if !has {
-		d.SetId("")
-		return nil
-	}
 
+	d.SetId("")
 	return nil
 }
 
@@ -175,6 +172,9 @@ func resourceTencentCloudTkeBackupStorageLocationDelete(d *schema.ResourceData,
 		}
 		return resource.RetryableError(fmt.Errorf("location %s is still not deleted", d.Id()))
 	})
+	if err != nil {
+		return err
+	}
 
 	return nil
 }

tencentcloud/service_tencentcloud_tke.go

@@ -714,7 +714,7 @@ func (me *TkeService) CheckOneOfClusterNodeReady(ctx context.Context, clusterId
 }
 
 /*
-	if cluster is creating, return error:TencentCloudSDKError] Code=InternalError.ClusterState
+if cluster is creating, return error:TencentCloudSDKError] Code=InternalError.ClusterState
 */
 func (me *TkeService) DeleteClusterInstances(ctx context.Context, id string, instanceIds []string) (errRet error) {
 	logId := getLogId(ctx)
@@ -823,7 +823,7 @@ func (me *TkeService) DeleteClusterAsGroups(ctx context.Context, id, asGroupId s
 }
 
 /*
-  open internet access
+open internet access
 */
 func (me *TkeService) CreateClusterEndpoint(ctx context.Context, id string, subnetId, securityGroupId string, internet bool, domain string) (errRet error) {
 	logId := getLogId(ctx)
@@ -1430,7 +1430,7 @@ func (me *TkeService) DescribeNodePool(ctx context.Context, clusterId string, no
 	return
 }
 
-//node pool global config
+// node pool global config
 func (me *TkeService) ModifyClusterNodePoolGlobalConfig(ctx context.Context, request *tke.ModifyClusterAsGroupOptionAttributeRequest) (errRet error) {
 	logId := getLogId(ctx)
 	defer func() {
@@ -2176,9 +2176,7 @@ func (me *TkeService) describeBackupStorageLocations(ctx context.Context, names
 		logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
 
 	if response.Response != nil && len(response.Response.BackupStorageLocationSet) > 0 {
-		for _, bl := range response.Response.BackupStorageLocationSet {
-			locations = append(locations, bl)
-		}
+		locations = append(locations, response.Response.BackupStorageLocationSet...)
 	}
 	return
 
@@ -2199,4 +2197,4 @@ func (me *TkeService) deleteBackupStorageLocation(ctx context.Context, name stri
 	ratelimit.Check(request.GetAction())
 	_, err := me.client.UseTkeClient().DeleteBackupStorageLocation(request)
 	return err
-}
+}