fix: modify route_update

Author: gitmkn

tencentcloud/resource_tc_tse_cngw_route.go

@@ -476,7 +476,7 @@ func resourceTencentCloudTseCngwRouteUpdate(d *schema.ResourceData, meta interfa
 	request.RouteName = &routeName
 	request.RouteID = cngwRoute.ID
 
-	immutableArgs := []string{"gateway_id", "service_id", "route_name"}
+	immutableArgs := []string{"gateway_id", "service_id", "route_name", "force_https"}
 
 	for _, v := range immutableArgs {
 		if d.HasChange(v) {
@@ -494,33 +494,27 @@ func resourceTencentCloudTseCngwRouteUpdate(d *schema.ResourceData, meta interfa
 		}
 	}
 
-	if d.HasChange("hosts") {
-		if v, ok := d.GetOk("hosts"); ok {
-			hostsSet := v.(*schema.Set).List()
-			for i := range hostsSet {
-				hosts := hostsSet[i].(string)
-				request.Hosts = append(request.Hosts, &hosts)
-			}
+	if v, ok := d.GetOk("hosts"); ok {
+		hostsSet := v.(*schema.Set).List()
+		for i := range hostsSet {
+			hosts := hostsSet[i].(string)
+			request.Hosts = append(request.Hosts, &hosts)
 		}
 	}
 
-	if d.HasChange("paths") {
-		if v, ok := d.GetOk("paths"); ok {
-			pathsSet := v.(*schema.Set).List()
-			for i := range pathsSet {
-				paths := pathsSet[i].(string)
-				request.Paths = append(request.Paths, &paths)
-			}
+	if v, ok := d.GetOk("paths"); ok {
+		pathsSet := v.(*schema.Set).List()
+		for i := range pathsSet {
+			paths := pathsSet[i].(string)
+			request.Paths = append(request.Paths, &paths)
 		}
 	}
 
-	if d.HasChange("protocols") {
-		if v, ok := d.GetOk("protocols"); ok {
-			protocolsSet := v.(*schema.Set).List()
-			for i := range protocolsSet {
-				protocols := protocolsSet[i].(string)
-				request.Protocols = append(request.Protocols, &protocols)
-			}
+	if v, ok := d.GetOk("protocols"); ok {
+		protocolsSet := v.(*schema.Set).List()
+		for i := range protocolsSet {
+			protocols := protocolsSet[i].(string)
+			request.Protocols = append(request.Protocols, &protocols)
 		}
 	}
 
@@ -542,11 +536,11 @@ func resourceTencentCloudTseCngwRouteUpdate(d *schema.ResourceData, meta interfa
 		}
 	}
 
-	if d.HasChange("force_https") {
-		if v, ok := d.GetOkExists("force_https"); ok {
-			request.ForceHttps = helper.Bool(v.(bool))
-		}
-	}
+	// if d.HasChange("force_https") {
+	// 	if v, ok := d.GetOkExists("force_https"); ok {
+	// 		request.ForceHttps = helper.Bool(v.(bool))
+	// 	}
+	// }
 
 	if d.HasChange("destination_ports") {
 		if v, ok := d.GetOk("destination_ports"); ok {

tencentcloud/resource_tc_tse_cngw_route_test.go

@@ -45,6 +45,26 @@ func TestAccTencentCloudTseCngwRouteResource_basic(t *testing.T) {
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
+			{
+				Config: testAccTseCngwRouteUp,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckTseCngwRouteExists("tencentcloud_tse_cngw_route.cngw_route"),
+					resource.TestCheckResourceAttrSet("tencentcloud_tse_cngw_route.cngw_route", "id"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "gateway_id", defaultTseGatewayId),
+					// resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "force_https", "true"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "hosts.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "https_redirect_status_code", "301"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "paths.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "headers.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "headers.0.key", "req"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "headers.0.value", "terraform1"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "preserve_host", "true"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "protocols.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "route_name", "terraform-route"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "service_id", "b6017eaf-2363-481e-9e93-8d65aaf498cd"),
+					resource.TestCheckResourceAttr("tencentcloud_tse_cngw_route.cngw_route", "strip_path", "false"),
+				),
+			},
 		},
 	})
 }
@@ -137,3 +157,30 @@ resource "tencentcloud_tse_cngw_route" "cngw_route" {
   strip_path = true
 }
 `
+
+const testAccTseCngwRouteUp = DefaultTseVar + `
+
+resource "tencentcloud_tse_cngw_route" "cngw_route" {
+  destination_ports = []
+  force_https       = false
+  gateway_id        = var.gateway_id
+  hosts = [
+    "192.168.0.1:9091",
+  ]
+  https_redirect_status_code = 301
+  paths = [
+    "/user1",
+  ]
+  headers {
+  	key = "req"
+  	value = "terraform1"
+  }
+  preserve_host = true
+  protocols = [
+    "http",
+  ]
+  route_name = "terraform-route"
+  service_id = "b6017eaf-2363-481e-9e93-8d65aaf498cd"
+  strip_path = false
+}
+`