Skip to content

Commit 7978281

Browse files
authored
fix(privateDns): [126253123] tencentcloud_private_dns_record optmize code read function (#3467)
* add * add
1 parent 0d0bdaf commit 7978281

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

.changelog/3467.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
resource/tencentcloud_private_dns_record: optmize code read function
3+
```

tencentcloud/services/privatedns/resource_tc_private_dns_record.go

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -160,27 +160,14 @@ func resourceTencentCloudDPrivateDnsRecordRead(d *schema.ResourceData, meta inte
160160
zoneId := idSplit[0]
161161
recordId := idSplit[1]
162162

163-
records, err := service.DescribePrivateDnsRecordByFilter(ctx, zoneId, nil)
163+
record, err := service.DescribePrivateDnsRecordById(ctx, zoneId, recordId)
164164
if err != nil {
165165
return err
166166
}
167167

168-
if len(records) < 1 {
169-
d.SetId("")
170-
log.Printf("[WARN]%s resource `tencentcloud_private_dns_record` [%s] not found, please check if it has been deleted.\n", logId, recordId)
171-
return nil
172-
}
173-
174-
var record *privatedns.PrivateZoneRecord
175-
for _, item := range records {
176-
if item.RecordId != nil && *item.RecordId == recordId {
177-
record = item
178-
}
179-
}
180-
181168
if record == nil {
182-
d.SetId("")
183169
log.Printf("[WARN]%s resource `tencentcloud_private_dns_record` [%s] not found, please check if it has been deleted.\n", logId, recordId)
170+
d.SetId("")
184171
return nil
185172
}
186173

tencentcloud/services/privatedns/service_tencentcloud_private_dns.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func (me *PrivateDnsService) DescribePrivateDnsRecordByFilter(ctx context.Contex
3838
}
3939
}()
4040
var (
41-
limit int64 = 20
41+
limit int64 = 200
4242
offset int64 = 0
4343
total int64 = -1
4444
)

0 commit comments

Comments
 (0)