Skip to content

Commit 663f864

Browse files
authored
fix(teo): [117723500]Change the records list type to set (#2680)
* fix: Change the records list type to set * feat: add changelog
1 parent b4089a5 commit 663f864

File tree

5 files changed

+38
-19
lines changed

5 files changed

+38
-19
lines changed

.changelog/2680.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
resource/tencentcloud_clb_instance: Change the record list type to a set to solve the order problem.
3+
```

tencentcloud/services/teo/resource_tc_teo_origin_group.go

Lines changed: 9 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tencentcloud/services/teo/resource_tc_teo_origin_group_test.go

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,19 @@ func TestAccTencentCloudTeoOriginGroup_basic(t *testing.T) {
3030
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "zone_id"),
3131
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "name", "keep-group-1"),
3232
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "type", "GENERAL"),
33-
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "records.#", "1"),
33+
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "records.#", "3"),
3434
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.0.record"),
35-
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "records.0.type", "IP_DOMAIN"),
36-
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "records.0.weight", "100"),
37-
resource.TestCheckResourceAttr("tencentcloud_teo_origin_group.basic", "records.0.private", "false"),
35+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.0.type"),
36+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.0.weight"),
37+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.0.private"),
38+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.1.record"),
39+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.1.type"),
40+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.1.weight"),
41+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.1.private"),
42+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.2.record"),
43+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.2.type"),
44+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.2.weight"),
45+
resource.TestCheckResourceAttrSet("tencentcloud_teo_origin_group.basic", "records.2.private"),
3846
),
3947
},
4048
{
@@ -127,6 +135,18 @@ resource "tencentcloud_teo_origin_group" "basic" {
127135
weight = 100
128136
private = false
129137
}
138+
records {
139+
private = false
140+
record = "21.1.1.1"
141+
type = "IP_DOMAIN"
142+
weight = 100
143+
}
144+
records {
145+
private = false
146+
record = "21.1.1.2"
147+
type = "IP_DOMAIN"
148+
weight = 11
149+
}
130150
}
131151
132152
`

tencentcloud/services/teo/service_tencentcloud_teo.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@ func (me *TeoService) DescribeTeoOriginGroupById(ctx context.Context, originGrou
990990
request := teo.NewDescribeOriginGroupRequest()
991991
advancedFilter := &teo.AdvancedFilter{
992992
Name: helper.String("origin-group-id"),
993-
Values: []*string{&originGroupId},
993+
Values: []*string{helper.String(originGroupId)},
994994
}
995995
request.Filters = append(request.Filters, advancedFilter)
996996

website/docs/r/teo_origin_group.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ resource "tencentcloud_teo_origin_group" "basic" {
4141

4242
The following arguments are supported:
4343

44-
* `records` - (Required, List) Origin site records.
44+
* `records` - (Required, Set) Origin site records.
4545
* `type` - (Required, String) Type of the origin site. Valid values:
4646
- `GENERAL`: Universal origin site group, only supports adding IP/domain name origin sites, which can be referenced by domain name service, rule engine, four-layer proxy, general load balancing, and HTTP-specific load balancing.
4747
- `HTTP`: The HTTP-specific origin site group, supports adding IP/domain name and object storage origin site as the origin site, it cannot be referenced by the four-layer proxy, it can only be added to the acceleration domain name, rule engine-modify origin site, and HTTP-specific load balancing reference.

0 commit comments

Comments
 (0)