Skip to content

Commit 4bc2f67

Browse files
authored
fix: cfs testcase - modify datasource ip and add sweeper (#1159)
1 parent 2c52162 commit 4bc2f67

File tree

2 files changed

+45
-2
lines changed

2 files changed

+45
-2
lines changed

tencentcloud/data_source_tc_cfs_access_rules_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func TestAccTencentCloudCfsAccessRulesDataSource(t *testing.T) {
1919
testAccCheckCfsAccessRuleExists("tencentcloud_cfs_access_rule.foo"),
2020
resource.TestCheckResourceAttrSet("data.tencentcloud_cfs_access_rules.access_rules", "access_rule_list.#"),
2121
resource.TestCheckResourceAttrSet("data.tencentcloud_cfs_access_rules.access_rules", "access_rule_list.0.access_rule_id"),
22-
resource.TestCheckResourceAttr("data.tencentcloud_cfs_access_rules.access_rules", "access_rule_list.0.auth_client_ip", "10.10.1.0/24"),
22+
resource.TestCheckResourceAttr("data.tencentcloud_cfs_access_rules.access_rules", "access_rule_list.0.auth_client_ip", "172.16.16.0/24"),
2323
resource.TestCheckResourceAttr("data.tencentcloud_cfs_access_rules.access_rules", "access_rule_list.0.priority", "1"),
2424
),
2525
},
@@ -31,7 +31,7 @@ const testAccCfsAccessRulesDataSource = defaultCfsAccessGroup + `
3131
3232
resource "tencentcloud_cfs_access_rule" "foo" {
3333
access_group_id = local.cfs_access_group_id
34-
auth_client_ip = "10.10.1.0/24"
34+
auth_client_ip = "172.16.16.0/24"
3535
priority = 1
3636
}
3737

tencentcloud/resource_tc_cfs_file_system_test.go

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,55 @@ package tencentcloud
33
import (
44
"context"
55
"fmt"
6+
"log"
67
"testing"
8+
"time"
79

810
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
911
"github.com/hashicorp/terraform-plugin-sdk/terraform"
1012
)
1113

14+
func init() {
15+
// go test -v ./tencentcloud -sweep=ap-guangzhou -sweep-run=tencentcloud_cfs_file_system
16+
resource.AddTestSweepers("tencentcloud_cfs_file_system", &resource.Sweeper{
17+
Name: "tencentcloud_cfs_file_system",
18+
F: func(r string) error {
19+
logId := getLogId(contextNil)
20+
ctx := context.WithValue(context.TODO(), logIdKey, logId)
21+
cli, _ := sharedClientForRegion(r)
22+
client := cli.(*TencentCloudClient).apiV3Conn
23+
24+
service := CfsService{client}
25+
26+
fsList, err := service.DescribeFileSystem(ctx, "", "", "")
27+
if err != nil {
28+
return err
29+
}
30+
for i := range fsList {
31+
item := fsList[i]
32+
id := *item.FileSystemId
33+
name := *item.FsName
34+
created := time.Time{}
35+
if item.CreationTime != nil {
36+
if result, err := time.Parse(time.RFC3339, *item.CreationTime); err != nil {
37+
created = result
38+
}
39+
}
40+
if isResourcePersist(name, &created) {
41+
continue
42+
}
43+
log.Printf("%s -> %s will be sweep", id, name)
44+
err = service.DeleteFileSystem(ctx, id)
45+
if err != nil {
46+
continue
47+
}
48+
}
49+
50+
return nil
51+
},
52+
})
53+
}
54+
1255
func TestAccTencentCloudCfsFileSystem(t *testing.T) {
1356
t.Parallel()
1457
resource.Test(t, resource.TestCase{

0 commit comments

Comments
 (0)