add param sg (#2482)

* add param sg

* add changelog

Author: hellertang

.changelog/2482.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_vpc_end_point: Support set `security_groups_ids`
+```

tencentcloud/services/pls/resource_tc_vpc_end_point.go

@@ -55,6 +55,14 @@ func ResourceTencentCloudVpcEndPoint() *schema.Resource {
 				Description: "VIP of endpoint ip.",
 			},
 
+			"security_groups_ids": {
+				Optional:    true,
+				Type:        schema.TypeList,
+				Computed:    true,
+				Elem:        &schema.Schema{Type: schema.TypeString},
+				Description: "Ordered security groups associated with the endpoint.",
+			},
+
 			"end_point_owner": {
 				Computed:    true,
 				Type:        schema.TypeString,
@@ -121,10 +129,29 @@ func resourceTencentCloudVpcEndPointCreate(d *schema.ResourceData, meta interfac
 		log.Printf("[CRITAL]%s create vpc endPoint failed, reason:%+v", logId, err)
 		return err
 	}
-
 	endPointId = *response.Response.EndPoint.EndPointId
 	d.SetId(endPointId)
 
+	if v, ok := d.GetOk("security_groups_ids"); ok {
+		request := vpc.NewModifyVpcEndPointAttributeRequest()
+		request.EndPointId = helper.String(endPointId)
+		request.SecurityGroupIds = helper.InterfacesStringsPoint(v.([]interface{}))
+
+		err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
+			result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseVpcClient().ModifyVpcEndPointAttribute(request)
+			if e != nil {
+				return tccommon.RetryError(e)
+			} else {
+				log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
+			}
+			return nil
+		})
+		if err != nil {
+			log.Printf("[CRITAL]%s create vpc endPoint failed, reason:%+v", logId, err)
+			return err
+		}
+
+	}
 	return resourceTencentCloudVpcEndPointRead(d, meta)
 }
 
@@ -182,6 +209,10 @@ func resourceTencentCloudVpcEndPointRead(d *schema.ResourceData, meta interface{
 		_ = d.Set("create_time", endPoint.CreateTime)
 	}
 
+	if endPoint.GroupSet != nil {
+		_ = d.Set("security_groups_ids", endPoint.GroupSet)
+	}
+
 	return nil
 }
 
@@ -209,10 +240,14 @@ func resourceTencentCloudVpcEndPointUpdate(d *schema.ResourceData, meta interfac
 		}
 	}
 
-	if d.HasChange("end_point_name") {
+	if d.HasChange("end_point_name") || d.HasChange("security_groups_ids") {
 		if v, ok := d.GetOk("end_point_name"); ok {
 			request.EndPointName = helper.String(v.(string))
 		}
+
+		if v, ok := d.GetOk("security_groups_ids"); ok {
+			request.SecurityGroupIds = helper.InterfacesStringsPoint(v.([]interface{}))
+		}
 	}
 
 	err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {

tencentcloud/services/pls/resource_tc_vpc_end_point.md

@@ -4,11 +4,17 @@ Example Usage
 
 ```hcl
 resource "tencentcloud_vpc_end_point" "end_point" {
-  vpc_id = "vpc-391sv4w3"
-  subnet_id = "subnet-ljyn7h30"
-  end_point_name = "terraform-test"
+  vpc_id               = "vpc-391sv4w3"
+  subnet_id            = "subnet-ljyn7h30"
+  end_point_name       = "terraform-test"
   end_point_service_id = "vpcsvc-69y13tdb"
-  end_point_vip = "10.0.2.1"
+  end_point_vip        = "10.0.2.1"
+
+  security_groups_ids = [
+    "sg-ghvp9djf",
+    "sg-if748odn",
+    "sg-3k7vtgf7",
+  ]
 }
 ```
 

tencentcloud/services/pls/resource_tc_vpc_end_point_test.go

@@ -18,7 +18,19 @@ func TestAccTencentCloudVpcEndPointResource_basic(t *testing.T) {
 		Steps: []resource.TestStep{
 			{
 				Config: testAccVpcEndPoint,
-				Check:  resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_vpc_end_point.end_point", "id")),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("tencentcloud_vpc_end_point.end_point", "id"),
+					resource.TestCheckResourceAttr("tencentcloud_vpc_end_point.end_point", "end_point_name", "terraform_test"),
+					resource.TestCheckResourceAttr("tencentcloud_vpc_end_point.end_point", "security_groups_ids.0", "sg-ghvp9djf"),
+				),
+			},
+
+			{
+				Config: testAccVpcEndPointUpdate,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("tencentcloud_vpc_end_point.end_point", "end_point_name", "terraform_test_for"),
+					resource.TestCheckResourceAttr("tencentcloud_vpc_end_point.end_point", "security_groups_ids.0", "sg-3k7vtgf7"),
+				),
 			},
 			{
 				ResourceName:      "tencentcloud_vpc_end_point.end_point",
@@ -32,11 +44,33 @@ func TestAccTencentCloudVpcEndPointResource_basic(t *testing.T) {
 const testAccVpcEndPoint = `
 
 resource "tencentcloud_vpc_end_point" "end_point" {
-  vpc_id = "vpc-391sv4w3"
-  subnet_id = "subnet-ljyn7h30"
-  end_point_name = "terraform-test"
-  end_point_service_id = "vpcsvc-98jddhcz"
-  end_point_vip = "10.0.2.2"
+  end_point_name       = "terraform_test"
+  end_point_service_id = "vpcsvc-5y4yb85d"
+  end_point_vip        = "10.0.0.58"
+  security_groups_ids  = [
+    "sg-ghvp9djf",
+    "sg-if748odn",
+    "sg-3k7vtgf7",
+  ]
+  subnet_id = "subnet-cpknsqgo"
+  vpc_id    = "vpc-gmq0mxoj"
+}
+
+`
+
+const testAccVpcEndPointUpdate = `
+
+resource "tencentcloud_vpc_end_point" "end_point" {
+  end_point_name       = "terraform_test_for"
+  end_point_service_id = "vpcsvc-5y4yb85d"
+  end_point_vip        = "10.0.0.58"
+  security_groups_ids  = [
+	"sg-3k7vtgf7",
+    "sg-ghvp9djf",
+    "sg-if748odn",
+  ]
+  subnet_id = "subnet-cpknsqgo"
+  vpc_id    = "vpc-gmq0mxoj"
 }
 
 `

website/docs/r/vpc_end_point.html.markdown

@@ -20,6 +20,12 @@ resource "tencentcloud_vpc_end_point" "end_point" {
   end_point_name       = "terraform-test"
   end_point_service_id = "vpcsvc-69y13tdb"
   end_point_vip        = "10.0.2.1"
+
+  security_groups_ids = [
+    "sg-ghvp9djf",
+    "sg-if748odn",
+    "sg-3k7vtgf7",
+  ]
 }
 ```
 
@@ -32,6 +38,7 @@ The following arguments are supported:
 * `subnet_id` - (Required, String) ID of subnet instance.
 * `vpc_id` - (Required, String) ID of vpc instance.
 * `end_point_vip` - (Optional, String) VIP of endpoint ip.
+* `security_groups_ids` - (Optional, List: [`String`]) Ordered security groups associated with the endpoint.
 
 ## Attributes Reference