lighthouse support isolate_data_disk (#1879)

* lighthouse support isolate_data_disk

* add changelog

---------

Co-authored-by: mikatong <mikatong@tencent.com>

Author: tongyiming

.changelog/1879.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_lighthouse_instance: support param `isolate_data_disk`.
+```

tencentcloud/resource_tc_lighthouse_instance.go

@@ -170,6 +170,12 @@ func resourceTencentCloudLighthouseInstance() *schema.Resource {
 				ValidateFunc: validateAllowedStringValue([]string{"YES", "NO"}),
 				Description:  "Whether to allow login using the default key pair. `YES`: allow login; `NO`: disable login. Default: `YES`.",
 			},
+			"isolate_data_disk": {
+				Type:        schema.TypeBool,
+				Optional:    true,
+				Default:     true,
+				Description: "Whether to return the mounted data disk. `true`: returns both the instance and the mounted data disk; `false`: returns the instance and no longer returns its mounted data disk. Default: `true`.",
+			},
 			"containers": {
 				Type:        schema.TypeList,
 				Optional:    true,
@@ -721,9 +727,10 @@ func resourceTencentCloudLighthouseInstanceDelete(d *schema.ResourceData, meta i
 	ctx := context.WithValue(context.TODO(), logIdKey, logId)
 	service := LightHouseService{client: meta.(*TencentCloudClient).apiV3Conn}
 	id := d.Id()
+	isolateDataDisk := d.Get("isolate_data_disk").(bool)
 
 	err := resource.Retry(writeRetryTimeout, func() *resource.RetryError {
-		if err := service.IsolateLighthouseInstanceById(ctx, id); err != nil {
+		if err := service.IsolateLighthouseInstanceById(ctx, id, isolateDataDisk); err != nil {
 			return retryError(err)
 		}
 		return nil

tencentcloud/resource_tc_lighthouse_instance_test.go

@@ -81,7 +81,7 @@ resource "tencentcloud_lighthouse_instance" "instance" {
 
   instance_name = "terraform"
   zone          = "ap-guangzhou-3"
-
+  isolate_data_disk = true
   containers {
     container_image = "ccr.ccs.tencentyun.com/qcloud/nginx"
     container_name = "nginx"
@@ -152,6 +152,7 @@ resource "tencentcloud_lighthouse_instance" "instance" {
 
   instance_name = "terraform"
   zone          = "ap-guangzhou-3"
+  isolate_data_disk = true
 
   containers {
     container_image = "ccr.ccs.tencentyun.com/qcloud/nginx"

tencentcloud/service_tencentcloud_lighthouse.go

@@ -95,11 +95,12 @@ func (me *LightHouseService) DeleteLighthouseInstanceById(ctx context.Context, i
 	return
 }
 
-func (me *LightHouseService) IsolateLighthouseInstanceById(ctx context.Context, id string) (errRet error) {
+func (me *LightHouseService) IsolateLighthouseInstanceById(ctx context.Context, id string, isolateDataDisk bool) (errRet error) {
 	logId := getLogId(ctx)
 
 	request := lighthouse.NewIsolateInstancesRequest()
 	request.InstanceIds = append(request.InstanceIds, &id)
+	request.IsolateDataDisk = helper.Bool(isolateDataDisk)
 
 	defer func() {
 		if errRet != nil {

website/docs/r/lighthouse_instance.html.markdown

@@ -94,6 +94,7 @@ The following arguments are supported:
 * `containers` - (Optional, List) Configuration of the containers to create.
 * `dry_run` - (Optional, Bool) Whether the request is a dry run only.true: dry run only. The request will not create instance(s). A dry run can check whether all the required parameters are specified, whether the request format is right, whether the request exceeds service limits, and whether the specified CVMs are available. If the dry run fails, the corresponding error code will be returned.If the dry run succeeds, the RequestId will be returned.false (default value): send a normal request and create instance(s) if all the requirements are met.
 * `is_update_bundle_id_auto_voucher` - (Optional, Bool) Whether the voucher is deducted automatically when update bundle id. Value range: `true`: indicates automatic deduction of vouchers, `false`: does not automatically deduct vouchers. Default value: `false`.
+* `isolate_data_disk` - (Optional, Bool) Whether to return the mounted data disk. `true`: returns both the instance and the mounted data disk; `false`: returns the instance and no longer returns its mounted data disk. Default: `true`.
 * `login_configuration` - (Optional, List) Login password of the instance. It is only available for Windows instances. If it is not specified, it means that the user choose to set the login password after the instance creation.
 * `permit_default_key_pair_login` - (Optional, String) Whether to allow login using the default key pair. `YES`: allow login; `NO`: disable login. Default: `YES`.
 * `zone` - (Optional, String) List of availability zones. A random AZ is selected by default.