Merge pull request #1641 from tencentcloudstack/feat/support_modify_auth

redis support modify auth

Author: lyu571

.changelog/1641.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_redis_instance:  `no_auth` support modify.
+```

tencentcloud/resource_tc_redis_instance.go

@@ -163,7 +163,6 @@ func resourceTencentCloudRedisInstance() *schema.Resource {
 			"no_auth": {
 				Type:        schema.TypeBool,
 				Optional:    true,
-				ForceNew:    true,
 				Description: "Indicates whether the redis instance support no-auth access. NOTE: Only available in private cloud environment.",
 			},
 			"replicas_read_only": {
@@ -753,16 +752,17 @@ func resourceTencentCloudRedisInstanceUpdate(d *schema.ResourceData, meta interf
 		}
 	}
 
-	if d.HasChange("password") {
+	if d.HasChange("password") || d.HasChange("no_auth") {
 		var (
 			taskId   int64
 			password = d.Get("password").(string)
+			noAuth   = d.Get("no_auth").(bool)
 			err      error
 		)
 
 		// After redis spec modified, reset password may not successfully response immediately.
 		err = resource.Retry(writeRetryTimeout, func() *resource.RetryError {
-			taskId, err = redisService.ResetPassword(ctx, id, password)
+			taskId, err = redisService.ResetPassword(ctx, id, password, noAuth)
 			if err != nil {
 				log.Printf("[CRITAL]%s redis change password error, reason:%s\n", logId, err.Error())
 				return retryError(err, redis.FAILEDOPERATION_SYSTEMERROR)

tencentcloud/resource_tc_redis_instance_test.go

@@ -137,7 +137,7 @@ func init() {
 	})
 }
 
-func TestAccTencentCloudRedisInstanceBasic(t *testing.T) {
+func TestAccTencentCloudRedisInstanceResource_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
@@ -562,6 +562,7 @@ resource "tencentcloud_redis_instance" "redis_instance_test" {
   redis_replicas_num = 1
   vpc_id 			 = var.vpc_id
   subnet_id			 = var.subnet_id
+  no_auth            = true
   security_groups    = [var.sg_id]
 
   tags = {

tencentcloud/service_tencentcloud_redis.go

@@ -844,12 +844,13 @@ func (me *RedisService) DescribeTaskInfo(ctx context.Context, redisId string, ta
 	return
 }
 
-func (me *RedisService) ResetPassword(ctx context.Context, redisId string, newPassword string) (taskId int64, errRet error) {
+func (me *RedisService) ResetPassword(ctx context.Context, redisId string, newPassword string, noAuth bool) (taskId int64, errRet error) {
 	logId := getLogId(ctx)
 
 	request := redis.NewResetPasswordRequest()
 	request.InstanceId = &redisId
 	request.Password = &newPassword
+	request.NoAuth = &noAuth
 	defer func() {
 		if errRet != nil {
 			log.Printf("[CRITAL]%s api[%s] fail, request body [%s], reason[%s]\n",

website/docs/r/redis_instance.html.markdown

@@ -77,7 +77,7 @@ The following arguments are supported:
 * `charge_type` - (Optional, String, ForceNew) The charge type of instance. Valid values: `PREPAID` and `POSTPAID`. Default value is `POSTPAID`. Note: TencentCloud International only supports `POSTPAID`. Caution that update operation on this field will delete old instances and create new with new charge type.
 * `force_delete` - (Optional, Bool) Indicate whether to delete Redis instance directly or not. Default is false. If set true, the instance will be deleted instead of staying recycle bin. Note: only works for `PREPAID` instance.
 * `name` - (Optional, String) Instance name.
-* `no_auth` - (Optional, Bool, ForceNew) Indicates whether the redis instance support no-auth access. NOTE: Only available in private cloud environment.
+* `no_auth` - (Optional, Bool) Indicates whether the redis instance support no-auth access. NOTE: Only available in private cloud environment.
 * `params_template_id` - (Optional, String) Specify params template id. If not set, will use default template.
 * `password` - (Optional, String) Password for a Redis user, which should be 8 to 16 characters. NOTE: Only `no_auth=true` specified can make password empty.
 * `port` - (Optional, Int, ForceNew) The port used to access a redis instance. The default value is 6379. And this value can't be changed after creation, or the Redis instance will be recreated.