fix: sqlserver testcases (#986)

Author: Kagashino

tencentcloud/data_source_tc_sqlserver_account_db_attachments_test.go

@@ -28,22 +28,18 @@ func TestAccDataSourceTencentCloudSqlserverAccountDBAttachments(t *testing.T) {
 	})
 }
 
-const testAccTencentCloudDataSqlserverAccountDBAttachmentsBasic = testAccSqlserverInstance + `
-resource "tencentcloud_sqlserver_account" "test" {
-  instance_id = tencentcloud_sqlserver_instance.test.id
-  name = "tf_sqlserver_account"
-  password = "testt123"
-}
+const testAccTencentCloudDataSqlserverAccountDBAttachmentsBasic = CommonPresetSQLServerAccount + `
+
 resource "tencentcloud_sqlserver_db" "test" {
   instance_id = tencentcloud_sqlserver_instance.test.id
-  name        = "test111"
+  name        = "test_db_attachment"
   charset     = "Chinese_PRC_BIN"
   remark      = "testACC-remark"
 }
 
 resource "tencentcloud_sqlserver_account_db_attachment" "test" {
   instance_id = tencentcloud_sqlserver_instance.test.id
-  account_name = tencentcloud_sqlserver_account.test.name
+  account_name = local.sqlserver_account
   db_name = tencentcloud_sqlserver_db.test.name
   privilege = "ReadWrite"
 }

tencentcloud/data_source_tc_sqlserver_accounts_test.go

@@ -18,7 +18,7 @@ func TestAccDataSourceTencentCloudSqlserverAccounts(t *testing.T) {
 			{
 				Config: testAccTencentCloudDataSqlserverAccountsBasic,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(testDataSqlserverAccountsName, "list.#", "1"),
+					resource.TestCheckResourceAttrSet(testDataSqlserverAccountsName, "list.#"),
 					resource.TestCheckResourceAttrSet(testDataSqlserverAccountsName, "list.0.status"),
 					resource.TestCheckResourceAttrSet(testDataSqlserverAccountsName, "list.0.create_time"),
 					resource.TestCheckResourceAttrSet(testDataSqlserverAccountsName, "list.0.update_time"),
@@ -29,14 +29,4 @@ func TestAccDataSourceTencentCloudSqlserverAccounts(t *testing.T) {
 	})
 }
 
-const testAccTencentCloudDataSqlserverAccountsBasic = testAccSqlserverInstance + `
-resource "tencentcloud_sqlserver_account" "test" {
-  instance_id = tencentcloud_sqlserver_instance.test.id
-  name = "tf_sqlserver_account1"
-  password = "testt123"
-}
-data "tencentcloud_sqlserver_accounts" "test"{
-  instance_id = tencentcloud_sqlserver_instance.test.id
-  name = tencentcloud_sqlserver_account.test.name	
-}
-`
+const testAccTencentCloudDataSqlserverAccountsBasic = CommonPresetSQLServerAccount

tencentcloud/resource_tc_sqlserver_instance_test.go

@@ -180,7 +180,6 @@ func TestAccTencentCloudSqlserverInstanceResource_PostPaid(t *testing.T) {
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"multi_zones", "auto_voucher"},
 			},
-
 			{
 				Config: testAccSqlserverInstanceUpdate,
 				Check: resource.ComposeTestCheckFunc(
@@ -198,7 +197,7 @@ func TestAccTencentCloudSqlserverInstanceResource_PostPaid(t *testing.T) {
 					resource.TestCheckResourceAttrSet(testSqlserverInstanceResourceKey, "vip"),
 					resource.TestCheckResourceAttrSet(testSqlserverInstanceResourceKey, "vport"),
 					resource.TestCheckResourceAttrSet(testSqlserverInstanceResourceKey, "status"),
-					resource.TestCheckResourceAttr(testSqlserverInstanceResourceKey, "security_groups.#", "0"),
+					resource.TestCheckResourceAttr(testSqlserverInstanceResourceKey, "security_groups.#", "1"),
 					//resource.TestCheckNoResourceAttr(testSqlserverInstanceResourceKey, "tags.test"),
 					//resource.TestCheckResourceAttr(testSqlserverInstanceResourceKey, "tags.abc", "abc"),
 				),
@@ -339,7 +338,6 @@ data "tencentcloud_vpc_instances" "vpc" {
 
 data "tencentcloud_security_group" "group" {}
 
-
 data "tencentcloud_subnet" "sub" {
   vpc_id = local.vpc_id
   subnet_id = local.vpc_subnet_id
@@ -428,7 +426,6 @@ resource "tencentcloud_sqlserver_instance" "test" {
   engine_version                = "2017"
   charge_type                   = "POSTPAID_BY_HOUR"
   availability_zone             = var.default_az
-  charge_type                   = "POSTPAID_BY_HOUR"
   vpc_id                        = local.vpc_id
   subnet_id                     = local.subnet_id
   security_groups               = [local.sg_id]

tencentcloud/resource_tc_sqlserver_publish_subscribe_test.go

@@ -125,7 +125,7 @@ resource "tencentcloud_sqlserver_instance" "subscribe_instance" {
   maintenance_week_set      = [1,2,3]
   maintenance_start_time    = "09:00"
   maintenance_time_span     = 3
-  security_groups           = [tencentcloud_security_group.foo.name]
+  security_groups           = [local.sg_id]
 }
 
 resource "tencentcloud_sqlserver_db" "test_publish_subscribe" {
@@ -158,7 +158,7 @@ resource "tencentcloud_sqlserver_instance" "publish_instance" {
   maintenance_week_set          = [1,2,3]
   maintenance_start_time        = "09:00"
   maintenance_time_span         = 3
-  security_groups               = [tencentcloud_security_group.foo.name]
+  security_groups               = [local.sg_id]
 }
 
 resource "tencentcloud_sqlserver_instance" "subscribe_instance" {
@@ -173,7 +173,7 @@ resource "tencentcloud_sqlserver_instance" "subscribe_instance" {
   maintenance_week_set          = [1,2,3]
   maintenance_start_time        = "09:00"
   maintenance_time_span         = 3
-  security_groups               = [tencentcloud_security_group.foo.name]
+  security_groups               = [local.sg_id]
 }
 
 resource "tencentcloud_sqlserver_db" "test_publish_subscribe" {