ckafka support set instance type (#1589)

* ckafka support set instance type

* add changelog

Author: hellertang

.changelog/1589.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_ckafka_instance: support set `instance_type`
+```

tencentcloud/extension_ckafka.go

@@ -5,6 +5,18 @@ const (
 	CKAFKA_ACL_PRINCIPAL_STR = "User:"
 )
 
+var CKAFKA_INSTANCE_TYPE = map[string]int64{
+	"general":       1,
+	"standard":      2,
+	"advanced":      3,
+	"capacity":      4,
+	"specialized-1": 5,
+	"specialized-2": 6,
+	"specialized-3": 7,
+	"specialized-4": 8,
+	"exclusive":     9,
+}
+
 var CKAFKA_ACL_RESOURCE_TYPE = map[string]int64{
 	"UNKNOWN":          0,
 	"ANY":              1,

tencentcloud/resource_tc_ckafka_instance.go

@@ -108,6 +108,13 @@ func resourceTencentCloudCkafkaInstance() *schema.Resource {
 				Optional:    true,
 				Description: "Prepaid purchase time, such as 1, is one month.",
 			},
+			"instance_type": {
+				Type:         schema.TypeInt,
+				Optional:     true,
+				Computed:     true,
+				ValidateFunc: validateAllowedIntValue([]int{1, 2, 3, 4, 5, 6, 7, 8, 9}),
+				Description:  "Description of instance type. `profession`: 1, `standard`:  1(general), 2(standard), 3(advanced), 4(capacity), 5(specialized-1), 6(specialized-2), 7(specialized-3), 8(specialized-4), 9(exclusive).",
+			},
 			"vpc_id": {
 				Type:        schema.TypeString,
 				Optional:    true,
@@ -317,6 +324,10 @@ func resourceTencentCloudCkafkaInstanceCreate(d *schema.ResourceData, meta inter
 	request.Period = helper.String(fmt.Sprintf("%dm", period))
 	request.InstanceType = helper.IntInt64(1)
 
+	if v, ok := d.GetOkExists("instance_type"); ok {
+		request.InstanceType = helper.IntInt64(v.(int))
+	}
+
 	if v, ok := d.GetOk("specifications_type"); ok {
 		request.SpecificationsType = helper.String(v.(string))
 	}
@@ -551,8 +562,10 @@ func resourceTencentCloudCkafkaInstanceRead(d *schema.ResourceData, meta interfa
 	_ = d.Set("partition", info.MaxPartitionNumber)
 	if *info.InstanceType == "profession" {
 		_ = d.Set("specifications_type", "profession")
+		_ = d.Set("instance_type", 1)
 	} else {
 		_ = d.Set("specifications_type", "standard")
+		_ = d.Set("instance_type", CKAFKA_INSTANCE_TYPE[*info.InstanceType])
 	}
 
 	if len(info.ZoneIds) > 1 {
@@ -642,7 +655,7 @@ func resourceTencentCloudCkafkaInstanceUpdate(d *schema.ResourceData, meta inter
 		"zone_id", "period", "vpc_id",
 		"subnet_id", "renew_flag", "kafka_version",
 		"multi_zone_flag", "zone_ids", "disk_type",
-		"specifications_type",
+		"specifications_type", "instance_type",
 	}
 
 	for _, v := range immutableArgs {

tencentcloud/resource_tc_ckafka_instance_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccTencentCloudCkafkaInstance(t *testing.T) {
+func TestAccTencentCloudCkafkaInstanceResource(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheckCommon(t, ACCOUNT_TYPE_PREPAY) },
@@ -56,7 +56,7 @@ func TestAccTencentCloudCkafkaInstance(t *testing.T) {
 	})
 }
 
-func TestAccTencentCloudKafkaInstanceMAZ(t *testing.T) {
+func TestAccTencentCloudCkafkaInstanceMAZResource(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheckCommon(t, ACCOUNT_TYPE_PREPAY) },
@@ -82,6 +82,32 @@ func TestAccTencentCloudKafkaInstanceMAZ(t *testing.T) {
 	})
 }
 
+func TestAccTencentCloudCkafkaInstanceTypeResource(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheckCommon(t, ACCOUNT_TYPE_PREPAY) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccTencentCloudKafkaInstanceDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccKafkaInstanceType,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckKafkaInstanceExists("tencentcloud_ckafka_instance.kafka_instance"),
+					resource.TestCheckResourceAttr("tencentcloud_ckafka_instance.kafka_instance", "instance_name", "ckafka-instance-type-tf-test"),
+					resource.TestCheckResourceAttr("tencentcloud_ckafka_instance.kafka_instance", "specifications_type", "standard"),
+					resource.TestCheckResourceAttr("tencentcloud_ckafka_instance.kafka_instance", "instance_type", "2"),
+				),
+			},
+			{
+				ResourceName:            "tencentcloud_ckafka_instance.kafka_instance",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"period"},
+			},
+		},
+	})
+}
+
 func testAccTencentCloudKafkaInstanceDestroy(s *terraform.State) error {
 	logId := getLogId(contextNil)
 	ctx := context.WithValue(context.TODO(), logIdKey, logId)
@@ -211,6 +237,35 @@ resource "tencentcloud_ckafka_instance" "kafka_instance" {
   disk_type          = "CLOUD_BASIC"
 
 
+  config {
+    auto_create_topic_enable   = true
+    default_num_partitions     = 3
+    default_replication_factor = 3
+  }
+
+  dynamic_retention_config {
+    enable = 1
+  }
+}
+`
+
+const testAccKafkaInstanceType = defaultKafkaVariable + `
+resource "tencentcloud_ckafka_instance" "kafka_instance" {
+  instance_name      = "ckafka-instance-type-tf-test"
+  zone_id            = 100003
+  period             = 1
+  vpc_id             = var.vpc_id
+  subnet_id          = var.subnet_id
+  msg_retention_time = 1300
+  renew_flag         = 0
+  kafka_version      = "1.1.1"
+  disk_size          = 1000
+  disk_type          = "CLOUD_BASIC"
+
+  specifications_type = "standard"
+  instance_type       = 2
+
+
   config {
     auto_create_topic_enable   = true
     default_num_partitions     = 3

website/docs/r/ckafka_instance.html.markdown

@@ -63,6 +63,7 @@ The following arguments are supported:
 * `disk_size` - (Optional, Int) Disk Size. Its interval varies with bandwidth, and the input must be within the interval, which can be viewed through the control. If it is not within the interval, the plan will cause a change when first created.
 * `disk_type` - (Optional, String) Type of disk.
 * `dynamic_retention_config` - (Optional, List) Dynamic message retention policy configuration.
+* `instance_type` - (Optional, Int) Description of instance type. `profession`: 1, `standard`:  1(general), 2(standard), 3(advanced), 4(capacity), 5(specialized-1), 6(specialized-2), 7(specialized-3), 8(specialized-4), 9(exclusive).
 * `kafka_version` - (Optional, String) Kafka version (0.10.2/1.1.1/2.4.1).
 * `msg_retention_time` - (Optional, Int) The maximum retention time of instance logs, in minutes. the default is 10080 (7 days), the maximum is 30 days, and the default 0 is not filled, which means that the log retention time recovery policy is not enabled.
 * `multi_zone_flag` - (Optional, Bool) Indicates whether the instance is multi zones. NOTE: if set to `true`, `zone_ids` must set together.