fix: support IP query when modifying the type (#1520)

* fix: support IP query when modifying the type

* fix: add changelog

Co-authored-by: anonymous <anonymous@mail.org>

Author: gitmkn

.changelog/1520.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_ckafka_instance: support IP query when modifying the type
+```

tencentcloud/resource_tc_tem_application_service.go

@@ -394,6 +394,22 @@ func resourceTencentCloudTemApplicationServiceUpdate(d *schema.ResourceData, met
 		return err
 	}
 
+	ctx := context.WithValue(context.TODO(), logIdKey, logId)
+	service := TemService{client: meta.(*TencentCloudClient).apiV3Conn}
+	err = resource.Retry(3*readRetryTimeout, func() *resource.RetryError {
+		service, errRet := service.DescribeTemApplicationServiceById(ctx, environmentId, applicationId)
+		if errRet != nil {
+			return retryError(errRet, InternalError)
+		}
+		if *service.Result.AllIpDone {
+			return nil
+		}
+		return resource.RetryableError(fmt.Errorf("service is not ready %v, retry...", *service.Result.AllIpDone))
+	})
+	if err != nil {
+		return err
+	}
+
 	return resourceTencentCloudTemApplicationServiceRead(d, meta)
 }
 

tencentcloud/resource_tc_tem_application_service_test.go

@@ -30,6 +30,23 @@ func TestAccTencentCloudTemApplicationServiceResource_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.#", "1"),
 					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.type", "CLUSTER"),
 					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.service_name", "terraform-test-0"),
+					resource.TestCheckResourceAttrSet("tencentcloud_tem_application_service.application_service", "service.0.ip"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.0.port", "80"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.0.target_port", "80"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.0.protocol", "TCP"),
+				),
+			},
+			{
+				Config: testAccTemApplicationServiceUp,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckTemApplicationServiceExists("tencentcloud_tem_application_service.application_service"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "environment_id", defaultEnvironmentId),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "application_id", defaultApplicationId),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.#", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.type", "EXTERNAL"),
+					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.service_name", "terraform-test-0"),
+					resource.TestCheckResourceAttrSet("tencentcloud_tem_application_service.application_service", "service.0.ip"),
 					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.#", "1"),
 					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.0.port", "80"),
 					resource.TestCheckResourceAttr("tencentcloud_tem_application_service.application_service", "service.0.port_mapping_item_list.0.target_port", "80"),
@@ -143,3 +160,21 @@ resource "tencentcloud_tem_application_service" "application_service" {
 }
 
 `
+
+const testAccTemApplicationServiceUp = testAccTemApplicationServiceVar + `
+
+resource "tencentcloud_tem_application_service" "application_service" {
+	environment_id = var.environment_id
+	application_id = var.application_id
+	service {
+		type = "EXTERNAL"
+		service_name = "terraform-test-0"
+		port_mapping_item_list {
+			port = 80
+			target_port = 80
+			protocol = "TCP"
+		}
+	}
+}
+
+`