feat/ssm

Author: SevenEarth

tencentcloud/data_source_tc_ssm_products.go

@@ -22,14 +22,11 @@ func dataSourceTencentCloudSsmProducts() *schema.Resource {
 		Read: dataSourceTencentCloudSsmProductsRead,
 		Schema: map[string]*schema.Schema{
 			"products": {
-				Computed: true,
-				Type:     schema.TypeSet,
-				Elem: &schema.Schema{
-					Type: schema.TypeString,
-				},
+				Computed:    true,
+				Type:        schema.TypeSet,
+				Elem:        &schema.Schema{Type: schema.TypeString},
 				Description: "List of supported services.",
 			},
-
 			"result_output_file": {
 				Type:        schema.TypeString,
 				Optional:    true,
@@ -43,37 +40,38 @@ func dataSourceTencentCloudSsmProductsRead(d *schema.ResourceData, meta interfac
 	defer logElapsed("data_source.tencentcloud_ssm_products.read")()
 	defer inconsistentCheck(d, meta)()
 
-	logId := getLogId(contextNil)
-
-	ctx := context.WithValue(context.TODO(), logIdKey, logId)
-
-	service := SsmService{client: meta.(*TencentCloudClient).apiV3Conn}
-
-	var products []*string
+	var (
+		logId    = getLogId(contextNil)
+		ctx      = context.WithValue(context.TODO(), logIdKey, logId)
+		service  = SsmService{client: meta.(*TencentCloudClient).apiV3Conn}
+		products []*string
+	)
 
 	err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
 		result, e := service.DescribeSsmProductsByFilter(ctx)
 		if e != nil {
 			return retryError(e)
 		}
+
 		products = result
 		return nil
 	})
+
 	if err != nil {
 		return err
 	}
 
 	if products != nil {
 		_ = d.Set("products", products)
 	}
-	ids := helper.StrListToStr(products)
 
-	d.SetId(ids)
+	d.SetId(helper.StrListToStr(products))
 	output, ok := d.GetOk("result_output_file")
 	if ok && output.(string) != "" {
 		if e := writeToFile(output.(string), products); e != nil {
 			return e
 		}
 	}
+
 	return nil
 }

tencentcloud/data_source_tc_ssm_products_test.go

@@ -6,6 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
+// go test -i; go test -test.run TestAccTencentCloudSsmProductsDataSource_basic -v
 func TestAccTencentCloudSsmProductsDataSource_basic(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{
@@ -16,13 +17,14 @@ func TestAccTencentCloudSsmProductsDataSource_basic(t *testing.T) {
 		Steps: []resource.TestStep{
 			{
 				Config: testAccSsmProductsDataSource,
-				Check:  resource.ComposeTestCheckFunc(testAccCheckTencentCloudDataSourceID("data.tencentcloud_ssm_products.products")),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckTencentCloudDataSourceID("data.tencentcloud_ssm_products.products"),
+				),
 			},
 		},
 	})
 }
 
 const testAccSsmProductsDataSource = `
-
 data "tencentcloud_ssm_products" "products" {}
 `