misc: use const var

Author: xawei

tencentcloud/extension_tke.go

@@ -124,3 +124,11 @@ var TKE_ADDON_DEFAULT_VALUES_KEY = []string{
 const (
 	InstallSecurityAgentCommandId = "cmd-d8jj2skv"
 )
+
+const (
+	TKE_CLUSTER_INTERNET = true
+	TKE_CLUSTER_INTRANET = false
+
+	TKE_CLUSTER_OPEN_ACCESS  = true
+	TKE_CLUSTER_CLOSE_ACCESS = false
+)

tencentcloud/resource_tc_kubernetes_cluster.go

@@ -2635,15 +2635,15 @@ func resourceTencentCloudTkeClusterUpdate(d *schema.ResourceData, meta interface
 	}
 
 	if d.HasChange("cluster_intranet") {
-		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, false, clusterIntranet, clusterInternetSecurityGroup, intranetSubnetId, clusterIntranetDomain); err != nil {
+		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, TKE_CLUSTER_INTRANET, clusterIntranet, clusterInternetSecurityGroup, intranetSubnetId, clusterIntranetDomain); err != nil {
 			return err
 		}
 
 		d.SetPartial("cluster_intranet")
 	}
 
 	if d.HasChange("cluster_internet") {
-		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, true, clusterInternet, clusterInternetSecurityGroup, "", clusterInternetDomain); err != nil {
+		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, TKE_CLUSTER_INTERNET, clusterInternet, clusterInternetSecurityGroup, "", clusterInternetDomain); err != nil {
 			return err
 		}
 	}
@@ -2652,22 +2652,22 @@ func resourceTencentCloudTkeClusterUpdate(d *schema.ResourceData, meta interface
 	if !d.HasChange("cluster_intranet") && clusterIntranet && d.HasChange("cluster_intranet_domain") {
 		// recreate the cluster intranet endpoint using new domain
 		// first close
-		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, false, false, clusterInternetSecurityGroup, intranetSubnetId, clusterIntranetDomain); err != nil {
+		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, TKE_CLUSTER_INTRANET, TKE_CLUSTER_CLOSE_ACCESS, clusterInternetSecurityGroup, intranetSubnetId, clusterIntranetDomain); err != nil {
 			return err
 		}
 		// then reopen
-		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, false, true, clusterInternetSecurityGroup, intranetSubnetId, clusterIntranetDomain); err != nil {
+		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, TKE_CLUSTER_INTRANET, TKE_CLUSTER_OPEN_ACCESS, clusterInternetSecurityGroup, intranetSubnetId, clusterIntranetDomain); err != nil {
 			return err
 		}
 	}
 	if !d.HasChange("cluster_internet") && clusterInternet && d.HasChange("cluster_internet_domain") {
 		// recreate the cluster internet endpoint using new domain
 		// first close
-		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, true, false, clusterInternetSecurityGroup, "", clusterInternetDomain); err != nil {
+		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, TKE_CLUSTER_INTERNET, TKE_CLUSTER_CLOSE_ACCESS, clusterInternetSecurityGroup, "", clusterInternetDomain); err != nil {
 			return err
 		}
 		// then reopen
-		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, true, true, clusterInternetSecurityGroup, "", clusterInternetDomain); err != nil {
+		if err := ModifyClusterInternetOrIntranetAccess(ctx, d, &tkeService, TKE_CLUSTER_INTERNET, TKE_CLUSTER_OPEN_ACCESS, clusterInternetSecurityGroup, "", clusterInternetDomain); err != nil {
 			return err
 		}
 	}

tencentcloud/resource_tc_kubernetes_cluster_test.go

@@ -78,6 +78,8 @@ func TestAccTencentCloudKubernetesClusterResourceBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "auto_upgrade_cluster_level", "true"),
 					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "labels.test1", "test1"),
 					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "labels.test2", "test2"),
+					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "cluster_internet_domain", "tf.cluster-internet.com"),
+					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "cluster_intranet_domain", "tf.cluster-intranet.com"),
 				),
 			},
 			{
@@ -87,6 +89,7 @@ func TestAccTencentCloudKubernetesClusterResourceBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "cluster_name", "test2"),
 					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "cluster_desc", "test cluster desc 2"),
 					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "cluster_level", "L5"),
+					resource.TestCheckResourceAttr(testTkeClusterResourceKey, "cluster_internet_domain", "tf2.cluster-internet.com"),
 				),
 			},
 			{
@@ -356,7 +359,9 @@ resource "tencentcloud_kubernetes_cluster" "managed_cluster" {
   cluster_desc                               = "test cluster desc"
   cluster_max_service_num                    = 32
   cluster_internet                           = true
+  cluster_internet_domain                    = "tf.cluster-internet.com"
   cluster_intranet                           = true
+  cluster_intranet_domain                    = "tf.cluster-intranet.com"
   cluster_version                            = "1.18.4"
   cluster_os                                 = "tlinux2.2(tkernel3)x86_64"
   cluster_level								 = "L5"
@@ -423,6 +428,7 @@ resource "tencentcloud_kubernetes_cluster" "managed_cluster" {
   cluster_desc                               = "test cluster desc 2"
   cluster_max_service_num                    = 32
   cluster_internet                           = true
+  cluster_internet_domain                    = "tf2.cluster-internet.com"
   cluster_intranet                           = false
   cluster_version                            = "1.18.4"
   cluster_os                                 = "tlinux2.2(tkernel3)x86_64"