fix: mysql - 8.0 lowercase ignore and fix testcases (#972)

Author: Kagashino

tencentcloud/resource_tc_mysql_account_test.go

@@ -3,15 +3,80 @@ package tencentcloud
 import (
 	"context"
 	"fmt"
+	"log"
 	"strings"
 	"testing"
+	"time"
+
+	"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 	cdb "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/cdb/v20170320"
 	sdkError "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common/errors"
 )
 
+func init() {
+	// go test -v ./tencentcloud -sweep=ap-guangzhou -sweep-run=tencentcloud_mysql_account
+	resource.AddTestSweepers("tencentcloud_mysql_account", &resource.Sweeper{
+		Name: "tencentcloud_mysql_account",
+		F: func(r string) error {
+			logId := getLogId(contextNil)
+			ctx := context.WithValue(context.TODO(), logIdKey, logId)
+			cli, _ := sharedClientForRegion(r)
+			client := cli.(*TencentCloudClient).apiV3Conn
+
+			service := MysqlService{client}
+
+			request := cdb.NewDescribeDBInstancesRequest()
+			request.InstanceNames = []*string{
+				helper.String(defaultMySQLName),
+			}
+			response, err := client.UseMysqlClient().DescribeDBInstances(request)
+			if err != nil {
+				log.Printf("[CRITICAL] [%s] fail, request: %s, reason: %s", request.GetAction(), request.ToJsonString(), err.Error())
+				return err
+			}
+
+			if len(response.Response.Items) == 0 {
+				return nil
+			}
+
+			instance := response.Response.Items[0]
+			id := instance.InstanceId
+
+			accounts, err := service.DescribeAccounts(ctx, *id)
+
+			if err != nil {
+				return err
+			}
+
+			for i := range accounts {
+				item := accounts[i]
+				name := *item.User
+				host := *item.Host
+				created, err := time.Parse(time.RFC3339, *item.CreateTime)
+				if err != nil {
+					created = time.Time{}
+				}
+				if isResourcePersist(name, &created) {
+					continue
+				}
+				if !strings.Contains(name, "test") {
+					continue
+				}
+				log.Printf("Will delete %s %s@%s", *id, name, host)
+				_, err = service.DeleteAccount(ctx, *id, name, host)
+				if err != nil {
+					continue
+				}
+			}
+
+			return nil
+		},
+	})
+}
+
 func TestAccTencentCloudMysqlAccountResource(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{

tencentcloud/resource_tc_mysql_instance.go

@@ -624,12 +624,18 @@ func resourceTencentCloudMysqlInstanceCreate(d *schema.ResourceData, meta interf
 
 	// Initialize mysql instance
 	var (
+		version   = d.Get("engine_version").(string)
 		password  = d.Get("root_password").(string)
 		charset   = d.Get("parameters.character_set_server").(string)
 		lowercase = d.Get("parameters.lower_case_table_names").(string)
 		vPort     int
 	)
 
+	// 8.0 does not support lower_case_table_names modified, skip this params
+	if version == "8.0" {
+		lowercase = ""
+	}
+
 	port, portOk := d.GetOk("intranet_port")
 
 	if portOk && port.(int) != 0 {

tencentcloud/resource_tc_mysql_instance_test.go

@@ -97,7 +97,6 @@ func testSweepMySQLInstance(region string) error {
 }
 
 func TestAccTencentCloudMysqlMasterInstance_fullslave(t *testing.T) {
-	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
@@ -120,7 +119,6 @@ func TestAccTencentCloudMysqlMasterInstance_fullslave(t *testing.T) {
 }
 
 func TestAccTencentCloudMysqlMasterInstance_basic_and_update(t *testing.T) {
-	t.Parallel()
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,

tencentcloud/resource_tc_mysql_privilege_test.go

@@ -186,7 +186,7 @@ func testAccMysqlPrivilege() string {
 %s
 resource "tencentcloud_mysql_account" "mysql_account" {
   mysql_id    = local.mysql_id
-  name        = "test11"
+  name        = "test11priv"
   host        = "119.168.110.%%"
   password    = "test1234"
   description = "test from terraform"
@@ -220,7 +220,7 @@ func testAccMysqlPrivilegeUpdate() string {
 %s
 resource "tencentcloud_mysql_account" "mysql_account" {
   mysql_id    = local.mysql_id
-  name        = "test11"
+  name        = "test11priv"
   host        = "119.168.110.%%"
   password    = "test1234"
   description = "test from terraform"