add network configuration check when creating tke cluster (#2469)

* add network configuration check when creating tke cluster

* add changelog 2469.txt

* delete mps DescribeTaskDetail

Author: bruceybian

.changelog/2469.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_kubernetes_cluster: add `cluster_internet` and `cluster_intranet` configuration check
+```

tencentcloud/services/mps/service_tencentcloud_mps.go

@@ -940,31 +940,6 @@ func (me *MpsService) DeleteMpsEventById(ctx context.Context, eventId string) (e
 	return
 }
 
-func (me *MpsService) DescribeMpsTaskDetailById(ctx context.Context, taskId string) (manageTaskOperation *mps.DescribeTaskDetailResponseParams, errRet error) {
-	logId := tccommon.GetLogId(ctx)
-
-	request := mps.NewDescribeTaskDetailRequest()
-	request.TaskId = &taskId
-
-	defer func() {
-		if errRet != nil {
-			log.Printf("[CRITAL]%s api[%s] fail, request body [%s], reason[%s]\n", logId, request.GetAction(), request.ToJsonString(), errRet.Error())
-		}
-	}()
-
-	ratelimit.Check(request.GetAction())
-
-	response, err := me.client.UseMpsClient().DescribeTaskDetail(request)
-	if err != nil {
-		errRet = err
-		return
-	}
-	log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
-
-	manageTaskOperation = response.Response
-	return
-}
-
 func (me *MpsService) DeleteMpsOutputById(ctx context.Context, flowId, outputId string) (errRet error) {
 	logId := tccommon.GetLogId(ctx)
 

tencentcloud/services/tke/resource_tc_kubernetes_cluster.go

@@ -1538,6 +1538,12 @@ func resourceTencentCloudTkeClusterCreate(d *schema.ResourceData, meta interface
 		return fmt.Errorf("`cluster_intranet_subnet_id` can only set when `cluster_intranet` is true")
 	}
 
+	_, workerConfigOk := d.GetOk("worker_config")
+	if !workerConfigOk && (clusterInternet || clusterIntranet) {
+		return fmt.Errorf("when creating a cluster, if `cluster_internet` or `cluster_intranet` is true, " +
+			"you need to configure the `worker_config` field to ensure that there are available nodes in the cluster")
+	}
+
 	vpcId := d.Get("vpc_id").(string)
 	if vpcId != "" {
 		basic.VpcId = vpcId

tencentcloud/services/tke/service_tencentcloud_tke.go

@@ -829,6 +829,7 @@ func (me *TkeService) CreateClusterInstances(ctx context.Context,
 }
 
 func (me *TkeService) CheckOneOfClusterNodeReady(ctx context.Context, clusterId string, mustHaveWorkers bool) error {
+	logId := tccommon.GetLogId(ctx)
 	return resource.Retry(tccommon.ReadRetryTimeout*5, func() *resource.RetryError {
 		_, workers, err := me.DescribeClusterInstances(ctx, clusterId)
 		if err != nil {
@@ -843,6 +844,8 @@ func (me *TkeService) CheckOneOfClusterNodeReady(ctx context.Context, clusterId
 
 		if len(workers) == 0 && len(virtualNodes) == 0 {
 			if mustHaveWorkers {
+				log.Printf("[WARN]%s waiting for workers in the cluster[%s] to be created.\n",
+					logId, clusterId)
 				return resource.RetryableError(fmt.Errorf("waiting for workers created"))
 			}
 			return nil