fix cam group modify (#2232)

* fix cam group modify

* add changelog

Author: hellertang

.changelog/2232.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/tencentcloud_cam_group: fix cam group modify error
+```

tencentcloud/resource_tc_cam_group.go

@@ -184,17 +184,21 @@ func resourceTencentCloudCamGroupUpdate(d *schema.ResourceData, meta interface{}
 	request.GroupId = &groupIdInt64
 	changeFlag := false
 
-	if d.HasChange("remark") {
-		request.Remark = helper.String(d.Get("remark").(string))
-		changeFlag = true
+	mutableArgs := []string{"name", "remark"}
 
-	}
-	if d.HasChange("name") {
-		request.GroupName = helper.String(d.Get("name").(string))
-		changeFlag = true
+	for _, v := range mutableArgs {
+		if d.HasChange(v) {
+			changeFlag = true
+			break
+		}
 	}
 
 	if changeFlag {
+		request.GroupName = helper.String(d.Get("name").(string))
+		if v, ok := d.GetOk("remark"); ok {
+			request.Remark = helper.String(v.(string))
+		}
+
 		err := resource.Retry(writeRetryTimeout, func() *resource.RetryError {
 			response, e := meta.(*TencentCloudClient).apiV3Conn.UseCamClient().UpdateGroup(request)
 

tencentcloud/resource_tc_cam_group_test.go

@@ -63,11 +63,19 @@ func TestAccTencentCloudCamGroup_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("tencentcloud_cam_group.group_basic", "remark", "test"),
 				),
 			}, {
-				Config: testAccCamGroup_update,
+				Config: testAccCamGroup_update_name,
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCamGroupExists("tencentcloud_cam_group.group_basic"),
 					resource.TestCheckResourceAttr("tencentcloud_cam_group.group_basic", "name", "cam-group-test2"),
-					resource.TestCheckResourceAttr("tencentcloud_cam_group.group_basic", "remark", "test-update"),
+					resource.TestCheckResourceAttr("tencentcloud_cam_group.group_basic", "remark", "test"),
+				),
+			},
+			{
+				Config: testAccCamGroup_update_all,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckCamGroupExists("tencentcloud_cam_group.group_basic"),
+					resource.TestCheckResourceAttr("tencentcloud_cam_group.group_basic", "name", "cam-group-test3"),
+					resource.TestCheckResourceAttr("tencentcloud_cam_group.group_basic", "remark", "test3"),
 				),
 			},
 			{
@@ -133,9 +141,16 @@ resource "tencentcloud_cam_group" "group_basic" {
 }
 `
 
-const testAccCamGroup_update = `
+const testAccCamGroup_update_name = `
 resource "tencentcloud_cam_group" "group_basic" {
   name   = "cam-group-test2"
-  remark = "test-update"
+  remark = "test"
+}
+`
+
+const testAccCamGroup_update_all = `
+resource "tencentcloud_cam_group" "group_basic" {
+  name   = "cam-group-test3"
+  remark = "test3"
 }
 `