Don't emit unfinished warnings on workflow cancellation

Author: dandavison

temporalio/worker/_workflow_instance.py

@@ -434,7 +434,6 @@ def is_completion(command):
                 command.HasField("complete_workflow_execution")
                 or command.HasField("continue_as_new_workflow_execution")
                 or command.HasField("fail_workflow_execution")
-                or command.HasField("cancel_workflow_execution")
             )
 
         if any(map(is_completion, self._current_completion.successful.commands)):

tests/worker/test_workflow.py

@@ -5584,8 +5584,10 @@ class _UnfinishedHandlersOnWorkflowTerminationTest:
     async def test_warning_is_issued_on_exit_with_unfinished_handler(
         self,
     ):
-        assert await self._run_workflow_and_get_warning() == (
+        warning_emitted = await self._run_workflow_and_get_warning()
+        assert warning_emitted == (
             self.handler_waiting == "-no-wait-all-handlers-finish-"
+            and self.workflow_termination_type != "-cancellation-"
         )
 
     async def _run_workflow_and_get_warning(self) -> bool: