Skip to content

Commit 3316afb

Browse files
committed
Add activity IDs to test since they are now set in context
1 parent 4c93c77 commit 3316afb

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

tests/test_serialization_context.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ async def run(self, data: TraceData) -> TraceData:
179179
data,
180180
start_to_close_timeout=timedelta(seconds=10),
181181
heartbeat_timeout=timedelta(seconds=2),
182+
activity_id="activity-id",
182183
)
183184
data = await workflow.execute_child_workflow(
184185
EchoWorkflow.run, data, id=f"{workflow.info().workflow_id}_child"
@@ -231,7 +232,7 @@ async def test_payload_conversion_calls_follow_expected_sequence_and_contexts(
231232
workflow_id=workflow_id,
232233
workflow_type=PayloadConversionWorkflow.__name__,
233234
activity_type=passthrough_activity.__name__,
234-
activity_id=None,
235+
activity_id="activity-id",
235236
activity_task_queue=task_queue,
236237
is_local=False,
237238
)
@@ -329,6 +330,7 @@ async def run(self) -> TraceData:
329330
initial_interval=timedelta(milliseconds=100),
330331
maximum_attempts=2,
331332
),
333+
activity_id="activity-id",
332334
)
333335

334336

@@ -371,7 +373,7 @@ async def test_heartbeat_details_payload_conversion(client: Client):
371373
workflow_id=workflow_id,
372374
workflow_type=HeartbeatDetailsSerializationContextTestWorkflow.__name__,
373375
activity_type=activity_with_heartbeat_details.__name__,
374-
activity_id=None,
376+
activity_id="activity-id",
375377
activity_task_queue=task_queue,
376378
is_local=False,
377379
)
@@ -421,6 +423,7 @@ async def run(self, data: TraceData) -> TraceData:
421423
local_activity,
422424
data,
423425
start_to_close_timeout=timedelta(seconds=10),
426+
activity_id="activity-id",
424427
)
425428

426429

@@ -461,7 +464,7 @@ async def test_local_activity_payload_conversion(client: Client):
461464
workflow_id=workflow_id,
462465
workflow_type=LocalActivityWorkflow.__name__,
463466
activity_type=local_activity.__name__,
464-
activity_id=None,
467+
activity_id="activity-id",
465468
activity_task_queue=task_queue,
466469
is_local=True,
467470
)
@@ -575,7 +578,7 @@ async def test_async_activity_completion_payload_conversion(
575578
workflow_id=workflow_id,
576579
workflow_type=AsyncActivityCompletionSerializationContextTestWorkflow.__name__,
577580
activity_type=async_activity.__name__,
578-
activity_id=None,
581+
activity_id="async-activity-id",
579582
activity_task_queue=task_queue,
580583
is_local=False,
581584
)
@@ -648,7 +651,7 @@ def test_subclassed_async_activity_handle(client: Client):
648651
workflow_id="workflow-id",
649652
workflow_type="workflow-type",
650653
activity_type="activity-type",
651-
activity_id=None,
654+
activity_id="activity-id",
652655
activity_task_queue="activity-task-queue",
653656
is_local=False,
654657
)
@@ -1063,6 +1066,7 @@ async def run(self) -> Never:
10631066
failing_activity,
10641067
start_to_close_timeout=timedelta(seconds=10),
10651068
retry_policy=RetryPolicy(maximum_attempts=1),
1069+
activity_id="activity-id",
10661070
)
10671071
raise Exception("Unreachable")
10681072

@@ -1159,7 +1163,7 @@ async def test_failure_converter_with_context(client: Client):
11591163
workflow_id=workflow_id,
11601164
workflow_type=FailureConverterTestWorkflow.__name__,
11611165
activity_type=failing_activity.__name__,
1162-
activity_id=None,
1166+
activity_id="activity-id",
11631167
activity_task_queue=task_queue,
11641168
is_local=False,
11651169
)
@@ -1328,6 +1332,7 @@ async def run(self, data: str) -> str:
13281332
codec_test_local_activity,
13291333
data,
13301334
start_to_close_timeout=timedelta(seconds=10),
1335+
activity_id="activity-id",
13311336
)
13321337

13331338

@@ -1366,7 +1371,7 @@ async def test_local_activity_codec_with_context(client: Client):
13661371
workflow_id=workflow_id,
13671372
workflow_type=LocalActivityCodecTestWorkflow.__name__,
13681373
activity_type=codec_test_local_activity.__name__,
1369-
activity_id=None,
1374+
activity_id="activity-id",
13701375
activity_task_queue=task_queue,
13711376
is_local=True,
13721377
)
@@ -1600,6 +1605,7 @@ async def run(self, data: str) -> str:
16001605
payload_encryption_activity,
16011606
"outbound",
16021607
start_to_close_timeout=timedelta(seconds=10),
1608+
activity_id="activity-id",
16031609
),
16041610
workflow.execute_child_workflow(
16051611
PayloadEncryptionChildWorkflow.run,

0 commit comments

Comments
 (0)