Skip to content

Commit 9cd7ca8

Browse files
Quinn-With-Two-NsQuinn-With-Two-Ns
authored
Clean up some test assertions and make sure naming is consistent. (#2690)
Clean up some test assertions and make sure naming is consistent.
1 parent 4e9cc06 commit 9cd7ca8

File tree

80 files changed

+174
-185
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+174
-185
lines changed

‎temporal-opentracing/src/test/java/io/temporal/opentracing/ActivityFailureTest.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.temporal.opentracing;
22

33
import static org.junit.Assert.assertEquals;
4+
import static org.junit.Assert.assertNull;
45

56
import io.opentracing.Scope;
67
import io.opentracing.mock.MockSpan;
@@ -252,10 +253,10 @@ public void testBenignApplicationFailureSpanBehavior() {
252253

253254
// Second attempt: benign failure - should NOT have ERROR tag
254255
MockSpan secondAttemptSpan = activityRunSpans.get(1);
255-
assertEquals(null, secondAttemptSpan.tags().get(Tags.ERROR.getKey()));
256+
assertNull(secondAttemptSpan.tags().get(Tags.ERROR.getKey()));
256257

257258
// Third attempt: success - should not have ERROR tag
258259
MockSpan thirdAttemptSpan = activityRunSpans.get(2);
259-
assertEquals(null, thirdAttemptSpan.tags().get(Tags.ERROR.getKey()));
260+
assertNull(thirdAttemptSpan.tags().get(Tags.ERROR.getKey()));
260261
}
261262
}

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/ActivityStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/ActivityStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/CancelExternalStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/CancelExternalStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/CancelWorkflowStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/CancelWorkflowStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/ChildWorkflowStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/ChildWorkflowStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/CompleteWorkflowStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/CompleteWorkflowStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/ContinueAsNewWorkflowStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/ContinueAsNewWorkflowStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/FailWorkflowStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/FailWorkflowStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/LocalActivityStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/LocalActivityStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

‎temporal-sdk/src/main/java/io/temporal/internal/statemachines/MutableSideEffectStateMachine.puml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
` PlantUML <plantuml.com> State Diagram.
22
` Generated from src/main/java/io/temporal/internal/statemachines/MutableSideEffectStateMachine.java
3-
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagrams.
3+
` by io.temporal.internal.statemachines.CommandsGeneratePlantUMLStateDiagramsTest.
44

55

66
@startuml

0 commit comments

Comments
 (0)