cleanup - gate compilation at module and call site, use dbg_panic macro at state machines instead of direct calls to antithesis assert_always (dbg_panic just logs in non-release builds with no antithesis_assertions feature flag anyways)

Author: THardy98

crates/sdk-core/src/abstractions.rs

@@ -422,11 +422,12 @@ impl<SK: SlotKind> OwnedMeteredSemPermit<SK> {
 #[derive(Debug)]
 pub(crate) struct UsedMeteredSemPermit<SK: SlotKind>(#[allow(dead_code)] OwnedMeteredSemPermit<SK>);
 
-#[cfg(feature = "antithesis_assertions")]
 macro_rules! dbg_panic {
     ($($arg:tt)*) => {{
         let message = format!($($arg)*);
         error!("{}", message);
+
+        #[cfg(feature = "antithesis_assertions")]
         crate::antithesis::assert_always!(
             false,
             "dbg_panic invariant triggered",
@@ -440,14 +441,6 @@ macro_rules! dbg_panic {
         debug_assert!(false, "{}", message);
     }};
 }
-
-#[cfg(not(feature = "antithesis_assertions"))]
-macro_rules! dbg_panic {
-    ($($arg:tt)*) => {{
-        error!($($arg)*);
-        debug_assert!(false, $($arg)*);
-    }};
-}
 pub(crate) use dbg_panic;
 
 pub(crate) struct ActiveCounter<F: Fn(usize)>(watch::Sender<usize>, Option<Arc<F>>);

crates/sdk-core/src/antithesis.rs

@@ -2,61 +2,29 @@
 //!
 //! This module provides assertion macros that integrate with the Antithesis
 //! testing platform to detect invariant violations during fuzz testing.
-//!
-//! When the `antithesis_assertions` feature is disabled, assertions compile
-//! to no-ops.
-
-#[cfg(feature = "antithesis_assertions")]
-mod enabled {
-    use std::sync::OnceLock;
-
-    /// Ensure Antithesis is initialized exactly once.
-    pub(crate) fn ensure_init() {
-        static INIT: OnceLock<()> = OnceLock::new();
-        INIT.get_or_init(|| {
-            ::antithesis_sdk::antithesis_init();
-        });
-    }
 
-    /// Assert that a condition is always true during Antithesis fuzz testing.
-    /// Use `false` as the condition to log an invariant violation.
-    macro_rules! assert_always {
-        ($condition:expr, $message:literal, $details:expr) => {{
-            $crate::antithesis::ensure_init();
-            let details: ::serde_json::Value = $details;
-            ::antithesis_sdk::assert_always!($condition, $message, &details);
-        }};
-        ($condition:expr, $message:literal) => {{
-            $crate::antithesis::ensure_init();
-            ::antithesis_sdk::assert_always!($condition, $message);
-        }};
-    }
+use std::sync::OnceLock;
 
-    pub(crate) use assert_always;
+/// Ensure Antithesis is initialized exactly once.
+pub(crate) fn ensure_init() {
+    static INIT: OnceLock<()> = OnceLock::new();
+    INIT.get_or_init(|| {
+        ::antithesis_sdk::antithesis_init();
+    });
 }
 
-#[cfg(not(feature = "antithesis_assertions"))]
-mod disabled {
-    /// No-op when feature is disabled.
-    #[inline(always)]
-    pub(crate) fn ensure_init() {}
-
-    /// No-op assertion when feature is disabled.
-    macro_rules! assert_always {
-        ($condition:expr, $message:literal, $details:expr) => {{
-            let _ = ($condition, $message);
-            let _ = $details;
-        }};
-        ($condition:expr, $message:literal) => {{
-            let _ = ($condition, $message);
-        }};
-    }
-
-    pub(crate) use assert_always;
+/// Assert that a condition is always true during Antithesis fuzz testing.
+/// Use `false` as the condition to log an invariant violation.
+macro_rules! assert_always {
+    ($condition:expr, $message:literal, $details:expr) => {{
+        $crate::antithesis::ensure_init();
+        let details: ::serde_json::Value = $details;
+        ::antithesis_sdk::assert_always!($condition, $message, &details);
+    }};
+    ($condition:expr, $message:literal) => {{
+        $crate::antithesis::ensure_init();
+        ::antithesis_sdk::assert_always!($condition, $message);
+    }};
 }
 
-#[cfg(feature = "antithesis_assertions")]
-pub(crate) use enabled::*;
-
-#[cfg(not(feature = "antithesis_assertions"))]
-pub(crate) use disabled::*;
+pub(crate) use assert_always;

crates/sdk-core/src/lib.rs

@@ -12,6 +12,7 @@ extern crate tracing;
 extern crate core;
 
 mod abstractions;
+#[cfg(feature = "antithesis_assertions")]
 mod antithesis;
 #[cfg(feature = "debug-plugin")]
 pub mod debug_client;

crates/sdk-core/src/worker/workflow/machines/activity_state_machine.rs

@@ -194,15 +194,7 @@ impl ActivityMachine {
                     vec![self.create_cancelation_resolve(details).into()]
                 }
                 x => {
-                    crate::antithesis::assert_always!(
-                        false,
-                        "activity cancel yields supported command",
-                        ::serde_json::json!({
-                            "activity_seq": self.shared_state.attrs.seq,
-                            "unexpected_command": format!("{x:?}"),
-                            "state": self.state().to_string(),
-                        })
-                    );
+                    dbg_panic!("Invalid cancel event response {x:?}");
                     panic!("Invalid cancel event response {x:?}");
                 }
             })

crates/sdk-core/src/worker/workflow/machines/child_workflow_state_machine.rs

@@ -3,6 +3,7 @@ use super::{
     WFMachinesAdapter, WFMachinesError, fsm, workflow_machines::MachineResponse,
 };
 use crate::{
+    abstractions::dbg_panic,
     internal_flags::CoreInternalFlags,
     worker::workflow::{InternalFlagsRef, machines::HistEventData},
 };
@@ -497,16 +498,7 @@ impl ChildWorkflowMachine {
                     self.adapt_response(c, None)
                 }
                 x => {
-                    crate::antithesis::assert_always!(
-                        false,
-                        "child workflow cancel yields supported command",
-                        ::serde_json::json!({
-                            "workflow_id": self.shared_state.workflow_id.clone(),
-                            "run_id": self.shared_state.run_id.clone(),
-                            "unexpected_command": format!("{x:?}"),
-                            "state": self.state().to_string(),
-                        })
-                    );
+                    dbg_panic!("Invalid cancel event response {x:?}");
                     panic!("Invalid cancel event response {x:?}");
                 }
             })

crates/sdk-core/src/worker/workflow/machines/complete_workflow_state_machine.rs

@@ -2,7 +2,7 @@ use super::{
     EventInfo, NewMachineWithCommand, OnEventWrapper, StateMachine, TransitionResult,
     WFMachinesAdapter, WFMachinesError, fsm, workflow_machines::MachineResponse,
 };
-use crate::worker::workflow::machines::HistEventData;
+use crate::{abstractions::dbg_panic, worker::workflow::machines::HistEventData};
 use std::convert::TryFrom;
 use temporalio_common::protos::{
     coresdk::workflow_commands::CompleteWorkflowExecution,
@@ -42,13 +42,7 @@ pub(super) fn complete_workflow(attribs: CompleteWorkflowExecution) -> NewMachin
         {
             Some(CompleteWFCommand::AddCommand(c)) => c,
             unexpected => {
-                crate::antithesis::assert_always!(
-                    false,
-                    "complete workflow scheduling yields command",
-                    ::serde_json::json!({
-                        "unexpected": format!("{unexpected:?}"),
-                    })
-                );
+                dbg_panic!("complete wf machine on_schedule must produce command: {unexpected:?}");
                 panic!("complete wf machine on_schedule must produce command");
             }
         };