cleancode ingnore ElseExpression warming.

fix  BooleanArgumentFlag     The

- [x] method getText has a boolean flag argument $without_cmd, which is a certain sign of a Single Responsibility Principle violation.

- [x] The method printError has a boolean flag argument $return, which is a certain sign of a Single Responsibility Principle violation.

- [x] The method printError has a boolean flag argument $return, which is a certain sign of a Single Responsibility Principle violation.

Author: Moustafa-Elgammal

README.md

@@ -210,14 +210,14 @@ use TelegramBot\Entities\WebAppData;
 class MainPlugin extends \TelegramBot\Plugin {
 
    public function onMessage(int $update_id, Message $message): \Generator {
-      if ($message->getText() === '/start') {
+      if ($message->getText(false) === '/start') {
          yield \TelegramBot\Request::sendMessage([
             'chat_id' => $message->getChat()->getId(),
             'text' => 'Hello, ' . $message->getFrom()->getFirstName(),
          ]);
       }
 
-      if ($message->getText() === '/ping') {
+      if ($message->getText(false) === '/ping') {
          yield \TelegramBot\Request::sendMessage([
             'chat_id' => $message->getChat()->getId(),
             'text' => 'pong',

phpmd.xml

@@ -27,5 +27,7 @@
 
     <rule ref="rulesets/design.xml" />
 
-    <rule ref="rulesets/cleancode.xml" />
+    <rule ref="rulesets/cleancode.xml" >
+        <exclude name="ElseExpression"></exclude>
+    </rule>
 </ruleset>

src/Entities/Keyboard.php

@@ -72,7 +72,7 @@ public function setKeyboard(array $rows): array
             $this->addRow($row);
         }
 
-        return $this->getRawData();
+        return $this->getRawData(true);
     }
 
     /**
@@ -91,7 +91,7 @@ public function addRow(array $row): Keyboard
 
         $new_row = [];
         foreach ($row as $button) {
-            $new_row[] = $button->getRawData();
+            $new_row[] = $button->getRawData(true);
         }
 
         $this->raw_data[$keyboard_type][] = $new_row;

src/Entities/Message.php

@@ -85,7 +85,7 @@ class Message extends Entity
      *
      * @return string|null
      */
-    public function getText(bool $without_cmd = false): ?string
+    public function getText(bool $without_cmd): ?string
     {
         $text = $this->getProperty('text');
         $command = $this->getFullCommand();

src/Entities/Response.php

@@ -74,7 +74,7 @@ public function isOk(): bool
      * @param bool $return
      * @return bool|string
      */
-    public function printError(bool $return = false): bool|string
+    public function printError(bool $return): bool|string
     {
         $error = sprintf('Error N: %s, Description: %s', $this->getErrorCode(), $this->getDescription());
 

src/Entity.php

@@ -92,7 +92,7 @@ public static function escapeMarkdownV2(string $string): string {
     * @param bool $associated
     * @return array|string
     */
-   public function getRawData(bool $associated = true): array|string {
+   public function getRawData(bool $associated): array|string {
       return $associated ? $this->raw_data : json_encode($this->raw_data);
    }
 

src/Request.php

@@ -371,7 +371,7 @@ private static function getClient(): Client {
      */
     private static function getItemEncode($item): string {
         if ($item instanceof Entity) {
-            $item = $item->getRawData();
+            $item = $item->getRawData(true);
         }
 
         if (is_array($item)) {

tests/CrashTest.php

@@ -25,7 +25,7 @@ public function __process(Update $update): void {
                 CrashPad::sendCrash(
                     Telegram::getAdminId(),
                     new \Exception('test'),
-                    json_encode($update->getRawData(), JSON_PRETTY_PRINT)
+                    json_encode($update->getRawData(true), JSON_PRETTY_PRINT)
                 );
                 CrashPad::clearCrashLogs();
             }

tests/Examples/EchoBot/Plugins/MainPlugin.php

@@ -15,3 +15,4 @@ public function onMessage(int $update_id, Message $message): \Generator {
     }
 
 }
+

tests/WebhookTest.php

@@ -15,7 +15,7 @@ public function testAnonymousPlugins() {
 
             public function onMessage(int $update_id, Message $message): \Generator {
                 Assert::assertEquals(1, $update_id);
-                Assert::assertEquals('Hello World!', $message->getText());
+                Assert::assertEquals('Hello World!', $message->getText(false));
                 yield;
             }
 
@@ -26,7 +26,7 @@ public function onMessage(int $update_id, Message $message): \Generator {
 
         (new UpdateHandler())->addPlugins($plugin)->resolve(new Update([
             'update_id' => 1,
-            'message' => $message->getRawData(),
+            'message' => $message->getRawData(true),
         ]));
     }
 
@@ -46,10 +46,11 @@ public function __process(Update $update): void {
 
         $handler->resolve(new Update([
             'update_id' => 1,
-            'message' => DummyUpdate::message()->getRawData(),
+            'message' => DummyUpdate::message()->getRawData(true),
         ]));
 
         $this->assertTrue(true);
     }
 
 }
+