cleancode fix IfStatementAssignment warning message "Avoid assigning values to variables in if clauses and the like ..."

Author: Moustafa-Elgammal

src/CrashPad.php

@@ -83,7 +83,9 @@ public static function sendCrash(int $chat_id, Exception|Throwable $exception, s
           Telegram::tryAutoloadEnv();
         }
 
-        if (($token = self::loadToken()) === null) {
+        $token = self::loadToken();
+
+        if ($token === null) {
             throw new RuntimeException(
                 'The token is not set. Please set the token using `Telegram::setToken()` method.'
             );
@@ -180,7 +182,9 @@ public static function clearCrashLogs(): void
      */
     protected static function loadToken(): string|null
     {
-        if (($token = Telegram::getApiToken()) !== false) {
+        $token = Telegram::getApiToken();
+
+        if ($token !== false) {
             return $token;
         }
 

src/Entities/Message.php

@@ -88,8 +88,9 @@ class Message extends Entity
     public function getText(bool $without_cmd = false): ?string
     {
         $text = $this->getProperty('text');
+        $command = $this->getFullCommand();
 
-        if ($without_cmd && $command = $this->getFullCommand()) {
+        if ($without_cmd && $command) {
             if (strlen($command) + 1 < strlen($text)) {
                 return substr($text, strlen($command) + 1);
             }
@@ -201,7 +202,9 @@ public function getType(): string
      */
     public function getCommand(): ?string
     {
-        if ($command = $this->getProperty('command')) {
+        $command = $this->getProperty('command');
+
+        if ($command) {
             return $command;
         }
 

src/Entities/UserProfilePhotos.php

@@ -25,8 +25,9 @@ class UserProfilePhotos extends Entity
     public function getPhotos(): array
     {
         $all_photos = [];
+        $these_photos = $this->getProperty('photos');
 
-        if ($these_photos = $this->getProperty('photos')) {
+        if ($these_photos) {
             foreach ($these_photos as $photos) {
                 $all_photos[] = array_map(function ($photo) {
                     return new PhotoSize($photo);

src/TelegramLog.php

@@ -79,7 +79,9 @@ public static function initialize(LoggerInterface $logger = null, LoggerInterfac
      */
     public static function getDebugLogTempStream()
     {
-        if ((self::$debug_log_temp_stream_handle === null) && $temp_stream_handle = fopen('php://temp', 'wb+')) {
+        $temp_stream_handle = fopen('php://temp', 'wb+');
+
+        if ((self::$debug_log_temp_stream_handle === null) && $temp_stream_handle) {
             self::$debug_log_temp_stream_handle = $temp_stream_handle;
         }
 

src/Traits/PluginTrait.php

@@ -53,7 +53,9 @@ public function __execute(UpdateHandler $receiver, Update $update): void {
       }
 
       $type = $this->__identify($update);
-      if (method_exists($this, ($method = 'on' . $type)) && $type !== null) {
+      $method = 'on' . $type;
+
+      if (method_exists($this, $method) && $type !== null) {
          $this->__checkExit($this->__callEvent($method, $update));
       }
    }
@@ -110,4 +112,4 @@ private function __callEvent(string $method, Update $update): \Generator {
       };
    }
 
-}
+}