fix(deps): update dependency eslint-config-txo-typescript to ^3.2.10 (#139)

* fix(deps): update dependency eslint-config-txo-typescript to ^3.2.10

* chore: disable comma dangle in project

* chore: fix eslint issues

* chore: remove workaround for `comma-dangle`

* chore: update `txo-typescript` config to fix `comma-dangle` rule

* chore: fix eslint issues

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Erik Slovak <erik.slovak@technologystudio.sk>
Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>

Author: 3 people

package.json

@@ -24,7 +24,7 @@
     "semantic-release": "semantic-release"
   },
   "dependencies": {
-    "eslint-config-txo-typescript": "^3.1.82"
+    "eslint-config-txo-typescript": "^3.2.14"
   },
   "peerDependencies": {
     "eslint-plugin-jsx-a11y": "^6.7.1",

src/configs/jsx-a11y.js

@@ -13,11 +13,11 @@ module.exports = {
         // NOTE: If this error triggers, either disable it or add
         // your custom components, labels and attributes via these options
         // See https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-associated-control.md
-        controlComponents: ['Input'],
-      },
+        controlComponents: ['Input']
+      }
     ],
     'jsx-a11y/mouse-events-have-key-events': 'error',
     'jsx-a11y/role-has-required-aria-props': 'error',
-    'jsx-a11y/role-supports-aria-props': 'error',
-  },
+    'jsx-a11y/role-supports-aria-props': 'error'
+  }
 }

src/configs/react.js

@@ -10,6 +10,6 @@ module.exports = {
     'react-hooks/exhaustive-deps': 'error',
     'react/jsx-first-prop-new-line': ['error', 'multiline'],
     'react/jsx-uses-vars': 'error',
-    'react/display-name': 'off',
-  },
+    'react/display-name': 'off'
+  }
 }

src/configs/redux-saga.js

@@ -7,6 +7,6 @@
 module.exports = {
   rules: {
     'redux-saga/no-yield-in-race': 'error',
-    'redux-saga/yield-effects': 'error',
-  },
+    'redux-saga/yield-effects': 'error'
+  }
 }

src/index.js

@@ -11,26 +11,26 @@ module.exports = {
     ...[
       './configs/jsx-a11y',
       './configs/react',
-      './configs/redux-saga',
-    ].map(require.resolve),
+      './configs/redux-saga'
+    ].map(require.resolve)
   ],
   parser: '@typescript-eslint/parser',
   plugins: [
     '@typescript-eslint',
     'redux-saga',
     'react',
     'react-hooks',
-    'jsx-a11y',
+    'jsx-a11y'
   ],
   parserOptions: {
     ecmaVersion: 6,
     sourceType: 'module',
     ecmaFeatures: {
-      jsx: true,
+      jsx: true
     },
-    project: './tsconfig.json',
+    project: './tsconfig.json'
   },
   rules: {
-    strict: 'error',
-  },
+    strict: 'error'
+  }
 }

test/React.ts

@@ -10,15 +10,15 @@ import { useEffect } from 'react'
 type RulesOfHooksProps = { someProp?: string }
 export const RulesOfHooksOk = (props: RulesOfHooksProps): null => {
   useEffect(() => {
-    if (props.someProp) {
+    if (props.someProp != null && props.someProp !== '') {
       // localStorage.setItem('formData', name);
     }
   })
   return null
 }
 
 export const RulesOfHooksError = (props: RulesOfHooksProps): null => {
-  if (props.someProp) {
+  if (props.someProp != null && props.someProp !== '') {
     // eslint-disable-next-line react-hooks/rules-of-hooks
     useEffect(function persistForm () {
       // localStorage.setItem('formData', name);
@@ -31,7 +31,7 @@ export const RulesOfHooksError = (props: RulesOfHooksProps): null => {
 type ExhaustiveDepsProps = { someProp?: string }
 export const ExhaustiveDepsOk = (props: ExhaustiveDepsProps): null => {
   useEffect(() => {
-    if (props.someProp) {
+    if (props.someProp != null && props.someProp !== '') {
       // localStorage.setItem('formData', name);
     }
   }, [props.someProp])
@@ -40,7 +40,7 @@ export const ExhaustiveDepsOk = (props: ExhaustiveDepsProps): null => {
 
 export const ExhaustiveDepsError = (props: ExhaustiveDepsProps): null => {
   useEffect(() => {
-    if (props.someProp) {
+    if (props.someProp != null && props.someProp !== '') {
       // localStorage.setItem('formData', name);
     }
   // eslint-disable-next-line react-hooks/exhaustive-deps

yarn.lock

@@ -3004,10 +3004,10 @@ escape-string-regexp@^4.0.0:
   resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz#14ba83a5d373e3d311e5afca29cf5bfad965bf34"
   integrity sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA==
 
-eslint-config-standard-with-typescript@^31.0.0:
-  version "31.0.0"
-  resolved "https://registry.yarnpkg.com/eslint-config-standard-with-typescript/-/eslint-config-standard-with-typescript-31.0.0.tgz#763c3246ac739ef47337b2008d2ef2dc6088bb0d"
-  integrity sha512-FLTrcJR62gPPPFwwverxwDTcQDb4HOCfDqmELZgNMSbh1M/Ui36X47a9ZANeo3iuPhMOfvrfuShChW9chdasnA==
+eslint-config-standard-with-typescript@^34.0.0:
+  version "34.0.0"
+  resolved "https://registry.yarnpkg.com/eslint-config-standard-with-typescript/-/eslint-config-standard-with-typescript-34.0.0.tgz#00378cdfccad580367d9e6f14cf1493fd69bf7b5"
+  integrity sha512-zhCsI4/A0rJ1ma8sf3RLXYc0gc7yPmdTWRVXMh9dtqeUx3yBQyALH0wosHhk1uQ9QyItynLdNOtcHKNw8G7lQw==
   dependencies:
     "@typescript-eslint/parser" "^5.0.0"
     eslint-config-standard "17.0.0"
@@ -3017,12 +3017,12 @@ eslint-config-standard@17.0.0:
   resolved "https://registry.yarnpkg.com/eslint-config-standard/-/eslint-config-standard-17.0.0.tgz#fd5b6cf1dcf6ba8d29f200c461de2e19069888cf"
   integrity sha512-/2ks1GKyqSOkH7JFvXJicu0iMpoojkwB+f5Du/1SC0PtBL+s8v30k9njRZ21pm2drKYm2342jFnGWzttxPmZVg==
 
-eslint-config-txo-typescript@^3.1.82:
-  version "3.1.82"
-  resolved "https://registry.yarnpkg.com/eslint-config-txo-typescript/-/eslint-config-txo-typescript-3.1.82.tgz#3d81087667d3abb87456321eb9ffa1f31db4653f"
-  integrity sha512-rPzZDCB3cQ83ZDMR7kYv9Al/DGDz6wkds/KwAI7nzkkM+UWsaWEUQBHk4jlFQ6F3H5ngXaWb0IDRgYnwyAK+Sg==
+eslint-config-txo-typescript@^3.2.14:
+  version "3.2.14"
+  resolved "https://registry.yarnpkg.com/eslint-config-txo-typescript/-/eslint-config-txo-typescript-3.2.14.tgz#6d5e8fd349c5be1eaf935a80df5822ae07994c55"
+  integrity sha512-aUS7kjzCT/wM6YZG3Wnrh7OOfQNTbY0EdZJsGb6nPevKl2onpQ3J1EuLIodVtgiOS+bYIsnkdeKQFq+PjPVTlQ==
   dependencies:
-    eslint-config-standard-with-typescript "^31.0.0"
+    eslint-config-standard-with-typescript "^34.0.0"
     eslint-import-resolver-typescript "^3.5.3"
 
 eslint-formatter-pretty@^4.1.0: