Merge pull request #88 from rust-lang/tags-update

tags update

Author: technetos

src/main.rs

@@ -101,6 +101,11 @@ fn app() -> Result<(), Error> {
             tags::post,
             api::is_wg_and_teams,
         );
+        cmds.add_protected(
+            "?tags update {key} value...",
+            tags::update,
+            api::is_wg_and_teams,
+        );
         cmds.add("?tag {key}", tags::get);
         cmds.add("?tags", tags::get_all);
         cmds.help("?tags", "A key value store", tags::help);

src/tags.rs

@@ -4,48 +4,63 @@ use diesel::prelude::*;
 
 /// Remove a key value pair from the tags.  
 pub fn delete(args: Args) -> Result<(), Error> {
-    if api::is_wg_and_teams(&args)? {
-        let conn = DB.get()?;
-        let key = args
-            .params
-            .get("key")
-            .ok_or("Unable to retrieve param: key")?;
-
-        match diesel::delete(tags::table.filter(tags::key.eq(key))).execute(&conn) {
-            Ok(_) => args.msg.react(args.cx, "✅")?,
-            Err(_) => api::send_reply(&args, "A database error occurred when deleting the tag.")?,
-        }
+    let conn = DB.get()?;
+    let key = args
+        .params
+        .get("key")
+        .ok_or("Unable to retrieve param: key")?;
+
+    match diesel::delete(tags::table.filter(tags::key.eq(key))).execute(&conn) {
+        Ok(_) => args.msg.react(args.cx, "✅")?,
+        Err(_) => api::send_reply(&args, "A database error occurred when deleting the tag.")?,
     }
     Ok(())
 }
 
 /// Add a key value pair to the tags.  
 pub fn post(args: Args) -> Result<(), Error> {
-    if api::is_wg_and_teams(&args)? {
-        let conn = DB.get()?;
-
-        let key = args
-            .params
-            .get("key")
-            .ok_or("Unable to retrieve param: key")?;
-
-        let value = args
-            .params
-            .get("value")
-            .ok_or("Unable to retrieve param: value")?;
-
-        match diesel::insert_into(tags::table)
-            .values((tags::key.eq(key), tags::value.eq(value)))
-            .execute(&conn)
-        {
-            Ok(_) => args.msg.react(args.cx, "✅")?,
-            Err(_) => api::send_reply(&args, "A database error occurred when creating the tag.")?,
-        }
-    } else {
-        api::send_reply(
-            &args,
-            "Please reach out to a Rust team/WG member to create a tag.",
-        )?;
+    let conn = DB.get()?;
+
+    let key = args
+        .params
+        .get("key")
+        .ok_or("Unable to retrieve param: key")?;
+
+    let value = args
+        .params
+        .get("value")
+        .ok_or("Unable to retrieve param: value")?;
+
+    match diesel::insert_into(tags::table)
+        .values((tags::key.eq(key), tags::value.eq(value)))
+        .execute(&conn)
+    {
+        Ok(_) => args.msg.react(args.cx, "✅")?,
+        Err(_) => api::send_reply(&args, "A database error occurred when creating the tag.")?,
+    }
+    Ok(())
+}
+
+/// Update an existing tag.
+pub fn update(args: Args) -> Result<(), Error> {
+    let conn = DB.get()?;
+
+    let key = args
+        .params
+        .get("key")
+        .ok_or("Unable to retrieve param: key")?;
+
+    let value = args
+        .params
+        .get("value")
+        .ok_or("Unable to retrieve param: value")?;
+
+    match diesel::update(tags::table.filter(tags::key.eq(key)))
+        .set(tags::value.eq(value))
+        .execute(&conn)
+    {
+        Ok(_) => args.msg.react(args.cx, "✅")?,
+        Err(_) => api::send_reply(&args, "A database error occurred when updating the tag.")?,
     }
 
     Ok(())
@@ -97,6 +112,7 @@ pub fn get_all(args: Args) -> Result<(), Error> {
 pub fn help(args: Args) -> Result<(), Error> {
     let help_string = "```
 ?tags create {key} value...     Create a tag.  Limited to WG & Teams.
+?tags update {key} value...     Update a tag.  Limited to WG & Teams.
 ?tags delete {key}              Delete a tag.  Limited to WG & Teams.
 ?tags help                      This menu.
 ?tags                           Get all the tags.