feat: ✨ Removed decorator use case

Author: ddanier

pydantic_async_validation/fastapi.py

@@ -1,11 +1,12 @@
-from collections.abc import Callable
-from typing import Any, Type, Union
+from contextlib import contextmanager
+from typing import Generator
 
 from fastapi.exceptions import RequestValidationError
 from pydantic import ValidationError
 
 
-class ensure_request_validation_errors():
+@contextmanager
+def ensure_request_validation_errors() -> Generator[None, None, None]:
     """
     Converter for `ValidationError` to `RequestValidationError`.
 
@@ -17,43 +18,14 @@ class ensure_request_validation_errors():
 
     Usage examples:
 
-    ```python
-    # Use as a decorator
-    @ensure_request_validation_errors
-    def some_func():
-        some_code_doing_extra_validation()  # for example async validation
-    ```
-
     ```python
     # Use as a context manager
     with ensure_request_validation_errors():
         some_code_doing_extra_validation()  # for example async validation
     ```
     """
 
-    func: Union[Callable, None]
-
-    def __init__(self, func: Union[Callable, None] = None) -> None:
-        self.func = func
-
-    def __call__(self, *args: Any, **kwargs: Any) -> Any:
-        if self.func is None:
-            raise RuntimeError("No func given")
-
-        with self:
-            return self.func(*args, **kwargs)
-
-    def __enter__(self) -> None:
-        pass
-
-    def __exit__(
-        self,
-        exc_type: Union[Type[Exception], None],
-        exc_value: Union[Exception, None],
-        traceback: Any,
-    ) -> None:
-        if exc_value is None:
-            return
-
-        if isinstance(exc_value, ValidationError):
-            raise RequestValidationError(errors=exc_value.errors())
+    try:
+        yield
+    except ValidationError as O_o:
+        raise RequestValidationError(errors=O_o.errors())

tests/test_fastapi.py

@@ -42,12 +42,6 @@ async def with_context_manager():
         with ensure_request_validation_errors():
             await instance.model_async_validate()
 
-    @app.get("/with-request-validation-errors-decorator")
-    @ensure_request_validation_errors
-    async def with_decorator():
-        instance = SomethingModel(name="invalid")
-        await instance.model_async_validate()
-
     return app
 
 
@@ -70,10 +64,3 @@ def test_fastapi_triggers_validation_response(app):
     with TestClient(app) as client:
         response = client.get("/with-request-validation-errors")
         assert response.status_code == 422
-
-
-@pytest.mark.skipif(fastapi is None, reason="fastapi not installed")
-def test_fastapi_triggers_validation_response_by_decorator(app):
-    with TestClient(app) as client:
-        response = client.get("/with-request-validation-errors-decorator")
-        assert response.status_code == 422