fixed cosine array copy

Author: tdebatty

src/main/java/info/debatty/java/stringsimilarity/Cosine.java

@@ -93,15 +93,11 @@ protected static double norm(final int[] profile) {
     protected static double dotProduct(
             final int[] profile1, final int[] profile2) {
 
-        // Make a copy to ensure both profiles have the same size
-        // this is actually quite dirty and should be corrected!
-        int length = Math.max(profile1.length, profile2.length);
-        int[] copy1 = java.util.Arrays.copyOf(profile1, length);
-        int[] copy2 = java.util.Arrays.copyOf(profile2, length);
-
+        // profiles may not have the same length
+        int length = Math.min(profile1.length, profile2.length);
         double agg = 0;
         for (int i = 0; i < length; i++) {
-            agg += 1.0 * copy1[i] * copy2[i];
+            agg += 1.0 * profile1[i] * profile2[i];
         }
         return agg;
     }
@@ -112,7 +108,7 @@ protected static double dotProduct(
      * @param s2
      * @return
      */
-    public double distance(final String s1, final String s2) {
+    public final double distance(final String s1, final String s2) {
         return 1.0 - similarity(s1, s2);
     }