Merge rust-bitcoin#5134: Remove stale comment in transaction decoding

apoelstra · apoelstra · commit d819f08eb25c · 2025-10-14T18:31:16.000Z
fa480cb Remove stale comment in transaction decoding (Tobin C. Harding) Pull request description: This comment is stale now that we remove the old transition stuff. ACKs for top commit: apoelstra: ACK fa480cb; successfully ran local tests Tree-SHA512: bab1b1b9dc95de2dc6c7e0c6860222c94acf3adcad3d314f3ee615ef602854fe5c568a4b1c6e3eea808217c3ac46cb59809a6cbfab0aaab3e7f2787cec1bfa7c
diff --git a/primitives/src/transaction.rs b/primitives/src/transaction.rs
@@ -464,8 +464,6 @@ impl Decoder for TransactionDecoder {
                     self.state = State::Inputs(version, Attempt::Second, VecDecoder::<TxIn>::new());
                 }
                 State::Outputs(version, inputs, is_segwit, decoder) => {
-                    // We get the inputs vector here instead of in the pattern match because I
-                    // couldn't find another way to get it out of behind the mutable reference.
                     let outputs = decoder.end()?;
                     if is_segwit == IsSegwit::Yes {
                         self.state = State::Witnesses(

Original file line number	Diff line number	Diff line change
`@@ -464,8 +464,6 @@ impl Decoder for TransactionDecoder {`
`464`	`464`	`self.state = State::Inputs(version, Attempt::Second, VecDecoder::<TxIn>::new());`
`465`	`465`	`}`
`466`	`466`	`State::Outputs(version, inputs, is_segwit, decoder) => {`
`467`		`- // We get the inputs vector here instead of in the pattern match because I`
`468`		`- // couldn't find another way to get it out of behind the mutable reference.`
`469`	`467`	`let outputs = decoder.end()?;`
`470`	`468`	`if is_segwit == IsSegwit::Yes {`
`471`	`469`	`self.state = State::Witnesses(`